[Commits] [wesnoth/wesnoth] 335ffa: MP Create Game: minor improvements

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 335ffa1b810090a55600a2e14060a8901c24247d
      https://github.com/wesnoth/wesnoth/commit/335ffa1b810090a55600a2e14060a8901c24247d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-20 (Mon, 20 Nov 2017)

  Changed paths:
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/create_engine.hpp
    M src/game_initialization/multiplayer.cpp
    M src/game_initialization/singleplayer.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.hpp

  Log Message:
  -----------
  MP Create Game: minor improvements

* The dialog now owns its own create_engine object. Previously, it was created immediately
  adjacent to the dialog object and passed in by reference, which made no sense.
* The create_engine also no longer takes a CVideo reference and instead initializes its CVideo
  member from the singleton.
* The 'Registered Users Only' toggle is now disabled if the host isn't registered themselves
  (fixes #2206)
* The above setting, along with Observers, Strict Sync, and Game Password, are disabled in local
  mode. These don't really make sense when not playing a networked game.