[Commits] [wesnoth/wesnoth] edb07f: CVideo: formatting and doc update

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: edb07f0cd4b3d2ae1fe1154eeabdcb773102fae5
      https://github.com/wesnoth/wesnoth/commit/edb07f0cd4b3d2ae1fe1154eeabdcb773102fae5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-21 (Tue, 21 Nov 2017)

  Changed paths:
    M src/video.cpp
    M src/video.hpp

  Log Message:
  -----------
  CVideo: formatting and doc update

Also renamed a few functions to use snake case or be a little more descriptive.


  Commit: 3da90773122ff852c8feee9fa80a62ce607fc508
      https://github.com/wesnoth/wesnoth/commit/3da90773122ff852c8feee9fa80a62ce607fc508
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-21 (Tue, 21 Nov 2017)

  Changed paths:
    M src/controller_base.cpp
    M src/desktop/notifications.cpp
    M src/desktop/windows_tray_notification.cpp
    M src/display.hpp
    M src/sdl/rect.cpp
    M src/sdl/window.cpp
    M src/sdl/window.hpp
    M src/video.cpp
    M src/video.hpp

  Log Message:
  -----------
  CVideo/Display: cleaned up/slightly refactored a few things

* display::w() and display::h() now simply forward to CVideo::getx() and gety() instead of querying
  the underlying window object. This is a slight semantic change, since now these functions return
  screen coordinates instead of pixels, but that's probably what we want in the long term anyway.
* sdl::window::get_flags() now returns the proper uint32_t instead of int
* Added a dedicated CVideo::window_has_flags function since testing window flags was the most common
  use of the underlying sdl window outside the class.
* Made CVideo::set_window_mode private. This is an implementation detail and shouldn't be public.
* Removed BPP argument from CVideo::make_test_fake. It's never passed anything other than 32, and
  we're long past the time when we care about window BPP.
* Removed sdl/window.hpp include from video.hpp. This was mostly only there to allow other area of
  the code to call get_window()->get_flags() (and for display.hpp). There's no real reason for it to
  be there anymore and was just making any modification to the sdl window header take ages.


  Commit: 5703c49ae4a7c2c5e89dee0dc4e0071208f5c987
      https://github.com/wesnoth/wesnoth/commit/5703c49ae4a7c2c5e89dee0dc4e0071208f5c987
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-21 (Tue, 21 Nov 2017)

  Changed paths:
    M src/game_display.cpp
    M src/game_display.hpp

  Log Message:
  -----------
  Game Display: removed unused create_dummy_display function

This was probably used before we had the fake_display_manager class.


Compare: https://github.com/wesnoth/wesnoth/compare/05cc5e6b88b1...5703c49ae4a7