[Commits] [wesnoth/wesnoth] acd31b: MP Game Utils: formatting and minor code cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: acd31b1a773c186eb3e9e860f5292e231cf0f18d
      https://github.com/wesnoth/wesnoth/commit/acd31b1a773c186eb3e9e860f5292e231cf0f18d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-24 (Fri, 24 Nov 2017)

  Changed paths:
    M src/game_initialization/mp_game_utils.cpp

  Log Message:
  -----------
  MP Game Utils: formatting and minor code cleanup


  Commit: f4584b6b722a98ecd9800f6a0d58b948900b0eea
      https://github.com/wesnoth/wesnoth/commit/f4584b6b722a98ecd9800f6a0d58b948900b0eea
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-24 (Fri, 24 Nov 2017)

  Changed paths:
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/mp_game_utils.cpp
    M src/game_initialization/singleplayer.cpp
    M src/game_launcher.cpp
    M src/mp_game_settings.cpp
    M src/mp_game_settings.hpp
    M src/savegame.cpp

  Log Message:
  -----------
  MP Game Settings: removed show_connect member

Early in the 1.13 development cycle there used to be an option to show the mp_connect screen
(now mp_staging) before starting an SP campaign. That was scrapped and the only code that used
it (in the SP initialization process) commented it out. Since we're not going to restore it,
might as well remove this flag.

Also removes the one instance remaining of a "show_configure" flag. Pretty sure this might have
also been a relic from the same time as show_connect, but it looks like it was since removed.
SP now has a dedicated screen for configuring active modifications in SP, which was the only
reason to show the configure dialog anyway (plus the mp create and configure screens were combined
later in 1.13 anyway).


  Commit: 5481a7985f4dec0e1c96ec552a198f48118c2684
      https://github.com/wesnoth/wesnoth/commit/5481a7985f4dec0e1c96ec552a198f48118c2684
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-24 (Fri, 24 Nov 2017)

  Changed paths:
    M src/game_initialization/singleplayer.cpp
    M src/game_initialization/singleplayer.hpp
    M src/game_launcher.cpp

  Log Message:
  -----------
  Cleaned up SP initialization function parameters

As of f4584b6b722a9 the game_config isn't needed in SP initialization anymore, and
enter_connect_mode can be made to return void.


Compare: https://github.com/wesnoth/wesnoth/compare/21eb31b75779...5481a7985f4d