[Commits] [wesnoth/wesnoth] 4ff249: Fixed regression in 8bf95ce69a9bd59 (fixes #2245)

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4ff249da7d21b1a2b2092c2b53a1991530649f1d
      https://github.com/wesnoth/wesnoth/commit/4ff249da7d21b1a2b2092c2b53a1991530649f1d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-27 (Mon, 27 Nov 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.cpp
    M src/gui/core/event/dispatcher.hpp
    M src/gui/core/event/handler.cpp

  Log Message:
  -----------
  Fixed regression in 8bf95ce69a9bd59 (fixes #2245)

I thought changing what the return value of sdl_event_handler::hotkey_pressed meant wouldn't
cause any regressions, but apparently I was wrong. This made it so certain key-down events
were never fired at all, meaning the associated keys could never be entered in a textbox.
Pretty serious!

I've restored the bool retval to dispatcher::execute_hotkey. It will return false if there's
no associated hotkey function (like before), and true otherwise. sdl_event_handler::hotkey_pressed
has also been reverted to return the value of that function.


  Commit: a21697fef33d2d402d3df5fd591d970abe7f69b2
      https://github.com/wesnoth/wesnoth/commit/a21697fef33d2d402d3df5fd591d970abe7f69b2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-27 (Mon, 27 Nov 2017)

  Changed paths:
    M src/game_launcher.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/preferences_dialog.hpp
    M src/gui/dialogs/title_screen.cpp
    M src/hotkey/command_executor.cpp
    M src/preferences/general.cpp
    M src/preferences/general.hpp
    M src/sdl/point.hpp
    M src/video.cpp
    M src/video.hpp

  Log Message:
  -----------
  Cleaned up various areas of code related to setting window resolution

* Added a point ctor that takes an SDL_Point.
* Added a toggle_fullscreen function to CVideo.
* Change all management of resolution data to use point instead of std::pair<int, int>. This
  shortens the code considerably.
* Cleaned up preferences_dialog::set_resolution_list
* Made CVideo::set_resolution return a bool indicating whether resolution was changed.
* Swapped which of the two set_resolution overloads contains the main implementation.
* Moved the events::raise_resize_event() call when setting resolution to the CVideo function
  where it should have always been (instead of the prefs dialog callback). This is a pretty
  essential component and having it localized in one place meant any other area of the code
  that might have called set_resolution wouldn't have it.


Compare: https://github.com/wesnoth/wesnoth/compare/4d0c46164e1b...a21697fef33d