[Commits] [wesnoth/wesnoth] e8655a: Display: one (hopefully) significant optimization ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e8655af1b419a1e728a8d2fa50eaef5206386c9e
      https://github.com/wesnoth/wesnoth/commit/e8655af1b419a1e728a8d2fa50eaef5206386c9e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-27 (Mon, 27 Nov 2017)

  Changed paths:
    M src/display.cpp
    M src/display.hpp

  Log Message:
  -----------
  Display: one (hopefully) significant optimization and one minor one

Copying the blit_helper objects when adding them to the drawing buffer was expensive since
blit_helper contains a vector of surfaces. We definitely want to copy that as little as
possible.

Also used std::move when fetching fog/shroud images. This function apparently has little
overhead, but still nice to not make copies here.

Also made get_terrain_images return void (this is just minor cleanup, not an optimization).
No need for it to return a reference to a class member.