[Commits] [wesnoth/wesnoth] 9bf248: Game Events: throw out custom handler_list impleme...

[GitHub]

  Branch: refs/heads/event_handler_list_refactor_pass_2
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9bf24847a808422c4762db666ca46e336a17cc4c
      https://github.com/wesnoth/wesnoth/commit/9bf24847a808422c4762db666ca46e336a17cc4c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/game_events/handlers.cpp
    M src/game_events/handlers.hpp
    M src/game_events/manager.cpp
    M src/game_events/manager.hpp
    M src/game_events/manager_impl.cpp
    M src/game_events/manager_impl.hpp

  Log Message:
  -----------
  Game Events: throw out custom handler_list implementation

This replaces it with the standard std::list interface. I've attempted to make this change as least invasive
as possible, so I have not touched the manager::iteration class. It can probably be refactored further later,
but the crux of this change is simply to allow the removal of the custom smart_list container while keeping
the chance of breakage to a minimum.

The new implementation cannot be an std::forward_list since that only has front-insertion capabilities
while back-insertion is needed.


  Commit: eada9522ef247663f31646b05ab3564e8299fc0c
      https://github.com/wesnoth/wesnoth/commit/eada9522ef247663f31646b05ab3564e8299fc0c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/game_events/manager.cpp

  Log Message:
  -----------
  test a thing


  Commit: 2ef6915a4ce48ee049e0eda23365eba2d7a20ed5
      https://github.com/wesnoth/wesnoth/commit/2ef6915a4ce48ee049e0eda23365eba2d7a20ed5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/game_events/manager.cpp

  Log Message:
  -----------
  Re-add validation check


  Commit: 3230d1178f23d90a4b2c9da3e26b7917c6d30a14
      https://github.com/wesnoth/wesnoth/commit/3230d1178f23d90a4b2c9da3e26b7917c6d30a14
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-28 (Tue, 28 Nov 2017)

  Changed paths:
    M src/game_events/handlers.cpp
    M src/game_events/handlers.hpp
    M src/game_events/manager.cpp
    M src/game_events/manager_impl.cpp
    M src/game_events/manager_impl.hpp
    M src/game_events/pump.cpp

  Log Message:
  -----------
  Attempt refactoring 1


Compare: https://github.com/wesnoth/wesnoth/compare/9bf24847a808^...3230d1178f23