[Commits] [wesnoth/wesnoth] 4dbe4f: Eliminate use of string_view::at

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4dbe4fbbb24b0e3546e6afd1c4bcc012cb431942
      https://github.com/wesnoth/wesnoth/commit/4dbe4fbbb24b0e3546e6afd1c4bcc012cb431942
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2017-11-29 (Wed, 29 Nov 2017)

  Changed paths:
    M src/font/text.cpp
    M src/serialization/string_view.hpp

  Log Message:
  -----------
  Eliminate use of string_view::at

We only use it in once place. At that point we can guarantee we stay in-bounds. So there is no need to use at() to check we remain in-bounds.

This eliminates a warning when building Debug for Windows (quieting Appveyor).

AI0886 had a similar issue building using GCC 6.3 on Boost 1.62

Reverting ca03818fa897a558d9ad5d9c3729404f5959029f and 0cbab6eeedff676a57191440c0b2b89b923bfaad since this changeset should correct both issues.