[Commits] [wesnoth/wesnoth] cd6144: Ensure that mp_test_executor exits
GitHub
noreply at github.com
Thu Nov 30 08:33:44 UTC 2017
Branch: refs/heads/test-master
Home: https://github.com/wesnoth/wesnoth
Commit: cd61443f1cf3c9c1fe08e76bde5601ce0d24e687
https://github.com/wesnoth/wesnoth/commit/cd61443f1cf3c9c1fe08e76bde5601ce0d24e687
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M utils/travis/mp_test_executor.sh
Log Message:
-----------
Ensure that mp_test_executor exits
Commit: b8186dd25c1e2e6617f6642ffe9c17a4a12de336
https://github.com/wesnoth/wesnoth/commit/b8186dd25c1e2e6617f6642ffe9c17a4a12de336
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M utils/travis/mp_test_executor.sh
Log Message:
-----------
MP test: treat failed init of SDL_video as a 'successful' test
Commit: ec90985849a0097c1d3f5b3ea0b6d929a0376f7d
https://github.com/wesnoth/wesnoth/commit/ec90985849a0097c1d3f5b3ea0b6d929a0376f7d
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M utils/travis/mp_test_executor.sh
Log Message:
-----------
Add missing break
Commit: 51fc433f750981523e4dcb8006ea59136165eb43
https://github.com/wesnoth/wesnoth/commit/51fc433f750981523e4dcb8006ea59136165eb43
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M utils/travis/mp_test_executor.sh
Log Message:
-----------
Change *_RUNNING vars to string comparisons
Commit: 3523e13c8e9dd5543d9af3c38d4cb0508c342980
https://github.com/wesnoth/wesnoth/commit/3523e13c8e9dd5543d9af3c38d4cb0508c342980
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
R data/ai/dev/idle_ai.cfg
Log Message:
-----------
Idle AI: remove from data/ai/dev after all
It was left there in cfb2aa8050 for backward compatibility. However,
this causes a “duplicate AI” error at start-up in debug mode.
Furthermore, the file is not included in any current 1.12 or 1.13
add-on, so it should be safe to remove it. Using
[ai]ai_algorithm=idle_ai is the preferred option to include the Idle AI.
Commit: ed363335013162df5fd8a24b677ff2d7803ed9c6
https://github.com/wesnoth/wesnoth/commit/ed363335013162df5fd8a24b677ff2d7803ed9c6
Author: Paŭlo Ebermann <paul at fencing-game.de>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/wesnoth/wmltools3.py
Log Message:
-----------
Fix the output by --progress.
Previously, this just printed the last file name again and again.
Now we are printing the file name we are currently looking at.
This can be observed e.g. by `wmlscope --progress`.
Commit: 6151fea80487789d56a62452b79b8e23e2583347
https://github.com/wesnoth/wesnoth/commit/6151fea80487789d56a62452b79b8e23e2583347
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/saved_game.cpp
Log Message:
-----------
Saved Game: formatting cleanup
Commit: 5597e1120b4c1faa8efae7f967b6f61b9e74447b
https://github.com/wesnoth/wesnoth/commit/5597e1120b4c1faa8efae7f967b6f61b9e74447b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/saved_game.cpp
Log Message:
-----------
Saved Game: replaced some uses of boost::copy with simpler std::transform equivalents
Commit: d9c7a2d80298c79d66718d455f744b2f13174aac
https://github.com/wesnoth/wesnoth/commit/d9c7a2d80298c79d66718d455f744b2f13174aac
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/configuration.cpp
M src/carryover.cpp
M src/game_initialization/create_engine.cpp
M src/persist_var.cpp
M src/preferences/game.cpp
M src/saved_game.cpp
M src/tests/test_config.cpp
M src/whiteboard/manager.cpp
Log Message:
-----------
Use config::clear over assignment to default-constructed object
Commit: d65df4ca1ce765964acfd0654980710bd549cf56
https://github.com/wesnoth/wesnoth/commit/d65df4ca1ce765964acfd0654980710bd549cf56
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
Minor tweaks to user map/scenario default descriptions
* Added period to "No description available." Technically this is just the default no-description text, but it
appears most often for custom scenarios.
* "User made map" -> "Custom map."
Commit: c20a6855fee4bd244f587e0f5acc1e1bfe0f9b48
https://github.com/wesnoth/wesnoth/commit/c20a6855fee4bd244f587e0f5acc1e1bfe0f9b48
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/filesystem.hpp
M src/filesystem_boost.cpp
Log Message:
-----------
Filesystem: added optional remove_extension parameter to base_name
Commit: 03f85d177a7945f9ab12beaabaf4d6b7eb9e586f
https://github.com/wesnoth/wesnoth/commit/03f85d177a7945f9ab12beaabaf4d6b7eb9e586f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/map/map_context.cpp
Log Message:
-----------
Editor: don't include file extension in default scenario id/name (fixes #1840)
Commit: 8f836d1937273daf6f5268274675fe82f93acc04
https://github.com/wesnoth/wesnoth/commit/8f836d1937273daf6f5268274675fe82f93acc04
Author: galegosimpatico <galegosimpatico at outlook.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .gitignore
M CMakeLists.txt
M INSTALL.md
M SConstruct
M projectfiles/VC12/README.md
Log Message:
-----------
On Boost: update build scripts and documentation.
At branch 'doc-from-discord-boost-discussion-20170926'.
The build documentation and scripts were slightly out of date about
Boost. This commit makes a (probably interim) update to them.
(CMakeLists.txt|SConstruct): `wesnoth` won't build using Boost earlier
than '1.50.0'. Boost 1.50.0 changed the location of version 3 of Boost
filesystem, from 'boost/filesystem/v3/' (e.g. for
'using boost::filesystem::v3::path;') to 'boost/filesystem/' (e.g. for
'using boost::filesystem::path;', enforced since the very introduction
of 'src/filesystem_boost.cpp'), making it incompatible unless using
precompiler directives for supporting backwards versions of Boost
filesystem prior than '1.50.0'. Using Boost 1.50.0 (and 51, 52 etc.)
`wesnoth` is able build and run. I checked using `ldd` that I am right
about the run time environment.
INSTALL.md: Requirement of Boost libraries version up to date.
projectfiles/VC12/README.md: Requirement of Boost libraries up to
date, only the statement of which one is the minimum version, not the
rest of the build guide for Boost as requirement.
.gitignore: Add KDevelop backup documents.
Commit: 0f38ce6d09497852ac899c7ad4a488566b90b743
https://github.com/wesnoth/wesnoth/commit/0f38ce6d09497852ac899c7ad4a488566b90b743
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/playcampaign.cpp
Log Message:
-----------
Removed extraneous newline from Defeat message
Commit: ba3e4636619c98131a74ee9c01b72d57b2e036cb
https://github.com/wesnoth/wesnoth/commit/ba3e4636619c98131a74ee9c01b72d57b2e036cb
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
M src/SConscript
Log Message:
-----------
Removed Optimized build, improved gcc LTO support, add clang LTO support.
Commit: 85591ce0257d5e4670f0381dc3c972623438d48a
https://github.com/wesnoth/wesnoth/commit/85591ce0257d5e4670f0381dc3c972623438d48a
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
Log Message:
-----------
Fixup as requested.
Commit: dcfd61e84fd789583e497786a123417149867808
https://github.com/wesnoth/wesnoth/commit/dcfd61e84fd789583e497786a123417149867808
Author: newfrenchy83 <31768074+newfrenchy83 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/units/unit.cpp
Log Message:
-----------
fix hitpoints being restored by heal_full after modifications expire (#2029)
Commit: a802b685e4388c8dab722accf7ebd57a9f3f4e58
https://github.com/wesnoth/wesnoth/commit/a802b685e4388c8dab722accf7ebd57a9f3f4e58
Author: Celtic Minstrel <CelticMinstrel at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/about.cfg
Log Message:
-----------
Add recent new contributors to credits
Commit: 2a1be25643d8214c193b8326129ec55b514e1730
https://github.com/wesnoth/wesnoth/commit/2a1be25643d8214c193b8326129ec55b514e1730
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
A data/core/images/terrain/castle/elven-ruin/castle-concave-bl.png
A data/core/images/terrain/castle/elven-ruin/castle-concave-br.png
A data/core/images/terrain/castle/elven-ruin/castle-concave-l.png
A data/core/images/terrain/castle/elven-ruin/castle-concave-r.png
A data/core/images/terrain/castle/elven-ruin/castle-concave-tl.png
A data/core/images/terrain/castle/elven-ruin/castle-concave-tr.png
A data/core/images/terrain/castle/elven-ruin/castle-convex-bl.png
A data/core/images/terrain/castle/elven-ruin/castle-convex-br.png
A data/core/images/terrain/castle/elven-ruin/castle-convex-l.png
A data/core/images/terrain/castle/elven-ruin/castle-convex-r.png
A data/core/images/terrain/castle/elven-ruin/castle-convex-tl.png
A data/core/images/terrain/castle/elven-ruin/castle-convex-tr.png
A data/core/images/terrain/castle/elven-ruin/castle2-concave-bl.png
A data/core/images/terrain/castle/elven-ruin/castle2-concave-br.png
A data/core/images/terrain/castle/elven-ruin/castle2-concave-tl.png
A data/core/images/terrain/castle/elven-ruin/castle2-concave-tr.png
A data/core/images/terrain/castle/elven-ruin/castle2-convex-bl.png
A data/core/images/terrain/castle/elven-ruin/castle2-convex-br.png
A data/core/images/terrain/castle/elven-ruin/castle2-convex-l.png
A data/core/images/terrain/castle/elven-ruin/castle2-convex-tr.png
A data/core/images/terrain/castle/elven-ruin/castle3-concave-br.png
A data/core/images/terrain/castle/elven-ruin/castle3-concave-tl.png
A data/core/images/terrain/castle/elven-ruin/grounds.png
A data/core/images/terrain/castle/elven-ruin/grounds2.png
A data/core/images/terrain/castle/elven-ruin/grounds3.png
A data/core/images/terrain/castle/elven-ruin/grounds4.png
A data/core/images/terrain/castle/elven-ruin/grounds5.png
A data/core/images/terrain/castle/elven-ruin/grounds6.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-ccw-bl.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-ccw-br.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-ccw-l.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-ccw-r.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-ccw-tl.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-ccw-tr.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-concave-tr.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-convex-bl.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-convex-br.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-convex-l.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-convex-r.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-convex-tl.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-convex-tr.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-cw-bl.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-cw-br.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-cw-l.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-cw-r.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-cw-tl.png
A data/core/images/terrain/castle/elven-ruin/keep-castle-cw-tr.png
A data/core/images/terrain/castle/elven-ruin/keep-castle2-convex-bl.png
A data/core/images/terrain/castle/elven-ruin/keep-castle2-convex-br.png
A data/core/images/terrain/castle/elven-ruin/keep-castle2-convex-l.png
A data/core/images/terrain/castle/elven-ruin/keep-concave-bl.png
A data/core/images/terrain/castle/elven-ruin/keep-concave-br.png
A data/core/images/terrain/castle/elven-ruin/keep-concave-l.png
A data/core/images/terrain/castle/elven-ruin/keep-concave-r.png
A data/core/images/terrain/castle/elven-ruin/keep-concave-tl.png
A data/core/images/terrain/castle/elven-ruin/keep-concave-tr.png
A data/core/images/terrain/castle/elven-ruin/keep-convex-bl.png
A data/core/images/terrain/castle/elven-ruin/keep-convex-br.png
A data/core/images/terrain/castle/elven-ruin/keep-convex-l.png
A data/core/images/terrain/castle/elven-ruin/keep-convex-r.png
A data/core/images/terrain/castle/elven-ruin/keep-convex-tl.png
A data/core/images/terrain/castle/elven-ruin/keep-convex-tr.png
A data/core/images/terrain/castle/elven-ruin/keep-tile.png
A data/core/images/terrain/castle/elven-ruin/keep.png
A data/core/images/terrain/castle/elven-ruin/keep2-concave-br.png
A data/core/images/terrain/castle/elven-ruin/keep2-concave-l.png
A data/core/images/terrain/castle/elven-ruin/keep2-concave-tl.png
A data/core/images/terrain/castle/elven-ruin/keep2-convex-br.png
A data/core/images/terrain/castle/elven-ruin/keep2-convex-tl.png
A data/core/images/terrain/castle/elven-ruin/keep2.png
A data/core/images/terrain/castle/elven-ruin/keep3.png
A data/core/images/terrain/castle/elven-ruin/keep4.png
A data/core/images/terrain/castle/elven-ruin/keep5.png
A data/core/images/terrain/castle/elven-ruin/tile.png
M data/core/terrain-graphics.cfg
M data/core/terrain.cfg
Log Message:
-----------
new terrain variation - Elf castle ruins (#2064)
* elvish castle ruins terrain
* fixed some file names
* some revisions and greater variation
* revisions
Commit: 66b55de48f9272647ff4eeca09c1b1e82039351d
https://github.com/wesnoth/wesnoth/commit/66b55de48f9272647ff4eeca09c1b1e82039351d
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M src/campaign_server/campaign_server.cpp
Log Message:
-----------
campaignd: Use base64-encoded hashes for add-on passphrases again
Fixes #2068.
As pointed out in the ticket, commit
98648ddf636bf4725d17334addac57850c478315 changed the implementation of
hex_digest() to use hexadecimal numbers instead of base64, causing new
calculated hashes during [upload] and other authenticated operations to
not match what campaignd already had on record.
This commit fixes that by using utils::md5::base64_digest() as
recommended by celticminstrel (which had already been done for wesnothd
but not campaignd, of course). It also matches the 1.12 version of the
campaignd hashing code this way.
Additionally, new uploads/passphrases since the deployment of that change
will need to be re-set by hand to get their base64 versions into the
server config.
Commit: 75f046a09e11ada7c1764882d571b125203522ae
https://github.com/wesnoth/wesnoth/commit/75f046a09e11ada7c1764882d571b125203522ae
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/move.cpp
M src/display.cpp
M src/game_events/pump.cpp
M src/gui/dialogs/multiplayer/mp_login.cpp
M src/gui/widgets/text_box_base.cpp
M src/gui/widgets/text_box_base.hpp
M src/gui/widgets/toggle_button.hpp
M src/help/help_text_area.cpp
M src/play_controller.cpp
M src/savegame.cpp
M src/serialization/string_view.hpp
M src/units/abilities.cpp
M src/units/animation.cpp
M src/units/animation.hpp
M src/units/filter.cpp
M src/units/filter.hpp
M src/units/unit.hpp
M src/wesnothd_connection.cpp
M src/wesnothd_connection.hpp
Log Message:
-----------
Removed trailing tabs and whitespaces from C++ source
[ci skip]
I ran the same command from 9b7b1751fdda.
Excludes:
* lua/
* spirit_po/
Commit: e59dec9ffaeccb383ffb1bb17ba3c72e21ae7f93
https://github.com/wesnoth/wesnoth/commit/e59dec9ffaeccb383ffb1bb17ba3c72e21ae7f93
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/spirit_po/catalog.hpp
M src/spirit_po/catalog_metadata.hpp
M src/spirit_po/default_plural_forms_compiler.hpp
M src/spirit_po/default_plural_forms_expressions.hpp
M src/spirit_po/exceptions.hpp
M src/spirit_po/version.hpp
Log Message:
-----------
Update Spirit Po sources from source repo
This incorporates changes from cbeck88/spirit-po as of 111402d716b48486b7952bfe58b49fddbdcd9969 and
covers a period of approximately 16 months since the addition of this code to the Wesnoth repo in
June 2016. This also bumps our included Spirit Po version from 1.0.1 to 1.1.2.
I've retained our own changes from:
* fd671b1132f1dac983a63d2b625ac5191f84d143
The following changes have been discarded in favor of changes made in the source repo:
* 69b070afb40277962e2245378e0362c96d75437e
* 65dacf6bc76a51527e72c7284faca77bac472f1c
* ae60ff80e666e0fffde36fca699dae150eef8ab3
* b4dc11ce36e282458e2891a36baddb6dab13186d
Commit: e03b4b933dc56351a9445377be86b6a534955897
https://github.com/wesnoth/wesnoth/commit/e03b4b933dc56351a9445377be86b6a534955897
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gettext_boost.cpp
R src/spirit_po.hpp
A src/spirit_po/spirit_po.hpp
Log Message:
-----------
Moved main Spirit Po header into the spirit_po subdir
This is consistent with the same change made in the source cbeck88/spirit-po repo.
Commit: 5b2160f3cbe7da1553848b7aa1e32a79f4ee533b
https://github.com/wesnoth/wesnoth/commit/5b2160f3cbe7da1553848b7aa1e32a79f4ee533b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
Updated changelog for 6f952a0daec4
[ci skip]
Commit: 4580f499516d67c61fa4518e0d2dabe18bf829e7
https://github.com/wesnoth/wesnoth/commit/4580f499516d67c61fa4518e0d2dabe18bf829e7
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/maps/08_A_Small_Favor2.map
M data/campaigns/Descent_Into_Darkness/maps/09_A_Small_Favor3.map
Log Message:
-----------
DiD S8-S9: use correct directional variants for doors
[ci skip]
When this terrain was first introduced, it had "smart" detection of which directional variant should
be used. Since that caused some issues, however, specific directional variants were introduced and it
seems I forgot to update these maps.
Commit: 57cab64d4ea5a49c27c0f27e685ac2c2001d6492
https://github.com/wesnoth/wesnoth/commit/57cab64d4ea5a49c27c0f27e685ac2c2001d6492
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Eastern_Invasion/maps/Throne_Room.map
Log Message:
-----------
EI S18: used Clean stone walls for Throne Room map
[ci skip]
Commit: a84e2fdc88e2ebc375e4f08a0c7ca6632c6f2754
https://github.com/wesnoth/wesnoth/commit/a84e2fdc88e2ebc375e4f08a0c7ca6632c6f2754
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
A data/core/images/terrain/village/desert-night.png
A data/core/images/terrain/village/desert2-night.png
A data/core/images/terrain/village/desert3-night.png
A data/core/images/terrain/village/desert4-night.png
A data/core/images/terrain/village/desert5-night.png
A data/core/images/terrain/village/desert6-night.png
A data/core/images/terrain/village/desert7-night.png
A data/core/images/terrain/village/elven-night.png
A data/core/images/terrain/village/elven2-night.png
A data/core/images/terrain/village/elven3-night.png
A data/core/images/terrain/village/elven4-night.png
A data/core/images/terrain/village/human-city-night.png
A data/core/images/terrain/village/human-city2-night.png
A data/core/images/terrain/village/human-city3-night.png
A data/core/images/terrain/village/human-city4-night.png
M data/core/images/terrain/village/human-cottage-ruin3.png
A data/core/images/terrain/village/human-night.png
A data/core/images/terrain/village/human2-night.png
A data/core/images/terrain/village/human3-night.png
M data/core/images/terrain/village/human3.png
A data/core/images/terrain/village/human4-night.png
A data/core/images/terrain/village/hut-night.png
M data/core/images/terrain/village/hut.png
A data/core/images/terrain/village/hut2-night.png
M data/core/images/terrain/village/hut2.png
A data/core/images/terrain/village/hut3-night.png
A data/core/images/terrain/village/hut3.png
A data/core/images/terrain/village/hut4-night.png
A data/core/images/terrain/village/hut4.png
A data/core/images/terrain/village/log-cabin-night.png
A data/core/images/terrain/village/log-cabin2-night.png
A data/core/images/terrain/village/log-cabin3-night.png
A data/core/images/terrain/village/log-cabin4-night.png
A data/core/images/terrain/village/orc-night.png
M data/core/images/terrain/village/orc.png
A data/core/images/terrain/village/orc2-night.png
A data/core/images/terrain/village/orc3-night.png
M data/core/images/terrain/village/orc3.png
A data/core/images/terrain/village/orc4-night.png
A data/core/images/terrain/village/orc5-night.png
A data/core/images/terrain/village/orc5.png
A data/core/images/terrain/village/swampwater-night.png
A data/core/images/terrain/village/swampwater2-night.png
A data/core/images/terrain/village/swampwater3-night.png
M data/core/terrain-graphics.cfg
M data/core/terrain-graphics/new-macros.cfg
Log Message:
-----------
some night-time village images (#2084)
* some night-time village images
* more variations, and revision to VILLAGE_TOD macro
* lights for swamp villages
Commit: a58491d21156952077684769a336bce69e16fe6d
https://github.com/wesnoth/wesnoth/commit/a58491d21156952077684769a336bce69e16fe6d
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Eastern_Invasion/maps/Throne_Room.map
Log Message:
-----------
EI S18: spiff up the Throne Room map
[ci skip]
Commit: d18893ff1601ac95b3d4f7dbb8753e7e829588ca
https://github.com/wesnoth/wesnoth/commit/d18893ff1601ac95b3d4f7dbb8753e7e829588ca
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M SConstruct
M src/SConscript
Log Message:
-----------
Remove support for old tools and builds
Commit: 2d7fb14c0ea8b17120dd65b28f8b1957d9a9ddb9
https://github.com/wesnoth/wesnoth/commit/2d7fb14c0ea8b17120dd65b28f8b1957d9a9ddb9
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
M src/SConscript
Log Message:
-----------
Re-added things based on replies, and added glibcxx_debug ability to cmake.
Commit: 504d124fcfd3efe34d0ea93251bd6f44c6d090d6
https://github.com/wesnoth/wesnoth/commit/504d124fcfd3efe34d0ea93251bd6f44c6d090d6
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M SConstruct
Log Message:
-----------
Re-add profile build description.
Commit: 286e0569c40e7016411c84883e7011b87099d224
https://github.com/wesnoth/wesnoth/commit/286e0569c40e7016411c84883e7011b87099d224
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
Log Message:
-----------
Address feedback.
Commit: 8088df37f893a7213ec555e54e4a64cd5d74b05f
https://github.com/wesnoth/wesnoth/commit/8088df37f893a7213ec555e54e4a64cd5d74b05f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/lua/lua_object.hpp
Log Message:
-----------
AI/Lua Object: cleaned up some shared_ptr assignment/construction
Commit: 78d1ba41d67f871a073d3161be1fb7f337481e98
https://github.com/wesnoth/wesnoth/commit/78d1ba41d67f871a073d3161be1fb7f337481e98
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/lua/engine_lua.cpp
Log Message:
-----------
AI/Lua Engine: further cleanup of shared_ptr creation/assignment
Commit: 4d580b4f36749b4136d69e91302c41cd4150e5d2
https://github.com/wesnoth/wesnoth/commit/4d580b4f36749b4136d69e91302c41cd4150e5d2
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/team.cpp
Log Message:
-----------
Team: reformatted list of allowed [side] keys
[ci skip]
Commit: ea7c3c578ee6a5de672a72b764434537b298f73f
https://github.com/wesnoth/wesnoth/commit/ea7c3c578ee6a5de672a72b764434537b298f73f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/team.cpp
Log Message:
-----------
Team: added faction_lock and leader_lock to list of allowed [side] keys
Dunno why these were excluded...
Commit: 0fe71ba16204fe611bb849322edf87a49f03a40e
https://github.com/wesnoth/wesnoth/commit/0fe71ba16204fe611bb849322edf87a49f03a40e
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/spirit_po/exceptions.hpp
Log Message:
-----------
Fixup 6f952a0daec4 (Update Spirit Po sources from source repo)
Commit: 98cc79dafbb6ec2276ae9305b9c9ef6b026b7061
https://github.com/wesnoth/wesnoth/commit/98cc79dafbb6ec2276ae9305b9c9ef6b026b7061
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/lua/COPYRIGHT
M src/lua/lauxlib.cpp
M src/lua/lauxlib.h
M src/lua/lbaselib.cpp
M src/lua/lcode.cpp
M src/lua/ldebug.cpp
M src/lua/ldo.cpp
M src/lua/lgc.cpp
M src/lua/liolib.cpp
M src/lua/lmathlib.cpp
M src/lua/loadlib.cpp
M src/lua/lobject.cpp
M src/lua/lobject.h
M src/lua/lopcodes.h
M src/lua/loslib.cpp
M src/lua/lparser.cpp
M src/lua/lstate.h
M src/lua/lstrlib.cpp
M src/lua/ltable.cpp
M src/lua/ltable.h
M src/lua/ltm.cpp
M src/lua/lua.h
M src/lua/luaconf.h
M src/lua/lualib.h
M src/lua/lutf8lib.cpp
M src/lua/lvm.h
Log Message:
-----------
Upgrade to Lua 5.3.4
Commit: 37eb623a8451247726ebd0fe7ea28a9f4f675d56
https://github.com/wesnoth/wesnoth/commit/37eb623a8451247726ebd0fe7ea28a9f4f675d56
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/lua/lparser.cpp
Log Message:
-----------
Apply Lua.org patch
Wrong code generated for a 'goto' followed by a label inside an 'if'.
reported by 云风 on 13 Apr 2017. existed since 5.2.
Example:
See https://www.lua.org/bugs.html#5.3.4-1.
Commit: f8e401feb091bb9dee4ddd6eeb1ec46768eee89f
https://github.com/wesnoth/wesnoth/commit/f8e401feb091bb9dee4ddd6eeb1ec46768eee89f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/lua/ldebug.cpp
Log Message:
-----------
Apply Lua.org patch
Lua does not check GC when creating error messages.
reported by Viacheslav Usov on 06 Jul 2017. existed since 5.3.2.
Example:
See https://www.lua.org/bugs.html#5.3.4-4.
Commit: d2c2b0299830e47b1b58e25e8f80e325f8bd6273
https://github.com/wesnoth/wesnoth/commit/d2c2b0299830e47b1b58e25e8f80e325f8bd6273
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/lua/lgc.cpp
Log Message:
-----------
Apply Lua.org patch
Dead keys with nil values can stay in weak tables.
reported by 云风 Cloud Wu on 15 Aug 2017. existed since 5.2.
Example:
See https://www.lua.org/bugs.html#5.3.4-5.
Commit: 30a299a88892cc8f24ab34c1a73aaa3548cd0cc7
https://github.com/wesnoth/wesnoth/commit/30a299a88892cc8f24ab34c1a73aaa3548cd0cc7
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/wesnoth_lua_config.md
Log Message:
-----------
Updated Lua update guide
* Fixed a few typos
* Updated the referenced version to 5.3.4.
* Updated build system-related instructions for 5b29805554178e66fcdc97693cfcb110cffc27ac.
Commit: 2ad714943adab1c5714014792ccf702b17c9832a
https://github.com/wesnoth/wesnoth/commit/2ad714943adab1c5714014792ccf702b17c9832a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
Updated changelog for Lua upgrade
Commit: 48d2c2803d9f45ef709cf91c1bad11d198b98fd1
https://github.com/wesnoth/wesnoth/commit/48d2c2803d9f45ef709cf91c1bad11d198b98fd1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/lua/luaconf.h
Log Message:
-----------
Force static value for LUAL_BUFFERSIZE
In Lua 5.3.3, LUAL_BUFFERSIZE always equaled the constant since LUA_FLOAT_LONGDOUBLE was always defined.
This check changed in 5.3.4 and the alternate path was being used for LUAL_BUFFERSIZE and triggering
old-style cast warnings in Scons + GCC. Hopefully this gets fixed for 5.3.5.
The following patch constitutes the changes (though they were applied by hand):
*** luaconf.h.old 2017-10-09 23:38:22.641645801 -0500
--- luaconf.h 2017-10-09 23:38:56.548577911 -0500
***************
*** 748,758 ****
** smaller buffer would force a memory allocation for each call to
** 'string.format'.)
*/
- #if LUA_FLOAT_TYPE == LUA_FLOAT_LONGDOUBLE
#define LUAL_BUFFERSIZE 8192
- #else
- #define LUAL_BUFFERSIZE ((int)(0x80 * sizeof(void*) * sizeof(lua_Integer)))
- #endif
/* }================================================================== */
--- 748,754 ----
Commit: 052e5e8e9227a67fb2cffda2738e9eea835726c8
https://github.com/wesnoth/wesnoth/commit/052e5e8e9227a67fb2cffda2738e9eea835726c8
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/mouse_events.cpp
Log Message:
-----------
Mouse Events: formatting cleanup
Commit: bc911711d69c0ba4e2c53d510d856642dd86667b
https://github.com/wesnoth/wesnoth/commit/bc911711d69c0ba4e2c53d510d856642dd86667b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_display.cpp
M src/game_display.hpp
M src/mouse_events.cpp
M src/mouse_events.hpp
Log Message:
-----------
Fixed context menu showing when deselecting unit with right click (fixes #1908)
Do note the mouse_handler::unselected_reach_ flag is only used for this one bugfix, and I haven't
tested whether it needs to be set any time game_display::unhighlight_reach is called.
Commit: b419315148bb5eaeacf840842e15853a6f150cb3
https://github.com/wesnoth/wesnoth/commit/b419315148bb5eaeacf840842e15853a6f150cb3
Author: Wedge009 <wedge009 at wedge009.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj.filters
M projectfiles/VC12/wesnothlib.vcxproj
M projectfiles/VC12/wesnothlib.vcxproj.filters
Log Message:
-----------
Updating VC project files for 010237fb and c4d55647.
[ci skip]
Commit: 5d33542709810af6d8a8e04ab8852e3b3abc961e
https://github.com/wesnoth/wesnoth/commit/5d33542709810af6d8a8e04ab8852e3b3abc961e
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/mouse_events.cpp
Log Message:
-----------
Fix: mouse_handler::unselected_reach_ was uninitialized
Commit: 65917a0de395f7b2acf266bba3a00b48b7c2c5e0
https://github.com/wesnoth/wesnoth/commit/65917a0de395f7b2acf266bba3a00b48b7c2c5e0
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
Log Message:
-----------
Do local checks before uploading to the addon server
Commit: f6b49efe59792b8e7dbc1580e5efe5f255b5f5c2
https://github.com/wesnoth/wesnoth/commit/f6b49efe59792b8e7dbc1580e5efe5f255b5f5c2
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/addon/manager.cpp
Log Message:
-----------
Enable Pango markup in the error message if uploading an add-on fails
Follow-up for cb5de97b8414b3a8bac50dedad3cf3133f431866.
Commit: d1b17de2f0856dd7d02ce293e4a511d3c25f090e
https://github.com/wesnoth/wesnoth/commit/d1b17de2f0856dd7d02ce293e4a511d3c25f090e
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/addon_manager/html.py
M data/tools/wesnoth_addon_manager
Log Message:
-----------
wam: Add --datadir option to set the path to the Wesnoth data dir
[ci skip]
This is needed to use the 1.13.x WAM with older versions without messing
up icons due to files that have been moved or deleted over time.
Commit: 1cd405100a24419ec7a5c5acd4f21152c21dd952
https://github.com/wesnoth/wesnoth/commit/1cd405100a24419ec7a5c5acd4f21152c21dd952
Author: Severin Glöckner <severin.gloeckner at stud.htwk-leipzig.de>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
R data/core/images/units/human-magi/white-mage+female-die-1.png
R data/core/images/units/human-magi/white-mage+female-die-2.png
R data/core/images/units/human-magi/white-mage+female-die-3.png
R data/core/images/units/human-magi/white-mage+female-die-4.png
R data/core/images/units/human-magi/white-mage-die-1.png
R data/core/images/units/human-magi/white-mage-die-2.png
R data/core/images/units/human-magi/white-mage-die-3.png
R data/core/images/units/human-magi/white-mage-die-4.png
Log Message:
-----------
remove leftover images from old white mage sprite
[ci skip]
Commit: e920d4a131374dba5c7bee27d8665b8a662d56e4
https://github.com/wesnoth/wesnoth/commit/e920d4a131374dba5c7bee27d8665b8a662d56e4
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
Update changelog
Commit: c15c428d2a4a3cfb036886d3c1fcb09fb323c0fc
https://github.com/wesnoth/wesnoth/commit/c15c428d2a4a3cfb036886d3c1fcb09fb323c0fc
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/ai/ais/idle_ai.cfg
M src/ai/configuration.cpp
Log Message:
-----------
Hide AIs with hidden=yes from list of available AI options (fixes #2095)
This is enough to hide them as AI options in the UI, but I don't know if other parts of the AI
engine need to know about this key.
Commit: 5d031d57e702c16b9425c312d25a995469cd68ed
https://github.com/wesnoth/wesnoth/commit/5d031d57e702c16b9425c312d25a995469cd68ed
Author: Severin Glöckner <severin.gloeckner at stud.htwk-leipzig.de>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
A data/core/images/units/human-magi/white-mage+female-die-1.png
A data/core/images/units/human-magi/white-mage+female-die-2.png
A data/core/images/units/human-magi/white-mage+female-die-3.png
A data/core/images/units/human-magi/white-mage+female-die-4.png
A data/core/images/units/human-magi/white-mage-die-1.png
A data/core/images/units/human-magi/white-mage-die-2.png
A data/core/images/units/human-magi/white-mage-die-3.png
A data/core/images/units/human-magi/white-mage-die-4.png
Log Message:
-----------
Revert "remove leftover images from old white mage sprite"
This may still be usefull for Era of Death.
This reverts commit 04117d95e2ab8145a7257867c742365df5ce42e1.
Commit: b6f9e9bc1d8b184e916fd8b3ca611177eacdf362
https://github.com/wesnoth/wesnoth/commit/b6f9e9bc1d8b184e916fd8b3ca611177eacdf362
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
R images/misc/lobby.png
Log Message:
-----------
Removed old GUI1 MP lobby background image
[ci skip]
Commit: 22bb91ef38e00776ea7704589d943b7ccac1f2d1
https://github.com/wesnoth/wesnoth/commit/22bb91ef38e00776ea7704589d943b7ccac1f2d1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/lua/lua_object.hpp
Log Message:
-----------
AI/Lua Object: deployed more std::make_shared
Commit: f2bc062ab5a9bfd275369c782716fe0367285bdc
https://github.com/wesnoth/wesnoth/commit/f2bc062ab5a9bfd275369c782716fe0367285bdc
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/configuration.cpp
Log Message:
-----------
Improve implementation of b2df837
Instead of removing hidden AIs from the list after adding, simply don't add them
to the list in the first place.
Commit: 932c733c209eb10bd3fc266d6182f7f0fb52c150
https://github.com/wesnoth/wesnoth/commit/932c733c209eb10bd3fc266d6182f7f0fb52c150
Author: Arcanister <you at example.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg
Log Message:
-----------
Make Jarek from TSG loyal for consistency.
Commit: e038023e7993339d8e08cf9fd60741b62ab9ccfe
https://github.com/wesnoth/wesnoth/commit/e038023e7993339d8e08cf9fd60741b62ab9ccfe
Author: Arcanister <31947120+Arcanister at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg
Log Message:
-----------
Remove trait strong from Jarek.
Commit: 787432be4890e4c9a346c064cdb127ecc285adb1
https://github.com/wesnoth/wesnoth/commit/787432be4890e4c9a346c064cdb127ecc285adb1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/configuration.cpp
Log Message:
-----------
Small fixup to a9488c429404
We don't want log messages printed if AI is skipped.
Commit: babcf802dae43668a015640c829f0d544fce9391
https://github.com/wesnoth/wesnoth/commit/babcf802dae43668a015640c829f0d544fce9391
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/configuration.cpp
Log Message:
-----------
Fixup 8ad4c65
Commit: 86ebdefa434a6aeb32c550f38b0a7218f805d909
https://github.com/wesnoth/wesnoth/commit/86ebdefa434a6aeb32c550f38b0a7218f805d909
Author: loonycyborg <loonycyborg at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M SConstruct
M po/SConscript
M scons/ieee_754.py
Log Message:
-----------
Made build with scons 3.0.0 work fixing issue #2093
Commit: 12c0442ff0e73220460b4e3086e8de18373c594d
https://github.com/wesnoth/wesnoth/commit/12c0442ff0e73220460b4e3086e8de18373c594d
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/02_This_Valley_Belongs_to_Me.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/03_The_Road_to_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/04_Leollyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/05_Council_in_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/06_Swamps_of_Illuven.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/07_Night_in_the_Swamp.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/10_The_Gate_Between_Worlds.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/11_Wasteland.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/13_The_Return_of_Trouble.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/14_Shadows.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/15_Save_the_King.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/17_A_New_Ally.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/21_Clash_at_the_Manor.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/22_Face_of_the_Enemy.cfg
M data/campaigns/Delfadors_Memoirs/utils/sides.cfg
Log Message:
-----------
DM: Set facings for scenario start and dialog
Commit: 8d76fffe099674af7aeece3c9ab1ebddce202379
https://github.com/wesnoth/wesnoth/commit/8d76fffe099674af7aeece3c9ab1ebddce202379
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/utils/sides.cfg
Log Message:
-----------
DM: Fix typos
Commit: 3c722a4c1ff4cb4b337eea443b6b6a00dd01a8b5
https://github.com/wesnoth/wesnoth/commit/3c722a4c1ff4cb4b337eea443b6b6a00dd01a8b5
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/05_Council_in_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/16_Dark_Sky_Over_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/23_Epilogue.cfg
Log Message:
-----------
DM: Remove turn limit for dialog & story only scenarios
Commit: 63059c1e9edee4dfb7956d06b9b0c15d18438184
https://github.com/wesnoth/wesnoth/commit/63059c1e9edee4dfb7956d06b9b0c15d18438184
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
R data/campaigns/Delfadors_Memoirs/images/items/ward-circle.png
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM: Remove image that is now in mainline
Commit: 816b3e0150c592bb9977755a37c2df56fb9ef435
https://github.com/wesnoth/wesnoth/commit/816b3e0150c592bb9977755a37c2df56fb9ef435
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/units/Wose_Shaman.cfg
Log Message:
-----------
DM: Add {AMLA_DEFAULT} to Wose Shaman
Commit: b520d45bdfdf0cfae77f93bf11ff4116ff6b648b
https://github.com/wesnoth/wesnoth/commit/b520d45bdfdf0cfae77f93bf11ff4116ff6b648b
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/01_Overture.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/02_This_Valley_Belongs_to_Me.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/03_The_Road_to_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/04_Leollyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/05_Council_in_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/06_Swamps_of_Illuven.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/07_Night_in_the_Swamp.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/10_The_Gate_Between_Worlds.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/11_Wasteland.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/13_The_Return_of_Trouble.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/14_Shadows.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/15_Save_the_King.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/16_Dark_Sky_Over_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/17_A_New_Ally.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/21_Clash_at_the_Manor.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/22_Face_of_the_Enemy.cfg
M data/campaigns/Delfadors_Memoirs/utils/characters.cfg
Log Message:
-----------
DM: Move side and unit keys to proper places
Moved from {YOUNG_DELFADOR} to [side] and vice versa.
For coherency and preparation for other changes.
Also remove some unnecessary keys.
Commit: e0b04dbe9e8c280e32b65ca18bedf94cfdc1baad
https://github.com/wesnoth/wesnoth/commit/e0b04dbe9e8c280e32b65ca18bedf94cfdc1baad
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/21_Clash_at_the_Manor.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/22_Face_of_the_Enemy.cfg
M data/campaigns/Delfadors_Memoirs/units/Journeyman_Mage.cfg
M data/campaigns/Delfadors_Memoirs/units/Mage_Magister.cfg
M data/campaigns/Delfadors_Memoirs/utils/characters.cfg
M data/campaigns/Delfadors_Memoirs/utils/sides.cfg
Log Message:
-----------
DM: Fix Delfador portrait and character progression
Previously young_delfador.png ended up unused in play. From cleanup in
previous commit, it looks like the portrait change was intended for when
Delfador reached level 3, so that has been set now.
Previously, old_delfador.png was unused, as Delfador never became
an elder mage. Is now used for S20 on, where Delfador is now an elder mage.
Commit: 7b44f0a2170121fa92dda20787135fd541ce8729
https://github.com/wesnoth/wesnoth/commit/7b44f0a2170121fa92dda20787135fd541ce8729
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/maps/01_Overture.map
M data/campaigns/Delfadors_Memoirs/scenarios/01_Overture.cfg
Log Message:
-----------
DM S01: Improve feel of opening sequence
Add lit brazier embellishments to the map.
Have Methor lead Delfador from The New Mage Ceremony.
Commit: 819d13e69e4b9de076957ce943b5e3ab6e973b37
https://github.com/wesnoth/wesnoth/commit/819d13e69e4b9de076957ce943b5e3ab6e973b37
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/01_Overture.cfg
Log Message:
-----------
DM S01: Improve dialog based on forum feedback
https://forums.wesnoth.org/viewtopic.php?f=52&t=25556
Commit: 7f98deda5f23d55c8e93a089e9acb242fcf7b38e
https://github.com/wesnoth/wesnoth/commit/7f98deda5f23d55c8e93a089e9acb242fcf7b38e
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/03_The_Road_to_Weldyn.cfg
Log Message:
-----------
DM S03: Specify enemy leader to be defeated
It is done everywhere else in the campaign.
Commit: c725372d999b1ea393911670a7e571d8d59a9a41
https://github.com/wesnoth/wesnoth/commit/c725372d999b1ea393911670a7e571d8d59a9a41
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/maps/04_Leollyn.map
Log Message:
-----------
DM S04: Replace elven villages with human ones
Because we are in Wesnoth in this scenario.
Commit: 9f485d78873829085324a906a9a380b1fa7a70bc
https://github.com/wesnoth/wesnoth/commit/9f485d78873829085324a906a9a380b1fa7a70bc
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/05_Council_in_Weldyn.cfg
Log Message:
-----------
DM S05: Remove unneeded guardian ai_special
Commit: 2fdbfbddad79351098117c8303d8c429d2d97e26
https://github.com/wesnoth/wesnoth/commit/2fdbfbddad79351098117c8303d8c429d2d97e26
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/07_Night_in_the_Swamp.cfg
Log Message:
-----------
DM S07: Specify alternative objective and adjust difficulty
Also fixes dialog refering to 'stones' by ensuring all difficulies have at
least two stones. The addtional stone on easy is added where it can be
easily destroyed right away. A third stone is added on hard.
Commit: edc915372d2c7903da01ceaa207405039197db55
https://github.com/wesnoth/wesnoth/commit/edc915372d2c7903da01ceaa207405039197db55
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
M data/campaigns/Delfadors_Memoirs/utils/misc.cfg
Log Message:
-----------
DM S08: Fix issue with objectives and improve closing scene
If Ur-Thorodor moves off of keep and Delfador is next to him, scenario
doesn't end, which looks odd. So prevent Ur-Thorodor from moving.
Make end scene look better by moving Delfador to the keep for meditating.
Commit: 190a01b4a40562e8447aae27a20ee5d21cdf07c6
https://github.com/wesnoth/wesnoth/commit/190a01b4a40562e8447aae27a20ee5d21cdf07c6
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/10_The_Gate_Between_Worlds.cfg
Log Message:
-----------
DM S10: Fix Iliah-Malal not attacking or moving
It looks like this was done in the days when [move_unit_fake] was the
only option, and thus needed to keep the unit in a certain spot for the
animation to work right. With [move_unit], it is no longer needed.
Commit: e09130b963cb31a5d9f37199b76ec66081467b04
https://github.com/wesnoth/wesnoth/commit/e09130b963cb31a5d9f37199b76ec66081467b04
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/10_The_Gate_Between_Worlds.cfg
Log Message:
-----------
DM S10: Add unit animation to portal opening
Commit: fdab5f02290e1c58e7e95238c8ed9a84ed07136f
https://github.com/wesnoth/wesnoth/commit/fdab5f02290e1c58e7e95238c8ed9a84ed07136f
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
Log Message:
-----------
DM S12: Ensure fort Commander is visible during dialog
Commit: 0d3f8fde04f06988f2498cb9e76a0df1b3ff6db3
https://github.com/wesnoth/wesnoth/commit/0d3f8fde04f06988f2498cb9e76a0df1b3ff6db3
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
Log Message:
-----------
DM S12: Give units traits for consistency
As these were the only ones left that end up on the players recall list
without traits.
Commit: b6f0e51527f3d32161b83e3e2b78cf56bc240885
https://github.com/wesnoth/wesnoth/commit/b6f0e51527f3d32161b83e3e2b78cf56bc240885
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
Log Message:
-----------
DM S12: Swap burned village moveto exploration effects
It makes more sense for the check for survivors dialog to be in the
first village the player is likely to explore.
Commit: 6d9852f1a17ac458639348a3707ed84f6f374918
https://github.com/wesnoth/wesnoth/commit/6d9852f1a17ac458639348a3707ed84f6f374918
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/14_Shadows.cfg
Log Message:
-----------
DM S14: Lift fog on speaking enemy units
Commit: 18637c2ca1ff26023898ab9e12479308d9045644
https://github.com/wesnoth/wesnoth/commit/18637c2ca1ff26023898ab9e12479308d9045644
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/15_Save_the_King.cfg
Log Message:
-----------
DM S15: Use the portrait for Zorlan
Commit: 88b38c56f275d730dfc1a31bdc97c8cc68f0ceb2
https://github.com/wesnoth/wesnoth/commit/88b38c56f275d730dfc1a31bdc97c8cc68f0ceb2
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/17_A_New_Ally.cfg
Log Message:
-----------
DM S17: Remove duplicate key already in {ULREK} macro
Commit: 6459c49026b399cc69b8929280757961efb747e7
https://github.com/wesnoth/wesnoth/commit/6459c49026b399cc69b8929280757961efb747e7
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/17_A_New_Ally.cfg
Log Message:
-----------
DM S17: Fix and simplify filter
Commit: 52fdcf235c24f19736ef72ee93661634245b3d1c
https://github.com/wesnoth/wesnoth/commit/52fdcf235c24f19736ef72ee93661634245b3d1c
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM S18: Fix mine image disappearing during use of go here image
Commit: 71ebcd96d4e61942566d019bb48d2c8c046e77f0
https://github.com/wesnoth/wesnoth/commit/71ebcd96d4e61942566d019bb48d2c8c046e77f0
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM S18: Fix units getting on recall list without being healed
Commit: c900920d94bd2837207a07f0e82fceed6c7a0aeb
https://github.com/wesnoth/wesnoth/commit/c900920d94bd2837207a07f0e82fceed6c7a0aeb
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
Log Message:
-----------
DM S19: Reorder objective for emphasis
Commit: 8e46fc68e78ea79bbf4d5f4cfc55a83d27f266ea
https://github.com/wesnoth/wesnoth/commit/8e46fc68e78ea79bbf4d5f4cfc55a83d27f266ea
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
Log Message:
-----------
DM S19: Eliminate gold carryover as next scenario is 26 years later
No real change to difficulty as it was only practical to get above
minimum gold on easy.
Commit: 0aab964e9fd6bff131d5ef6260024b00802ebd69
https://github.com/wesnoth/wesnoth/commit/0aab964e9fd6bff131d5ef6260024b00802ebd69
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/utils/sides.cfg
Log Message:
-----------
DM: If player has elves in S19, store them at victory
Commit: 771e2e9b0de2ad836eefe00a8137b0897b39aa6a
https://github.com/wesnoth/wesnoth/commit/771e2e9b0de2ad836eefe00a8137b0897b39aa6a
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg
Log Message:
-----------
DM S20: Make the generals visible during the opening sequence
So the prince can be seen.
Commit: 7aa5260730e0ff59d325b8b6d5ab851e167d38a7
https://github.com/wesnoth/wesnoth/commit/7aa5260730e0ff59d325b8b6d5ab851e167d38a7
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg
M data/campaigns/Delfadors_Memoirs/utils/sides.cfg
Log Message:
-----------
DM S20: Improve Delfador's arrival
He now comes from the edge of the map, and there's no longer a brief
moment where he is not visible after appearing.
Commit: da996c60d5baae80918861cb5c99b3d2c7d66ee0
https://github.com/wesnoth/wesnoth/commit/da996c60d5baae80918861cb5c99b3d2c7d66ee0
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/10_The_Gate_Between_Worlds.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/14_Shadows.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
M data/campaigns/Delfadors_Memoirs/utils/sides.cfg
Log Message:
-----------
DM: Use unit macros
Commit: 1191e4e65ea5e52e6993bac9a3d230ee80cea777
https://github.com/wesnoth/wesnoth/commit/1191e4e65ea5e52e6993bac9a3d230ee80cea777
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/01_Overture.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/05_Council_in_Weldyn.cfg
Log Message:
-----------
DM: Use Cutscene_Minimal where appropriate
Commit: 76c83ac3d8a5334a06b7150695e17385d66995bc
https://github.com/wesnoth/wesnoth/commit/76c83ac3d8a5334a06b7150695e17385d66995bc
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg
M data/campaigns/Delfadors_Memoirs/utils/items.cfg
Log Message:
-----------
DM S09: Fix incomplete/missing objectives issues
Add dialog and fixe objectives to ensure that player will hear about
the magical artifact (staff) instead of relying on finding a specifc ghost
in a village. This prevents situations where the player can reach the
signpost without having heard of the staff.
Commit: 5eb7ff59b75b31f0ad6e9cff820a2b29b172ab66
https://github.com/wesnoth/wesnoth/commit/5eb7ff59b75b31f0ad6e9cff820a2b29b172ab66
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg
Log Message:
-----------
DM S09: Add intended name for enemy leader
Commit: 6642546d6e467629260f3b66d952c9c4b1fe0389
https://github.com/wesnoth/wesnoth/commit/6642546d6e467629260f3b66d952c9c4b1fe0389
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/utils/misc.cfg
Log Message:
-----------
DM S09: Make secret passage bi-directional and open to all
Only after the player goes through it first.
Commit: 96318bafe24cfb319b07df2d5765162125bfa166
https://github.com/wesnoth/wesnoth/commit/96318bafe24cfb319b07df2d5765162125bfa166
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/maps/09_Houses_of_the_Dead.map
M data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg
Log Message:
-----------
DM S09: Fix issues by rebalancing scenario
Give player control of the ghosts and ghouls as they are found.
Update dialog to match ghosts and ghouls joining Delfador.
Enable gold carryover so player doesn't pointlessly wait till last turn.
Lower turn limit, as board is easier with additional units on player side.
Set start gold to 0, so final carryover is lower. With gold and turn limit
changes, it lessens amount in next scenario, but 300 is still achievable,
which is plenty.
Add cave wall to map around tomb. Otherwise a ghost going through the
secret passage causes an akward triggering of the village warning dialog.
Also makes it harder to get to the staff without using the secret passage.
Commit: 354ae4427123300fe675fd4b2b3ac16680b851ce
https://github.com/wesnoth/wesnoth/commit/354ae4427123300fe675fd4b2b3ac16680b851ce
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM S18: Use a more active voice
Commit: c12414bcea306d67b25e5bd43932b24daf38282d
https://github.com/wesnoth/wesnoth/commit/c12414bcea306d67b25e5bd43932b24daf38282d
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM S18: Clarify initial objectives
Commit: 4796cdae24a6ca2f97b5be9581962eea714f4b44
https://github.com/wesnoth/wesnoth/commit/4796cdae24a6ca2f97b5be9581962eea714f4b44
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/maps/18_The_Portal_of_Doom.map
Log Message:
-----------
DM S18: Improve look of map for story purposes
Make Iliah-Malal's castle area look like the one in S11, except ruined.
So they are both elven castles. Slight map tweaks in the area as well.
Use human castles for portal guard so closing portal effects look more natural.
Previously it was going from dwarven castle to ruined human castle.
Commit: 8219ddf190c142d6da33c0b1e7e6026fa420876f
https://github.com/wesnoth/wesnoth/commit/8219ddf190c142d6da33c0b1e7e6026fa420876f
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/10_The_Gate_Between_Worlds.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
M data/campaigns/Delfadors_Memoirs/utils/characters.cfg
Log Message:
-----------
DM S18: Changes to improve story, feel, difficulty & gameplay
Add character macro for Iliah-Malal.
Make Iliah-Malal an Ancient Lich.
Add Iliah-Malal 'heal when killed' motif from S19.
Improve dialog to better convey reason for running away.
Make portal guardian stronger.
Commit: ae5bb51eb94eb45334c766776b5667ac21ed7cd9
https://github.com/wesnoth/wesnoth/commit/ae5bb51eb94eb45334c766776b5667ac21ed7cd9
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM S18: Give Iliah-Malal his own side when he arrives
Commit: f9028bdbeb5398f21c6de9cda88e79ab527c8436
https://github.com/wesnoth/wesnoth/commit/f9028bdbeb5398f21c6de9cda88e79ab527c8436
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM S18: Adjust unit positioning for appearance
Commit: a4ed23cae31663431f40c8f8d8d0577c8c960992
https://github.com/wesnoth/wesnoth/commit/a4ed23cae31663431f40c8f8d8d0577c8c960992
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
Log Message:
-----------
DM S18: Improve portal closing sequence
Remove unneeded facing.
Give player time to see it.
Commit: 7b10d41fc939127f86da36736ab786e380b25d95
https://github.com/wesnoth/wesnoth/commit/7b10d41fc939127f86da36736ab786e380b25d95
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/18_The_Portal_of_Doom.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
M data/campaigns/Delfadors_Memoirs/utils/characters.cfg
M data/campaigns/Delfadors_Memoirs/utils/deaths.cfg
M data/campaigns/Delfadors_Memoirs/utils/sides.cfg
Log Message:
-----------
DM: Make Ulrek a hero with traits during his appearance
This accomplishes several things:
1. Harmony with HttT plot point with Relgorn.
2. A free Ulrek in S19 allows another recall, helping with a stronger I-M.
3. Slightly strengthens him in S18, to deal with I-M now having a side.
4. Dialog in S19 helps characterization of Delfador.
Commit: 0b752d045be8e6c4bc71f58b4b9b85282527019d
https://github.com/wesnoth/wesnoth/commit/0b752d045be8e6c4bc71f58b4b9b85282527019d
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/utils/deaths.cfg
Log Message:
-----------
DM: Remove unused die event
Commit: f83ad606b79ffea4ae925a3679e6057e9e5beb52
https://github.com/wesnoth/wesnoth/commit/f83ad606b79ffea4ae925a3679e6057e9e5beb52
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/17_A_New_Ally.cfg
M data/campaigns/Delfadors_Memoirs/utils/characters.cfg
Log Message:
-----------
DM: Make important plot/dialog characters unrenamable
Commit: 6411bfd83b58a242e15675ab6e69832dcfc8ccf3
https://github.com/wesnoth/wesnoth/commit/6411bfd83b58a242e15675ab6e69832dcfc8ccf3
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/16_Dark_Sky_Over_Weldyn.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/23_Epilogue.cfg
Log Message:
-----------
DM: Fix music not playing in story only scenarios
Commit: be027b691711bf4e2211ec94a2fa82fcd3c5d6a8
https://github.com/wesnoth/wesnoth/commit/be027b691711bf4e2211ec94a2fa82fcd3c5d6a8
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/06_Swamps_of_Illuven.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/14_Shadows.cfg
M data/campaigns/Delfadors_Memoirs/scenarios/16_Dark_Sky_Over_Weldyn.cfg
Log Message:
-----------
DM: Remove unneeded/no longer needed TODO's
Commit: 37f747a5a8185af625d444ec633bdb55c1afa780
https://github.com/wesnoth/wesnoth/commit/37f747a5a8185af625d444ec633bdb55c1afa780
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
R data/campaigns/Delfadors_Memoirs/TODO
R data/campaigns/Delfadors_Memoirs/WALKTHROUGH
Log Message:
-----------
DM: Remove outdated files
Commit: 1a3807b1fb73feb34e42322b89b7152e67461652
https://github.com/wesnoth/wesnoth/commit/1a3807b1fb73feb34e42322b89b7152e67461652
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/13_The_Return_of_Trouble.cfg
Log Message:
-----------
DM S13: Lessen 4th wall break and remove spoiler
Commit: 2f7ff20f233f6a03d293c5c5354c82f49c2d750e
https://github.com/wesnoth/wesnoth/commit/2f7ff20f233f6a03d293c5c5354c82f49c2d750e
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/23_Epilogue.cfg
Log Message:
-----------
DM S23: Lessen 4th wall break and eliminate repetitiveness
Commit: f215fba798d2d37c832261f99c258713aed0a134
https://github.com/wesnoth/wesnoth/commit/f215fba798d2d37c832261f99c258713aed0a134
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/_main.cfg
Log Message:
-----------
DM: Add myself as the current maintainer
Commit: 74c8b1b8f32b457854b4e9f522df54ddbec0c833
https://github.com/wesnoth/wesnoth/commit/74c8b1b8f32b457854b4e9f522df54ddbec0c833
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
Log Message:
-----------
Update changelogs
Commit: 756dcfa4e0d23bde6dde4e6457d5181039b7c3dc
https://github.com/wesnoth/wesnoth/commit/756dcfa4e0d23bde6dde4e6457d5181039b7c3dc
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M Doxyfile
M changelog
M players_changelog
M src/wesconfig.h
Log Message:
-----------
Post-release version bump
Commit: 5c099e081cf829d9d4054275a1d5e0930c2bade5
https://github.com/wesnoth/wesnoth/commit/5c099e081cf829d9d4054275a1d5e0930c2bade5
Author: galegosimpatico <galegosimpatico at outlook.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/menu_events.cpp
M src/mouse_events.cpp
M src/mouse_events.hpp
Log Message:
-----------
Usability improvement, mouse interaction.
When the game is cluttered with units from any side, the probability
of 'landing' the mouse cursor on top of a unit after activating the
'show [best possible] enemy moves' facility (via mouse) increases
drastically. In that scenario, the slightest mouse move rewinded back
enemy units movements highlight.
After this rev, if the cursor lands on a unit, an object field gets
toggled and it prevents normal single unit movements highlight until
mouse stops hovering units. Then it gets switched back to normal
interaction.
Final form of changes largely credited to review from @CelticMinstrel,
@jyrkive and @Vultraz. Abstraction `mouse_handler::hex_hosts_unit`
devised by @CelticMinstrel. Abstraction `mouse_handler::hovered_hex`
devised by @jyrkive.
src/menu_events.cpp: Disable unit movements highlighting when mouse
landing on unit after activating 'show [best possible] enemy moves'
via mouse.
src/mouse_events.cpp: On mouse_handler construction, normal units
highlighting is allowed. If the mouse is hovering a unit, do not show
unit paths if the toggle for preventing it is active. If the mouse is
not on a unit, disable the toggle.
src/mouse_events.hpp: Add object field that will be responsible to
control prevention of unit paths highlighting when that gets judged
as improper. Add new public function for querying if a given hex is
occupied by a unit. Add new public function for returning the hex the
mouse is hovering, if any.
Commit: 1c6eecde2b1241eee0dc7a8a5cfde5b8c355eeaf
https://github.com/wesnoth/wesnoth/commit/1c6eecde2b1241eee0dc7a8a5cfde5b8c355eeaf
Author: galegosimpatico <galegosimpatico at outlook.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/mouse_events.cpp
Log Message:
-----------
Adjust block indent.
Commit: a5afe303f7442a571f33028a122e41eb6d939674
https://github.com/wesnoth/wesnoth/commit/a5afe303f7442a571f33028a122e41eb6d939674
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M src/filesystem.hpp
M src/filesystem_boost.cpp
M src/wesnoth.cpp
Log Message:
-----------
Case sensitive file paths on Windows
The intent is to avoid UMC authors accidentally mistyping a file name
and making an addon that doesn't work correctly on GNU/Linux.
Thanks to @Arcanister for suggesting the GetFinalPathNameByHandle function.
Commit: 331069585a16c1fffb861a596a86acd7962e120d
https://github.com/wesnoth/wesnoth/commit/331069585a16c1fffb861a596a86acd7962e120d
Author: Severin Glöckner <severin.gloeckner at stud.htwk-leipzig.de>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_Hammer_of_Thursagan/units/Dwarvish_Annalist.cfg
M data/campaigns/The_Hammer_of_Thursagan/units/Dwarvish_Loremaster.cfg
M data/campaigns/The_Hammer_of_Thursagan/units/Dwarvish_Witness.cfg
Log Message:
-----------
ThoT: Annalists use flails, not morning stars
[ci skip]
Commit: 36e1354532f5920ce133ce98210416b991a8a14f
https://github.com/wesnoth/wesnoth/commit/36e1354532f5920ce133ce98210416b991a8a14f
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/macros/utils.cfg
Log Message:
-----------
Macros: Fix typo
Commit: dae02ae7599b669bbd0adf6e42c08ef553250db7
https://github.com/wesnoth/wesnoth/commit/dae02ae7599b669bbd0adf6e42c08ef553250db7
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Secrets_of_the_Ancients/scenarios/07_Meeting_of_the_Minds.cfg
M data/campaigns/Secrets_of_the_Ancients/scenarios/13_Together_Again.cfg
M data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg
Log Message:
-----------
SotA: Use Cutscene_Minimal theme for dialog only scenarios
Commit: 31da062cf576853ce483578ec344ed8de00c2a36
https://github.com/wesnoth/wesnoth/commit/31da062cf576853ce483578ec344ed8de00c2a36
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Two_Brothers/scenarios/02_The_Chase.cfg
Log Message:
-----------
AToTB S02: Keep unit alive to fit dialog and prevent scream at scene end
Commit: 5d599a554a1c668371fb616570f56a5cbaff816b
https://github.com/wesnoth/wesnoth/commit/5d599a554a1c668371fb616570f56a5cbaff816b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/info.cpp
Log Message:
-----------
Addon/Info: removed now-unnecessary icon fallbacks
GUI2 no longer needs this. An empty icon is simply not drawn, and the addon list widget forces
72x72 size for all icons so it's not even needed to size the image column. The image-not-found
image is also handled elsewhere (the general image loading code) and isn't needed here.
Commit: 6d88655adccbe9bc0c97bceeaac078ba80c33e68
https://github.com/wesnoth/wesnoth/commit/6d88655adccbe9bc0c97bceeaac078ba80c33e68
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/filesystem_boost.cpp
Log Message:
-----------
Fixup 37225d2 (unused parameter when not building on Windows)
Commit: e38ffb62632151e9e427632c4604af988149f825
https://github.com/wesnoth/wesnoth/commit/e38ffb62632151e9e427632c4604af988149f825
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/window/game_stats.cfg
Log Message:
-----------
Game Stats: made image columns share width
[ci skip]
This fixes (among other things) misaligned team name labels if a leader has died.
Commit: f923c15d2f3326a86569f0eec8ba5bb6740ba7df
https://github.com/wesnoth/wesnoth/commit/f923c15d2f3326a86569f0eec8ba5bb6740ba7df
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/game_stats.cpp
Log Message:
-----------
Game Stats: tweaked controller text display
Commit: 3cce6d8db1fa5aa5547244d8f12fd75034e4721b
https://github.com/wesnoth/wesnoth/commit/3cce6d8db1fa5aa5547244d8f12fd75034e4721b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_info.cpp
Log Message:
-----------
Use case-insensitive sorting for MP Lobby player lists
Commit: c764b8edf62b10d56bee73e4c41e951fcaa239b4
https://github.com/wesnoth/wesnoth/commit/c764b8edf62b10d56bee73e4c41e951fcaa239b4
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_info.cpp
Log Message:
-----------
Fix error: control may reach end of non-void lambda
If by_name and by_relation are both omitted, behave as if both were given: sort first by relation then by name.
Commit: 6a5392b5c7aa2a796f3d5b180baea9bcab280ece
https://github.com/wesnoth/wesnoth/commit/6a5392b5c7aa2a796f3d5b180baea9bcab280ece
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/game_stats.cpp
Log Message:
-----------
Fix error: suggest braces around initialization of subobject
Commit: 45f03ddc126ce8f46d4cb2b1632fa782bf02c51d
https://github.com/wesnoth/wesnoth/commit/45f03ddc126ce8f46d4cb2b1632fa782bf02c51d
Author: jostephd <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/terrain.cfg
Log Message:
-----------
terrain.cfg: Fix grammar in Rockbound Cave (#2082)
Commit: c539f06b62dd60e56708cb2fd81a5b06cb90f40f
https://github.com/wesnoth/wesnoth/commit/c539f06b62dd60e56708cb2fd81a5b06cb90f40f
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/wmlindent
Log Message:
-----------
Make 'bailout' a valid Python3 exception
Commit: 38337d696f724179cf60ad400da8d8dc9386aa8b
https://github.com/wesnoth/wesnoth/commit/38337d696f724179cf60ad400da8d8dc9386aa8b
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/terrain-graphics.cfg
Log Message:
-----------
Fixing chasm bug introduced in PR #2084
commit 0cce7c8106cd6ee587fed67d474bc7c29c62f913
Commit: 5b39737ac7f22b17189c68ea3cea7b71acb57087
https://github.com/wesnoth/wesnoth/commit/5b39737ac7f22b17189c68ea3cea7b71acb57087
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M RELEASE_NOTES
M changelog
M src/filesystem_boost.cpp
Log Message:
-----------
Disallow specifying file paths with backslashes
Backslashes only work on Windows. A UMC author may accidentally use them in
their add-on that won't then work properly on GNU/Linux and macOS.
Just disallow them on all platforms to avoid problems.
Commit: 08fed948b39bb6d2c1c03859a8fa60a5f07c8d56
https://github.com/wesnoth/wesnoth/commit/08fed948b39bb6d2c1c03859a8fa60a5f07c8d56
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/wesnoth/wmltools3.py
Log Message:
-----------
Teach wmlscope to ignore frame durations. Fixes #2045
Commit: 343474f76a079319c3fd02118a20ae12a51c53e3
https://github.com/wesnoth/wesnoth/commit/343474f76a079319c3fd02118a20ae12a51c53e3
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/wesnoth/wmltools3.py
Log Message:
-----------
Make character-presence checks more pythonic
Commit: c417047017f5feb20cd2f95de556a5d69d6b3fd5
https://github.com/wesnoth/wesnoth/commit/c417047017f5feb20cd2f95de556a5d69d6b3fd5
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/wesnoth/wmltools3.py
Log Message:
-----------
Require period before extension, make previous chargroup non-greedy
This reduced the number of false positives by filtering out things like Grogg, editor-map, png and water/wav
Commit: afb0bdff4a989edfebb308a9f3fac0112bf008f4
https://github.com/wesnoth/wesnoth/commit/afb0bdff4a989edfebb308a9f3fac0112bf008f4
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/hotkey/hotkey_command.cpp
Log Message:
-----------
Hotkey Command: formatting cleanup
Commit: 910ea9ccd09b34bd54982e8a2c0372989d419a98
https://github.com/wesnoth/wesnoth/commit/910ea9ccd09b34bd54982e8a2c0372989d419a98
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
A data/core/images/terrain/walls/stone/flames/flames-tile.png
A data/core/images/terrain/walls/stone/flames/sconce/base-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/base-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/base-convex-bl.png
A data/core/images/terrain/walls/stone/flames/sconce/flames.png
A data/core/images/terrain/walls/stone/flames/sconce/glow1-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/glow1-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/glow1-convex-bl.png
A data/core/images/terrain/walls/stone/flames/sconce/glow2-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/glow2-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/glow2-convex-bl.png
A data/core/images/terrain/walls/stone/flames/sconce/glow3-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/glow3-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/glow3-convex-bl.png
A data/core/images/terrain/walls/stone/flames/sconce/mask-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/mask-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/mask-convex-bl.png
A data/core/images/terrain/walls/stone/flames/sconce/mask2-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/mask2-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/mask2-convex-bl.png
A data/core/images/terrain/walls/stone/flames/sconce/mask3-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/mask3-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/mask3-convex-bl.png
A data/core/images/terrain/walls/stone/flames/sconce/wall-post-concave-tl.png
A data/core/images/terrain/walls/stone/flames/sconce/wall-post-concave-tr.png
A data/core/images/terrain/walls/stone/flames/sconce/wall-post-convex-bl.png
A data/core/images/terrain/walls/stone/flames/torch/base.png
A data/core/images/terrain/walls/stone/flames/torch/flames.png
A data/core/images/terrain/walls/stone/flames/torch/glow1.png
A data/core/images/terrain/walls/stone/flames/torch/glow2.png
A data/core/images/terrain/walls/stone/flames/torch/glow3.png
A data/core/images/terrain/walls/stone/flames/torch/mask.png
A data/core/images/terrain/walls/stone/flames/torch/mask2.png
A data/core/images/terrain/walls/stone/flames/torch/mask3.png
A data/core/images/terrain/walls/stone/flames/torch/post-chasm.png
A data/core/images/terrain/walls/stone/flames/torch/post-water.png
A data/core/images/terrain/walls/stone/flames/torch/post.png
M data/core/terrain-graphics.cfg
M data/core/terrain-graphics/new-macros.cfg
M data/core/terrain.cfg
Log Message:
-----------
New Sconce/Torches overlay terrain by doofus-01
Commit: 37696d05ce07a9755b17bfd3e2832d94ae8e51b4
https://github.com/wesnoth/wesnoth/commit/37696d05ce07a9755b17bfd3e2832d94ae8e51b4
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/units/filter.cpp
Log Message:
-----------
fix filters using this_unit in [hides]
args.loc is the location we use for 'filter as if the unit woudl be there', still the unit is curently at args.u.get_location() so to make scoped_xy_unit find the unit we have to give args.u.get_location()
Commit: 234e73384f446fa092b661e4ef113250217955a9
https://github.com/wesnoth/wesnoth/commit/234e73384f446fa092b661e4ef113250217955a9
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/terrain.cfg
Log Message:
-----------
Hide Lit Stone Walls terrain
[ci skip]
People should use the Sconce embellishment overlay now.
Commit: 914bbaf08204cbc1ea740f97945397dc60d0e68b
https://github.com/wesnoth/wesnoth/commit/914bbaf08204cbc1ea740f97945397dc60d0e68b
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/An_Orcish_Incursion/scenarios/05_Linaera_the_Quick.cfg
Log Message:
-----------
AOI S05: Fix facing
Commit: cf9c3c733771c9382606cbc0435e3e68a4c95708
https://github.com/wesnoth/wesnoth/commit/cf9c3c733771c9382606cbc0435e3e68a4c95708
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/about.cfg
Log Message:
-----------
Update admin section of the credits
[ci skip]
Commit: 823635015ef3f49230422d52f8e3b7e44d379d7d
https://github.com/wesnoth/wesnoth/commit/823635015ef3f49230422d52f8e3b7e44d379d7d
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/about_cfg_to_wiki
Log Message:
-----------
Add localization credits to wiki extraction tool
[ci skip]
Commit: c3d77c44b50743fc05733c6343961672c05e9ac9
https://github.com/wesnoth/wesnoth/commit/c3d77c44b50743fc05733c6343961672c05e9ac9
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/about_cfg_to_wiki
Log Message:
-----------
Minor stylistic changes to credit entries
* Overrule any CSS clear properties set by the stylesheet since they do
not play well with the page's use of a floated TOC.
* Use em dashes instead of hyphens for entry comments.
* Refer to the main contributors as Core Contributors instead of simply
Contributors, and add a custom heading for localization entries so it
doesn't become just "Core" after the folder name.
* Additional styling on file paths.
[ci skip]
Commit: abffb15036df331fec0d98089c903ee4fc113141
https://github.com/wesnoth/wesnoth/commit/abffb15036df331fec0d98089c903ee4fc113141
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/about.cfg
Log Message:
-----------
Move i18n managers list below release managers
Otherwise it looks silly trailing below Bots right before the
Translations section on the wiki thanks to the credits split.
[ci skip]
Commit: 82d2ac850cde823e85a74737dd2107e73fa879c2
https://github.com/wesnoth/wesnoth/commit/82d2ac850cde823e85a74737dd2107e73fa879c2
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/about_cfg_to_wiki
Log Message:
-----------
s/Translations/Translators/ seems more appropriate
[ci skip]
Commit: 56e61cf672b5f2fe1f4c2668b89ca23112cc3bd5
https://github.com/wesnoth/wesnoth/commit/56e61cf672b5f2fe1f4c2668b89ca23112cc3bd5
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
M src/addon/validation.cpp
M src/addon/validation.hpp
M src/campaign_server/campaign_server.cpp
Log Message:
-----------
Add case conflict check
Commit: 19d3dd1cbc9cc053c758c4d368451254700784e0
https://github.com/wesnoth/wesnoth/commit/19d3dd1cbc9cc053c758c4d368451254700784e0
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
Case convert in 'C' locale
Commit: f1fb5a9cc9529120cc7f6f80a66351c50e5117e7
https://github.com/wesnoth/wesnoth/commit/f1fb5a9cc9529120cc7f6f80a66351c50e5117e7
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
Disallow filenames with trailing periods
Commit: 389df64992db5ac37fdb169e2200b341da9a7011
https://github.com/wesnoth/wesnoth/commit/389df64992db5ac37fdb169e2200b341da9a7011
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
Remove redundant checks
Commit: 14af994c9fb80bbdc34d43021815a42f17dbaeb1
https://github.com/wesnoth/wesnoth/commit/14af994c9fb80bbdc34d43021815a42f17dbaeb1
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
Add extra filename blacklist checks
Check for invalid UTF-8, overly long filenames, surrogate pairs and all control characters.
Commit: 76b50788a397331c634ce523440c5385a3aa7869
https://github.com/wesnoth/wesnoth/commit/76b50788a397331c634ce523440c5385a3aa7869
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
Disallow characters not permitted on windows
Commit: 51fa9bc79d6baeaf5f9ab5125f86f627d5102c2c
https://github.com/wesnoth/wesnoth/commit/51fa9bc79d6baeaf5f9ab5125f86f627d5102c2c
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
Blacklist C1 control characters
Commit: bc995c9b279d4e57a37d5f0952c684acdf486663
https://github.com/wesnoth/wesnoth/commit/bc995c9b279d4e57a37d5f0952c684acdf486663
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
Log Message:
-----------
Eat an invalid_utf8_exception
Commit: 7823f2264d9215f577eab546c16a34f19661ecfe
https://github.com/wesnoth/wesnoth/commit/7823f2264d9215f577eab546c16a34f19661ecfe
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
Log Message:
-----------
Pango-escape addon IDs and names, as well as server responses before passing them on to the GUI
Commit: daddedb9553c833e6c4dbc69d3d2bf6b4b15d19f
https://github.com/wesnoth/wesnoth/commit/daddedb9553c833e6c4dbc69d3d2bf6b4b15d19f
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
M src/campaign_server/campaign_server.cpp
Log Message:
-----------
Further explain the filename character blacklist
Commit: e0f57723073f47586a1e9b0e8fb3b1d3c62c686c
https://github.com/wesnoth/wesnoth/commit/e0f57723073f47586a1e9b0e8fb3b1d3c62c686c
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
M src/addon/validation.hpp
M src/campaign_server/campaign_server.cpp
Log Message:
-----------
Add filename listing for case conflicts
Commit: b40a69fe55d3c0fd555b1e52bd8f66558c919404
https://github.com/wesnoth/wesnoth/commit/b40a69fe55d3c0fd555b1e52bd8f66558c919404
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
Log Message:
-----------
Add pre-upload check for case conflicts
Commit: 3979e52357e0a5334aff2ba8e75edbea8a0de2ba
https://github.com/wesnoth/wesnoth/commit/3979e52357e0a5334aff2ba8e75edbea8a0de2ba
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
List all filenames that contribute to the case conflicts
Commit: 13da90188fb4a87174ff5ee94edf227f38adad29
https://github.com/wesnoth/wesnoth/commit/13da90188fb4a87174ff5ee94edf227f38adad29
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
Log Message:
-----------
Pango-escape case-conflicted filenames
Commit: 1c3ad7f6532dd6d510e963c481fc1d7d48875a00
https://github.com/wesnoth/wesnoth/commit/1c3ad7f6532dd6d510e963c481fc1d7d48875a00
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/attack_prediction.cpp
Log Message:
-----------
New method to calculate chance to stay unscathed
@mattsc spotted that attack prediction sometimes gives incorrect results
for chance to stay unscathed when the other unit can die during the battle.
The old calculation algorithm worked by determining the chance that the
unit survives each unit unscathed, and multiplying the probabilities
together.
However, that method of probability calculations works only if the
attacks are independent, i.e. the probability of surviving *this* attack
unscathed doesn't depend on the chance of being already unscathed. And
that's not the case if either combatant can kill the other one.
If combatant A has killed combatant B, combatant B can't strike it any more
and therefore combatant A is more likely to *be* unscathed. Inversely, if A
is unscathed, it's more likely that B is dead. As a result, if A is
unscathed, A is also more likely to *stay* unscathed. The old method
couldn't take that into account and therefore produced incorrect results.
In my local tests, this new algorithm appears to produce correct results.
Only rounding errors (and drain ability) separate it from the HP
distribution tables.
Commit: d2112c62f411702fdb9226b1203fecf646dbe925
https://github.com/wesnoth/wesnoth/commit/d2112c62f411702fdb9226b1203fecf646dbe925
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/tstring.cpp
M src/tstring.hpp
Log Message:
-----------
tstring: formatting cleanup
Commit: b62ab5f1304d8697e8288e6026875f9f60c83a42
https://github.com/wesnoth/wesnoth/commit/b62ab5f1304d8697e8288e6026875f9f60c83a42
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/lobby/lobby.cpp
Log Message:
-----------
MP Lobby: fixed certain non-existent games flashing in the game list briefly
This can usually happen after a host quits a game and returns to lobby. The just-left
game can briefly appear.
Commit: 51118cce970c39da5d10cda8bdbed6767e6e396c
https://github.com/wesnoth/wesnoth/commit/51118cce970c39da5d10cda8bdbed6767e6e396c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/lobby/lobby.cpp
M src/gui/dialogs/lobby/lobby.hpp
M src/gui/dialogs/multiplayer/mp_join_game.cpp
M src/gui/dialogs/multiplayer/mp_join_game.hpp
M src/gui/dialogs/multiplayer/mp_staging.cpp
M src/gui/dialogs/multiplayer/mp_staging.hpp
Log Message:
-----------
Renamed a bunch of wesnothd dialog members for clarity
Commit: d31be79b4cb077fd2022756d5256437359a7b89f
https://github.com/wesnoth/wesnoth/commit/d31be79b4cb077fd2022756d5256437359a7b89f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_info.cpp
Log Message:
-----------
Lobby Info: simplified player list sorting code by @Ja-MiT
Commit: 976c8309d9bd2acd888e779ae650023905112c38
https://github.com/wesnoth/wesnoth/commit/976c8309d9bd2acd888e779ae650023905112c38
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/lobby/lobby.cpp
M src/gui/dialogs/lobby/lobby.hpp
Log Message:
-----------
MP Lobby: minor cleanup
* Removed some dead code.
* Removed some unnecessary bound window references.
* Removed some unnecessary code duplication.
Commit: 84028b5facdba29e7c1a95c36f16f4458c0fc432
https://github.com/wesnoth/wesnoth/commit/84028b5facdba29e7c1a95c36f16f4458c0fc432
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
M source_lists/wesnoth
M src/game_initialization/multiplayer.cpp
R src/gui/dialogs/lobby/lobby.cpp
R src/gui/dialogs/lobby/lobby.hpp
R src/gui/dialogs/lobby/player_info.cpp
R src/gui/dialogs/lobby/player_info.hpp
A src/gui/dialogs/multiplayer/lobby.cpp
A src/gui/dialogs/multiplayer/lobby.hpp
A src/gui/dialogs/multiplayer/player_info.cpp
A src/gui/dialogs/multiplayer/player_info.hpp
M src/tests/gui/test_gui2.cpp
Log Message:
-----------
GUI2: moved MP Lobby and Player Info files into the multiplayer dialog subdir
Commit: 986264caeeee9dd4788020e51546ccc15e0c7181
https://github.com/wesnoth/wesnoth/commit/986264caeeee9dd4788020e51546ccc15e0c7181
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
Log Message:
-----------
Fixup f2593034a8c3 (output dir not set)
[ci skip]
Commit: e986a7972f6d140a6838ecad682ee3eef57a742b
https://github.com/wesnoth/wesnoth/commit/e986a7972f6d140a6838ecad682ee3eef57a742b
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_audio.cpp
M src/sound.cpp
M src/sound.hpp
Log Message:
-----------
Don't use invalid music indices. Fixes #1861
Commit: 17f859855c23334d88078c771db340dafecc5361
https://github.com/wesnoth/wesnoth/commit/17f859855c23334d88078c771db340dafecc5361
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/lexical_cast.hpp
Log Message:
-----------
Fix build with -Og -Werror=maybe-uninitialized on GCC 7.2.0
It's getting tempting to just suppress -Wmaybe-uninitialized globally...
Commit: d204f8f4859e3e69c8c08e81c3a6771f866a4359
https://github.com/wesnoth/wesnoth/commit/d204f8f4859e3e69c8c08e81c3a6771f866a4359
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/action/action_village.cpp
Log Message:
-----------
Editor/Action Village: cleaned up some messy code @GregoryLundberg pointed out
Also fixes the issue brought up in #2111.
Commit: 58818dcb99f5d3838ca80ea2332b603988cc0d98
https://github.com/wesnoth/wesnoth/commit/58818dcb99f5d3838ca80ea2332b603988cc0d98
Author: Nils Kneuper <crazy-ivanovic at gmx.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
M po/wesnoth-aoi/zh_CN.po
M po/wesnoth-did/zh_CN.po
M po/wesnoth-dm/zh_CN.po
M po/wesnoth-help/zh_CN.po
M po/wesnoth-httt/zh_CN.po
M po/wesnoth-low/zh_CN.po
M po/wesnoth-manpages/zh_CN.po
M po/wesnoth-sota/zh_CN.po
M po/wesnoth-sotbe/zh_CN.po
M po/wesnoth-tsg/zh_CN.po
M po/wesnoth-units/zh_CN.po
M po/wesnoth/zh_CN.po
Log Message:
-----------
updated Chinese (Simplified) translation
Commit: 90d47293416f53edaec76d98c6548044cd6fd1e3
https://github.com/wesnoth/wesnoth/commit/90d47293416f53edaec76d98c6548044cd6fd1e3
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M SConstruct
Log Message:
-----------
Add gcov and gperftools support to scons
Commit: 6f71201fc3f70b34cb283fbb0cbc87c8f6b6f6f0
https://github.com/wesnoth/wesnoth/commit/6f71201fc3f70b34cb283fbb0cbc87c8f6b6f6f0
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M SConstruct
Log Message:
-----------
Added perf support.
Commit: 6f2e1c84f3c802ab69189bc2676c7facb9673b5a
https://github.com/wesnoth/wesnoth/commit/6f2e1c84f3c802ab69189bc2676c7facb9673b5a
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
Add Profile build to cmake to match scons.
Commit: 4304755a57b3e8da0d0a8772d4467f87008a096d
https://github.com/wesnoth/wesnoth/commit/4304755a57b3e8da0d0a8772d4467f87008a096d
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
R data/themes/unit_box.cfg
R data/themes/widescreen.cfg
Log Message:
-----------
Remove Unit Box and Widescreen themes
[ci skip]
These were half-baked and mostly badly-designed. The Unit Box theme was never finished, is completely broken,
and if we were to do a major theme refresh we'd probably go in another direction. The Widescreen theme was a
legacy experiment that was never adopted and as of now is basically alsp completely broken.
Commit: 84f771a8ec8664c264a4a72884736aacf16a718e
https://github.com/wesnoth/wesnoth/commit/84f771a8ec8664c264a4a72884736aacf16a718e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
Updated changelog for 5c7f58c
[ci skip]
Commit: d11812b32d17c664d54a017666974d0c2ed28a6c
https://github.com/wesnoth/wesnoth/commit/d11812b32d17c664d54a017666974d0c2ed28a6c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/maps/07_A_Small_Favor.map
Log Message:
-----------
DiD S7: used clean walls and new sconce terrains for the mansion
[ci skip]
The S8 map should get this change too, but I'm working on a new map for that scenario.
Commit: eec0f612988534ae48db0aed90ec5fdfe36b8ca9
https://github.com/wesnoth/wesnoth/commit/eec0f612988534ae48db0aed90ec5fdfe36b8ca9
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/tests/test_config.cpp
Log Message:
-----------
Revert config unit tests to compare attributes to empty strings again
Reverts a change in commit 2eacb4e1c3c9a14d85aa1602ddc6b248441ed7fa.
The comparison in this unit test compared an *attribute* to an empty
string, not a *string*. Furthermore, the entire point of the test was
to verify that an empty attribute doesn't compare equal to the empty
string. In its old form, the test was just wrong (and failing).
Commit: 402d6ea6e143efd9e735c826aa392473fddc022f
https://github.com/wesnoth/wesnoth/commit/402d6ea6e143efd9e735c826aa392473fddc022f
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/flg_manager.cpp
M src/game_initialization/flg_manager.hpp
M src/tests/test_mp_connect.cpp
Log Message:
-----------
FLG manager: initially select the default faction
Turns out that this is enforced by C++ unit tests (which haven't run
successfully in Travis for a couple of months).
The tests started to fail in commit d864a89a15ee0159b28b5daec492d3070db31032 when random factions
were set to always be the first in the list
(and therefore always initially selected).
Commit: f33570cc9dd59fb749c44ba5358805b675c8616a
https://github.com/wesnoth/wesnoth/commit/f33570cc9dd59fb749c44ba5358805b675c8616a
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .travis.yml
Log Message:
-----------
Travis CI: globally disable C++ unit tests
The tests haven't been run for a couple of months.
The test executable crashes on startup with the error message
Xlib: extension "RANDR" missing on display ":99.0".
After ten attempts, the test wrapper just gives up and returns success.
So, let's not even pretend that we have C++ unit tests running in Travis.
We just don't. Explicitly disabling the tests makes it more clear.
Commit: 88e47a8c7bc31f80f74b847657833cb5e574fc90
https://github.com/wesnoth/wesnoth/commit/88e47a8c7bc31f80f74b847657833cb5e574fc90
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/connect_engine.cpp
M src/game_initialization/connect_engine.hpp
M src/gui/dialogs/multiplayer/mp_staging.cpp
Log Message:
-----------
Connect Engine: cleaned up color handling a bit
* Got rid of custom color class member variable. It was no longer used except in the ctor, so it could
be demoted to a local value.
* Use color id instead of color index for coloring unknown unit image in MP Staging.
Commit: 052d2e19b275cb922152d96fab5ab74445bcad4a
https://github.com/wesnoth/wesnoth/commit/052d2e19b275cb922152d96fab5ab74445bcad4a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/connect_engine.cpp
M src/game_initialization/connect_engine.hpp
Log Message:
-----------
Connect Engine: removed "--give--" entry from controller options
This was basically used to separate players from the general controller options. In the GUI1 dialog it
was unselectable. I never got around to implementing that in the GUI2 dialog, but regardless, it doesn't
look great in the menu so I'm removing it. Plus, since the dropdowns are GUI2, we could apply different
text formatting to denote players if we wanted.
Commit: 77a107d649c16b1eb22f7c746b0bca62bdca99f4
https://github.com/wesnoth/wesnoth/commit/77a107d649c16b1eb22f7c746b0bca62bdca99f4
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
MP Create Game: remove debug mode requirement to access SP campaigns
The option to play SP campaigns in MP had been locked since support was shaky. I'm not entirely sure
how good it is currently, but games at least seem startable. This will also allow us to get more bug
reports if issues do arise, too.
Commit: a43c9fd105c833bcb49c6fd845c4de933f2da52a
https://github.com/wesnoth/wesnoth/commit/a43c9fd105c833bcb49c6fd845c4de933f2da52a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
MP Create Game: tweak game type labels
Commit: b1b790f6607efc81362344f7715278cd6f785114
https://github.com/wesnoth/wesnoth/commit/b1b790f6607efc81362344f7715278cd6f785114
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/campaign_server/campaign_server.cpp
M src/campaign_server/campaign_server.hpp
Log Message:
-----------
campaignd: Allow exempting hostmasks from download count bumps
Commit: bebbfa9a6e53cbb483045c654a93b687274bb8bb
https://github.com/wesnoth/wesnoth/commit/bebbfa9a6e53cbb483045c654a93b687274bb8bb
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/filesystem_boost.cpp
Log Message:
-----------
filesystem::base_name(): use boost::filesystem::path::stem()
No need to reinvent the wheel.
Commit: 9d2a4aa8aeb5f7bdd4ae0e88be2e34bc482e9d03
https://github.com/wesnoth/wesnoth/commit/9d2a4aa8aeb5f7bdd4ae0e88be2e34bc482e9d03
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Secrets_of_the_Ancients/scenarios/04_Becalmed.cfg
Log Message:
-----------
SotA S04: Set facings for sailors
Commit: c782bab059c63388eaab363e1e14228d8948f830
https://github.com/wesnoth/wesnoth/commit/c782bab059c63388eaab363e1e14228d8948f830
Author: Ignacio R. Morelle <shadowm at wesnoth.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/validation.cpp
Log Message:
-----------
campaignd: Blacklist standard reserved DOS Device Names
Windows XP and later define DOS device names for several system devices
that will be handled as if they had directory entries everywhere. Their
names may not be used on the left side of a file name if a dot is
present, otherwise the read or write operation in progress (if
applicable) is redirected to the device in question, with unexpected
results (e.g. writing to CON writes to a console that may or may not be
attached, writing to COM1 will send data through the first enumerated
serial port, and so on).
Thus, we really don't want add-on authors to either intentionally or
accidentally use them on non-Windows platforms and cause Windows-based
clients to do unexpected things.
Emitting special messages for the UI in this case seems unnecessary and
it'll be a waste of space most of the time since these names should crop
up extremely rarely. Better just tell people what's up on a case-by-case
basis if they decide to post in the forums about it.
Commit: bc8b69a0e031776936c8ac9e291249e82bcf5a4e
https://github.com/wesnoth/wesnoth/commit/bc8b69a0e031776936c8ac9e291249e82bcf5a4e
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj
Log Message:
-----------
Update Xcode project
Commit: 368828982b9009beb72dce0b6efeb0c23339bd5d
https://github.com/wesnoth/wesnoth/commit/368828982b9009beb72dce0b6efeb0c23339bd5d
Author: Wedge009 <wedge009 at wedge009.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
M projectfiles/VC12/wesnothd.vcxproj
Log Message:
-----------
Minor VC project updates
* Remove dependencies on SDL2_net.lib (hasn't been required since at least 8b341411)
* Remove unnecessary backslashes introduced in dccd73d1
* Sort associated filter.
[ci skip]
Commit: f225c75e4a72cd9f70fdb82a3d9634eef7832346
https://github.com/wesnoth/wesnoth/commit/f225c75e4a72cd9f70fdb82a3d9634eef7832346
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/attack_prediction.cpp
Log Message:
-----------
Fix #2117: crash if either combatant was guaranteed to die
Regression from commit f6c4f3d214f5619ece6b934d0d1003ca2f1020e7.
The code divided by zero and the probability to stay unscathed ended up as
NaN, which triggered an assertion failure if the AI simulated one more
fight for either combatant.
Commit: ca06378c990644704bea21869b25560c7bf58c1f
https://github.com/wesnoth/wesnoth/commit/ca06378c990644704bea21869b25560c7bf58c1f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/team.cpp
Log Message:
-----------
Team: formatting cleanup
Commit: 90dc2aa135d8c96a1ce1977644caba2f608317da
https://github.com/wesnoth/wesnoth/commit/90dc2aa135d8c96a1ce1977644caba2f608317da
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/team.cpp
Log Message:
-----------
Team: range-for
Commit: d3581c7860e589c3541445a5aaf2312a2619fded
https://github.com/wesnoth/wesnoth/commit/d3581c7860e589c3541445a5aaf2312a2619fded
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M RELEASE_NOTES
M changelog
M src/filesystem_boost.cpp
Log Message:
-----------
Revert "Disallow specifying file paths with backslashes"
This reverts commit 1b9c07eb402f2031ce8a85cec912c0246f426eb5.
I'm reverting this (at least temporarily) since it seems mainline contains *numerous* paths with
backslashes. This change basically spams console with warnings just from mainline/core content,
in addition to having other negative side effects such as leader image generation failing when
populating a save_index file. Plus, if backslashes really broke things on Linux, I think we'd have
had a multitude of people complaining about half their images not showing up on that platform, which
(AFAIK) has not been the case.
Commit: 01eadb4163812cdf81ce98f3a0001fed5dbf8053
https://github.com/wesnoth/wesnoth/commit/01eadb4163812cdf81ce98f3a0001fed5dbf8053
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/action/mouse/mouse_action_item.cpp
M src/editor/action/mouse/mouse_action_unit.cpp
M src/editor/palette/unit_palette.cpp
M src/gui/widgets/unit_preview_pane.cpp
M src/reports.cpp
M src/save_index.cpp
M src/team.cpp
M src/team.hpp
M src/units/drawer.cpp
M src/units/unit.cpp
M src/whiteboard/manager.cpp
M src/whiteboard/move.cpp
Log Message:
-----------
Some refactoring of team color data handling
These changes cover areas from PR #2101, excluding the removal of the numeric ID color ranges.
That can't be done yet (it breaks things).
This also excludes any changes to the connect_engine color handling. That needs to be refactored
separately. Despite the fact that it's done very similar to the new get_side_color_id function,
I need to deal with the fact that every side_engine member in the connect engine keeps a copy of
the default color options.
* Added a general-purpose function to extract color data from a config.
* Refactored the team class's general get-side's-color-data function so it always returns a color
ID instead of falling back on a number.
* Deployed this change for the leader image coloring in the save_index; said coloring is now always
done by ID.
* Save color data by ID in team_info instead of using the side number if no color was provided.
* Renamed get_side_color_index to get_side_color_id to better reflect its purpose.
Commit: 1f14d97bc783d40e7bfba836a1eb79ee438e49a0
https://github.com/wesnoth/wesnoth/commit/1f14d97bc783d40e7bfba836a1eb79ee438e49a0
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
M projectfiles/VC12/wesnothlib.vcxproj
M projectfiles/VC12/wesnothlib.vcxproj.filters
M source_lists/libwesnoth_core
M source_lists/wesnoth
M src/actions/advancement.cpp
M src/addon/client.cpp
M src/ai/default/recruitment.cpp
M src/ai/simulated_actions.cpp
M src/display.cpp
M src/formula/formula.cpp
M src/play_controller.cpp
M src/saved_game.cpp
M src/server/user_handler.cpp
M src/sound.cpp
M src/soundsource.cpp
M src/units/animation.cpp
M src/units/animation_component.cpp
M src/units/unit.cpp
Log Message:
-----------
Finish switch to MT19937 for randomness
Coverity has been complaining about using rand() as an insecure function. As we're using it, this function is not insecure; but is also not a very good RNG. We're using MT19937 in a system-independant manner. But some uses of rand() were never converted. This converts them.
This closes the following Coverity issues:
CID 1356297
CID 1356299
CID 1356303
CID 1356304
CID 1356306
CID 1356312
CID 1356314
CID 1380163
CID 1380173
CID 1380179
CID 1380191
CID 1380198
CID 1380201
CID 1380210
CID 1380214
CID 1380215
CID 1380219
CID 1380230
CID 1380241
Commit: d265e21c86fde927635e647940c64e61fba4debc
https://github.com/wesnoth/wesnoth/commit/d265e21c86fde927635e647940c64e61fba4debc
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/team.cpp
Log Message:
-----------
Removed a debugging aid accidentally committed in ff5d68f
[ci skip]
Commit: 9375b824ab95303d4b669e9900fd7071af515b6e
https://github.com/wesnoth/wesnoth/commit/9375b824ab95303d4b669e9900fd7071af515b6e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/utils/macros.cfg
Log Message:
-----------
DiD: fixed door event SLFs
[ci skip]
The door terrain codes changed when the original terrain was split into directional variants
and it seems we forgot to update this.
Commit: 3b2ab9b184889f91c727034901640be227792e69
https://github.com/wesnoth/wesnoth/commit/3b2ab9b184889f91c727034901640be227792e69
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/team.cpp
Log Message:
-----------
Fixup f878433
Issue pointed out by @jyrkive. The new loop would skip any character identical to the first
one instead of only skipping the first one.
Commit: 370763e4fb294d92554824096909dfe23120121d
https://github.com/wesnoth/wesnoth/commit/370763e4fb294d92554824096909dfe23120121d
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/team.cpp
Log Message:
-----------
Fixup ff5d68f (fixes #2125)
Also contains a minor fixup of db8891fa3c03 (sign type mismatch warning fix).
For some reason, the use of the side-1 fallback in the to_unsigned() calls was making every
side get assigned the color red... Sadly, this means an saved games created in the past 12
hours or so have broken color data. Oh well.
Commit: 2e2c85301b630f898552abdbdc8d01473280e074
https://github.com/wesnoth/wesnoth/commit/2e2c85301b630f898552abdbdc8d01473280e074
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_classification.cpp
Log Message:
-----------
Game Classification: formatting cleanup
Commit: 9207e23146daf7a677993e8f4f061e1aea458937
https://github.com/wesnoth/wesnoth/commit/9207e23146daf7a677993e8f4f061e1aea458937
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_classification.cpp
M src/game_classification.hpp
M src/game_initialization/create_engine.cpp
M src/game_initialization/lobby_data.cpp
M src/game_initialization/mp_game_utils.cpp
M src/game_initialization/multiplayer.cpp
M src/mp_game_settings.cpp
M src/mp_game_settings.hpp
M src/server/server.cpp
Log Message:
-----------
Backend changes to allow uses of proper display names for missing content in MP Lobby
For Campaigns, I needed to store the campaign name in the classification info.
For Eras, I repurposed the mp_era_addon_id key I added a year ago in d88f591eb5. It wasn't used anywhere
else, and having a better name for missing eras was the original reason to add it. I'm not sure why I
didn't think to use the name directly at the time; I do seem to have used addon_id for mod names too, but
that was changed in 5a55899b836d2 and again now (see below).
For Modifications, I added the relevant mod name to the server data. Why only this type of content
required a server change I'm not entirely sure. :/ This also finally properly fixes #1794.
Commit: 866e44cd9d595b96bcd60d070b6a008a13436467
https://github.com/wesnoth/wesnoth/commit/866e44cd9d595b96bcd60d070b6a008a13436467
Author: Rikard Falkeborn <rikard.falkeborn at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/attack_prediction.cpp
M src/display.cpp
M src/display.hpp
M src/filesystem_boost.cpp
M src/game_events/pump.cpp
M src/play_controller.hpp
Log Message:
-----------
Add const to member functions
Commit: f95bd59b3f0a41fccc8d293ddb344f4f58a2e454
https://github.com/wesnoth/wesnoth/commit/f95bd59b3f0a41fccc8d293ddb344f4f58a2e454
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/wesnoth.cpp
Log Message:
-----------
Fix command line arguments with spaces being broken on Windows
This was a regression from 8d2ae80b32a2c. Since quotes got stripped from cl arguments when they were parsed,
and since the utils::join call expected a space as a delimiter, the arguments would get put together incorrectly.
One possible fix would have been to wrap every argument in quotes, but that could potentially some issues for
certain non-quoted arguments. Instead, we just take the original command line output from the console.
Commit: d6e1161835c7a858b8bd8e60b4bc655c9be38a2d
https://github.com/wesnoth/wesnoth/commit/d6e1161835c7a858b8bd8e60b4bc655c9be38a2d
Author: Sofartin <hrubymar10 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .gitignore
Log Message:
-----------
ignore Xcode 9 Index storage
New Xcode 9 creates Index storage inside project dir. This commit makes this index ignored by GIT
Commit: d7e4db83fb078af26dbe3ccbf3ae5ba73f938ad7
https://github.com/wesnoth/wesnoth/commit/d7e4db83fb078af26dbe3ccbf3ae5ba73f938ad7
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/palette/unit_palette.cpp
Log Message:
-----------
Suppress warning about const variable
Supress CID 1134314 about 'code' being constant. Removed the TODO and dead code.
Commit: ebd7257f9cce4db402c457ae435c5a817abb19dc
https://github.com/wesnoth/wesnoth/commit/ebd7257f9cce4db402c457ae435c5a817abb19dc
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/message.cpp
M src/gui/widgets/label.cpp
M src/menu_events.cpp
Log Message:
-----------
Suppress unchecked return warning
Coverity has been complaining that a few uses of show_message do not have their return value checked.
Casting to void supresses these warning be documenting the value is intentionally not checked.
This closes
CID 1380185
CID 1380186
CID 1380258
Commit: 37aa8b33b470834fff54b52bc00f335dc6a63711
https://github.com/wesnoth/wesnoth/commit/37aa8b33b470834fff54b52bc00f335dc6a63711
Author: galegosimpatico <galegosimpatico at outlook.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/text_box_base.cpp
Log Message:
-----------
Reconfigure 'select all' for texts in macOS.
Use the idiomatic combination.
Update reference to particular comment line of
'src/widgets/textbox.cpp' in comment with the current line where the
comment is now.
Remove `unsigned` as the type for `copypaste_modifier`, because it was
a little bit less future proof that way, it is better as an
`SDL_Keycode`, which at the moment is `Sint32`, which in turn is
`int32_t` ultimately. Reuse the constant for 'select all' so renaming
it to `modifier_key`.
Commit: 5c644c065eed5a85d423367efcb36e573d553e34
https://github.com/wesnoth/wesnoth/commit/5c644c065eed5a85d423367efcb36e573d553e34
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/addon_list.cpp
M src/gui/widgets/addon_list.hpp
Log Message:
-----------
Addon List: catch user_exit exceptions when performing addon ops
This fixes an issue where the manager would close if canceling operations invoked by the
inline addon list buttons.
Commit: a3093a3227474020bbae335c3709507c3486cd85
https://github.com/wesnoth/wesnoth/commit/a3093a3227474020bbae335c3709507c3486cd85
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/addon/manager.cpp
Log Message:
-----------
Addon Manager: don't reload addon list after Update All if nothing changed
Can happen, for example, if the op was canceled. This also properly flags need_wml_cache_refresh_
on a per-addon basis when updating.
Commit: fb5600eefebb5041c2e6d65fb237d1e0207d106f
https://github.com/wesnoth/wesnoth/commit/fb5600eefebb5041c2e6d65fb237d1e0207d106f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/addon_list.cpp
Log Message:
-----------
Addon List: some minor code cleanup and formatting
Commit: b7562ad940dfeed89b9cb6dd9859f68ca2814eb2
https://github.com/wesnoth/wesnoth/commit/b7562ad940dfeed89b9cb6dd9859f68ca2814eb2
Author: galegosimpatico <galegosimpatico at outlook.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M src/actions/move.cpp
M src/display.cpp
M src/display.hpp
M src/synced_commands.cpp
Log Message:
-----------
Fix visual bug in the announces system.
Follow up 'ceba081542a4'. It is nice to remove the previously
announced message when announces are being delivered very quickly, but
maybe movement feedback announces should be exempt of that. Before
this rev, Whenever an 'Enemy unit sighted' message was being ordered
coupled with a subsequent 'press $HOTKEY to keep moving', the 'Enemy
unit sighted' message was getting discarded.
src/actions/move.cpp: Movement feedback is important, do not remove
previous messaging when announcing.
src/display.cpp: Do not remove previously announced label when so
requested.
src/display.hpp: Add a `struct` device meant to pass optional
arguments to `void announce(const std::string&, const color_t&, ...)`
instead of primitive typed optional arguments (one, `int`, was being
in use, I would have needed to add a second one, `bool`, but when
trying to do that, the `bool` value would be received by the function
as the `int` argument when not providing an explicit value for the
`int` argument (see `src/actions/move.cpp`). Given C++11, for optional
arguments, does not (to the extent of my understanding) allow
specifying the argument name on the calling place, I was forced into
adding this struct in order to jail all primitive typed optional
arguments.
src/synced_commands.cpp: Adapt to new public API in `class display`.
Commit: be50bb95ed515b72f83896588619c403a302e272
https://github.com/wesnoth/wesnoth/commit/be50bb95ed515b72f83896588619c403a302e272
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
Log Message:
-----------
Add support for PGO builds.
Commit: cfd2bd5a24e1a1e5c04d10442737e055861aa428
https://github.com/wesnoth/wesnoth/commit/cfd2bd5a24e1a1e5c04d10442737e055861aa428
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .gitignore
Log Message:
-----------
Add pgo_data to .gitignore.
Commit: 0f3a2a7722ed6ba58929fcb5f1cfe09e888114af
https://github.com/wesnoth/wesnoth/commit/0f3a2a7722ed6ba58929fcb5f1cfe09e888114af
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
M src/gui/widgets/listbox.cpp
M src/lexical_cast.hpp
M src/scripting/game_lua_kernel.cpp
M src/xBRZ/xbrz.cpp
Log Message:
-----------
Globally suppress -Wmaybe-uninitialized
We have needed to suppress it in a bunch of places because GCC has kept
giving false positives depending on optimization settings. When I noticed
yet another false positive when I attempted to build the game with PGO
profiling data using CMake, it was the last straw.
Let's just suppress the warning globally and move on with our lives.
Commit: b44b8d482555ccd8e9c2b27070c7a6c501846f0a
https://github.com/wesnoth/wesnoth/commit/b44b8d482555ccd8e9c2b27070c7a6c501846f0a
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/attack_prediction.cpp
Log Message:
-----------
Use unsynced RNG for Monte Carlo combat simulation
We don't exactly want combat simulation to cause OOS.
Commit: 5e132d9e7dcd57ce5a58b339c1516118b65ac2b5
https://github.com/wesnoth/wesnoth/commit/5e132d9e7dcd57ce5a58b339c1516118b65ac2b5
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Dead_Water/scenarios/11_Getting_Help.cfg
M data/campaigns/Dead_Water/scenarios/13_Epilogue.cfg
M data/campaigns/Eastern_Invasion/scenarios/15_The_Council.cfg
M data/campaigns/Eastern_Invasion/scenarios/18_Epilogue.cfg
M data/campaigns/Heir_To_The_Throne/scenarios/21_Elven_Council.cfg
M data/campaigns/Legend_of_Wesmere/scenarios/chapter4/13_News_from_the_Front.cfg
M data/campaigns/Northern_Rebirth/scenarios/02_02_Meeting_With_Dwarves.cfg
M data/campaigns/Northern_Rebirth/scenarios/05a_02_Dealings.cfg
M data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg
M data/campaigns/Northern_Rebirth/scenarios/14a_Epilogue.cfg
M data/campaigns/Sceptre_of_Fire/scenarios/2t_In_the_Dwarven_City.cfg
M data/campaigns/Sceptre_of_Fire/scenarios/3t_The_Council_Regathers.cfg
M data/campaigns/Sceptre_of_Fire/scenarios/4t_The_Jeweler.cfg
M data/campaigns/Sceptre_of_Fire/scenarios/Epilogue.cfg
M data/campaigns/The_Hammer_of_Thursagan/scenarios/02_Reclaiming_the_Past.cfg
M data/campaigns/The_Hammer_of_Thursagan/scenarios/13_Epilogue.cfg
M data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg
M data/campaigns/The_Rise_Of_Wesnoth/scenarios/11_Southbay_in_Winter.cfg
M data/campaigns/The_Rise_Of_Wesnoth/scenarios/16_The_Kalian.cfg
M data/campaigns/The_Rise_Of_Wesnoth/scenarios/18_A_Spy_in_the_Woods.cfg
M data/campaigns/The_Rise_Of_Wesnoth/scenarios/21_The_Plan.cfg
M data/campaigns/The_Rise_Of_Wesnoth/scenarios/23_Epilogue.cfg
M data/campaigns/Under_the_Burning_Suns/scenarios/10_Speaking_with_the_Fishes.cfg
M data/campaigns/Under_the_Burning_Suns/scenarios/13_Epilogue.cfg
Log Message:
-----------
Campaigns: Deploy Cutscene_Minimal theme for dialog only scenarios
Used for scenarios that are dialog only and use [endlevel] linger=no.
Two scenarios in NR had linger=no added for Cutscene_Minimal use.
Commit: bc2f111fabf3dd623ff07cda61815ed4c99504b7
https://github.com/wesnoth/wesnoth/commit/bc2f111fabf3dd623ff07cda61815ed4c99504b7
Author: jostephd <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg
Log Message:
-----------
HttT: fix grammar in Moremirmu's farewell
Commit: 13131ea8351b2e4bedb30d050393998a9d89a27e
https://github.com/wesnoth/wesnoth/commit/13131ea8351b2e4bedb30d050393998a9d89a27e
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M RELEASE_NOTES
M changelog
M src/filesystem_boost.cpp
Log Message:
-----------
Revert "Revert "Disallow specifying file paths with backslashes""
This reverts commit 02de08338c0f31b79f1a6604fe7470ee77471323.
Mainline does *not* contain paths with backslashes. If it did, the game
would be broken on GNU/Linux and macOS (and we'd need to fix it anyway).
Instead, it's more likely that we have code somewhere that generates
paths dynamically using backslashes on Windows, and the correct fix is
to change that code to use forward slashes instead.
Commit: 0e345e82e49adc4e227f27f8d4be558b35dc5a8e
https://github.com/wesnoth/wesnoth/commit/0e345e82e49adc4e227f27f8d4be558b35dc5a8e
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/filesystem_boost.cpp
Log Message:
-----------
Save leader image paths with forward slashes
Backslashes in file paths aren't supported after commit 1b9c07e, and
saving them with backslashes prevents leader images from showing.
Commit: 9de82598e99fa48f13b2360e6a64ae8cbc7c0a78
https://github.com/wesnoth/wesnoth/commit/9de82598e99fa48f13b2360e6a64ae8cbc7c0a78
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/save_index.cpp
M src/save_index.hpp
Log Message:
-----------
Fix up leader image paths for existing saves
As a bonus, this also makes the images show up when a save from Windows
is loaded on GNU/Linux or macOS.
It would be particularly useful if Steam Cloud was supported.
Commit: afd8f43288bf216557d9cb8a7ea4e6cabe7d6cc1
https://github.com/wesnoth/wesnoth/commit/afd8f43288bf216557d9cb8a7ea4e6cabe7d6cc1
Author: jostephd <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg
Log Message:
-----------
HttT S22: Grammar fix in Li'sar's dialog
Commit: 5ce5e4a1aaa0f6737a170f33e301610e71d4b6e1
https://github.com/wesnoth/wesnoth/commit/5ce5e4a1aaa0f6737a170f33e301610e71d4b6e1
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Two_Brothers/scenarios/03_Guarded_Castle.cfg
M data/campaigns/Two_Brothers/scenarios/04_Return_to_the_Village.cfg
Log Message:
-----------
AToTB: Facing improvements
Commit: 887ab4168cfd846ccc8973cf380e5dcb692a1e28
https://github.com/wesnoth/wesnoth/commit/887ab4168cfd846ccc8973cf380e5dcb692a1e28
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M source_lists/wesnoth
M src/gui/dialogs/chat_log.cpp
M src/gui/dialogs/editor/generator_settings.cpp
M src/gui/dialogs/multiplayer/mp_options_helper.cpp
M src/gui/dialogs/preferences_dialog.cpp
M src/gui/widgets/integer_selector.hpp
M src/gui/widgets/slider.cpp
M src/gui/widgets/slider.hpp
A src/gui/widgets/slider_base.cpp
A src/gui/widgets/slider_base.hpp
M src/utils/math.hpp
Log Message:
-----------
Slider refactor
1) We now use a single function to set slider min/max value, this fixes #1641
(sliders having a temporary invalid (min > max) state between set_min() and
set_max() calls)
2) I split the sliders_base class from the scrollbar_base class to not
accidently break the rather complicated scrollbar_base class while
refactoring sliders.
3) We don't use floats in the slider code to make sure no rounding errors happen.
4) This fixes #1539 by removing slider::in_orthoginal (which made it impossible
to pull a slider to its maximum/minimum) and intead clamping the mouse
position in range.
5) This fixes #1656 and #1767 by refactoriung code (that bug happend mainly
because the old code used variables that contained the position in 'steps'
as pixel position and vice versa)
6) Sliders now 'snap' to the correct values just like the gui1 sliders did.
7) Slider positions are now poperly rounded to its neariest values
instead of just beeing 'floored'
Commit: 5230b87de24bc9a0216cb11461249b52b2d47dd6
https://github.com/wesnoth/wesnoth/commit/5230b87de24bc9a0216cb11461249b52b2d47dd6
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider_base.cpp
Log Message:
-----------
remove unneeded special case handling.
Commit: 49f3b9157507f55d42103cd1b2320add96498450
https://github.com/wesnoth/wesnoth/commit/49f3b9157507f55d42103cd1b2320add96498450
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider.cpp
Log Message:
-----------
fix slider::set_value()
Commit: eff26be65c39d654df505647132af3d9d5a7203c
https://github.com/wesnoth/wesnoth/commit/eff26be65c39d654df505647132af3d9d5a7203c
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/window/mp_create_game.cfg
Log Message:
-----------
use step_size for exp modifer slider
Commit: 1da542d3e17b39d4e5f91320d84fce4ac018e546
https://github.com/wesnoth/wesnoth/commit/1da542d3e17b39d4e5f91320d84fce4ac018e546
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
A data/campaigns/Two_Brothers/utils/macros.cfg
Log Message:
-----------
AToTB: Add hint macro
An expanded version of the one in AOI
Commit: 004cfb9f726d1ff35fc04d72c9697346e1547d39
https://github.com/wesnoth/wesnoth/commit/004cfb9f726d1ff35fc04d72c9697346e1547d39
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Two_Brothers/scenarios/01_Rooting_Out_a_Mage.cfg
M data/campaigns/Two_Brothers/scenarios/02_The_Chase.cfg
M data/campaigns/Two_Brothers/scenarios/03_Guarded_Castle.cfg
M data/campaigns/Two_Brothers/scenarios/04_Return_to_the_Village.cfg
Log Message:
-----------
AToTB: Add a hint on easy difficulty for each objective in the campaign
Also replaces previous hint for S01 with a more direct hint
Commit: 6afeaa96d9725944562a085864bfd75aac9cb9ab
https://github.com/wesnoth/wesnoth/commit/6afeaa96d9725944562a085864bfd75aac9cb9ab
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
Log Message:
-----------
Revert accidental change from 1bfa170856eda causing serious problems
This essentially somehow was making it so game mods couldn't be deselected.
Commit: afd31e9307ec9e0cdd4a5975d665eb4c118e6fab
https://github.com/wesnoth/wesnoth/commit/afd31e9307ec9e0cdd4a5975d665eb4c118e6fab
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider_base.cpp
Log Message:
-----------
attempt to fix apple clang build
our apple travis build complains about std::div
Commit: 9a097d7c8590d243ca83d86ab3e6c74a60117a76
https://github.com/wesnoth/wesnoth/commit/9a097d7c8590d243ca83d86ab3e6c74a60117a76
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
Log Message:
-----------
Proper (I think) VC projectfile update for e9c6dff56ad8
[ci skip]
Commit: c32f8efb8febccfb043da11345f5a5aa4a3196cb
https://github.com/wesnoth/wesnoth/commit/c32f8efb8febccfb043da11345f5a5aa4a3196cb
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider_base.hpp
Log Message:
-----------
Fix syntax and autodoc errors
Commit: 1afa2d9eaca5c41e5bece60016721ccc91086df5
https://github.com/wesnoth/wesnoth/commit/1afa2d9eaca5c41e5bece60016721ccc91086df5
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider_base.cpp
M src/gui/widgets/slider_base.hpp
Log Message:
-----------
GUI2/Slider Base: formatting cleanup
Commit: 8e6a756728d5f7731b3207deda6e98b667b581c1
https://github.com/wesnoth/wesnoth/commit/8e6a756728d5f7731b3207deda6e98b667b581c1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider_base.cpp
M src/utils/math.hpp
Log Message:
-----------
Fixup 7ee39bfc1ad2b9c (include was added to the wrong file)
Commit: 4c73606fb38e096a1b69670c74959cf664fd2272
https://github.com/wesnoth/wesnoth/commit/4c73606fb38e096a1b69670c74959cf664fd2272
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M data/gui/window/lobby_main.cfg
A images/icons/icon-info-error.png
A images/icons/icon-info.png
M src/game_initialization/lobby_data.cpp
M src/gui/dialogs/multiplayer/lobby.cpp
M src/server/game.cpp
Log Message:
-----------
MP Lobby: completely redesigned game entry layout
I did one of these about a year ago, but in the time since I realize it was honestly really crowded
and had some fundamental problems (for example, the listbox would get a horizontal scrollbar if a game
with a lot of mods was started).
This time around, I've focused on simplicity. The main changes:
* The minimap has been made 10 px larger. This was to accommodate the 5 px borders, so now the actual
map image is 72x72.
* Game name and scenario name have swapped places, and the latter is now larger.
* Game names are no longer colorized based on the number of vacant slots or whether you can observe
the game or not.
* The Turns/Slots label coloring has been toned down and been made larger. It is now either white
(game has started), green (vacant slots available), or yellow (vacant slots available for reloaded game).
* The Turns limit no longer displays "/-" for games with unlimited turns. Now you just get "Turn n".
* Due to 1bfa170856ed, proper names of all missing content is displayed. I also got rid of those
"Unknown Scenario"/"Unknown Campaign" labels in favor of a simple red-color game type token (S or C),
respectively.
* All game setting icons have been moved to a tooltip attached to an info icon, except those for
Password Required and Observes Allowed.
* The info icon will also change color (and its tooltip display a message) if the player need to download
additional content to join that game.
Commit: 1b1e232ca82a5be320aa2635ae19d2f6853555b3
https://github.com/wesnoth/wesnoth/commit/1b1e232ca82a5be320aa2635ae19d2f6853555b3
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
R data/gui/window/mp_cmd_wrapper.cfg
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
M source_lists/wesnoth
R src/gui/dialogs/multiplayer/mp_cmd_wrapper.cpp
R src/gui/dialogs/multiplayer/mp_cmd_wrapper.hpp
M src/tests/gui/test_gui2.cpp
Log Message:
-----------
GUI2: removed unused MP Command Wrapper dialog
This was the equivalent of the Player Info dialog for the old GUI1 MP Lobby, and is now unused.
The new GUI2 lobby uses the aforementioned Player Info dialog. The functionality is basically
the same, though, except the send-private-message interface is more streamlined in the new lobby.
Commit: f7eae6b6a0a3a6919e9b5210c8e5b48675fc8364
https://github.com/wesnoth/wesnoth/commit/f7eae6b6a0a3a6919e9b5210c8e5b48675fc8364
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider_base.cpp
M src/gui/widgets/slider_base.hpp
Log Message:
-----------
small slider cleanup
Commit: b57048d783c9f4cdaa115756ca0b15d2fe75d17c
https://github.com/wesnoth/wesnoth/commit/b57048d783c9f4cdaa115756ca0b15d2fe75d17c
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/display.cpp
M src/play_controller.cpp
M src/server/user_handler.cpp
M src/sound.cpp
M src/soundsource.cpp
M src/units/animation.cpp
M src/units/animation_component.cpp
Log Message:
-----------
use unsyced rng for animation&sound stuff
Commit: b5b0b115240704e7c4221a24656c3c2e3055e567
https://github.com/wesnoth/wesnoth/commit/b5b0b115240704e7c4221a24656c3c2e3055e567
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/units/unit.cpp
Log Message:
-----------
use unsynced rng for unit traits
this has 2 reasons:
1) In the 'unit::unit(const unit_type& u_type ..' ctor the facting is
usually overwritten after the unit is constructed (at least the normal
unit recruit code does that) so calling the synced rng there has no
other effect than blocking undoing (in case that the unit has no traits,
otherwise undoing would already be imposible because of trait
generation)
2) in the 'unit::unit(const config& cfg ...' ctor it might make sense to
use the synced rng, but since iirc the facing attribute is already
unsynced since it changed by the drawing code (which might be skipped if
animations are disabled) we also use the unsyced rng here to not block
undoing (in that rare case).
Commit: 2d9ee0dc39bc05b3408592e5c8f3ad36a27339ae
https://github.com/wesnoth/wesnoth/commit/2d9ee0dc39bc05b3408592e5c8f3ad36a27339ae
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M SConstruct
M src/SConscript
Log Message:
-----------
Replace base build with use_srcdir option.
Commit: f08ca94751c45a2d53ae8f3d5d8f02bbedf1e635
https://github.com/wesnoth/wesnoth/commit/f08ca94751c45a2d53ae8f3d5d8f02bbedf1e635
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_data.cpp
Log Message:
-----------
Lobby Data: minor cleanup, fixup
* Wrap spaced_em_dash in a function since we can't guarantee font::unicode_em_dash will be initialized
before this is, and Travis is crashing.
* Remove an unnecessary std::string::find_first_of result check. If no character match is found, that
returns std::string::npos, which substr takes to mean the entire string.
Commit: ce89e25cc9e3366df8cbbf8fb2a10ab4b0864cb4
https://github.com/wesnoth/wesnoth/commit/ce89e25cc9e3366df8cbbf8fb2a10ab4b0864cb4
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/lobby.cpp
M src/gui/dialogs/multiplayer/lobby.hpp
Log Message:
-----------
MP Lobby: refactored game entry code
This fixes #2121.
This code was an absolute mess. It relied entirely on finding games by-index, despite there also
being a simple function in lobby_data to get a game by id. I had even written code to take an id,
find a game_info ptr, then search the games vector for a match, get an index, and then use that
index to access the games vector later :| *facepalm*
Binding indices with callbacks meant certain callbacks such as the list double click handler needed
to be constantly re-added. We also had no bounds checking in said callback. And for some reason, the
inline join/observe buttons were handled by the same code as their global counterparts (#2121).
Just... a mess. Now we can directly handle joining by either index or game id directly. The former
is now only used for the global join/observe buttons' callback, but it could potentially be used
with the plugin context code, if applicable. It depends on whether the plugin data has an index key.
Commit: 72f9aa7db35df5d15b7ed29c2e0882f74e6a36a0
https://github.com/wesnoth/wesnoth/commit/72f9aa7db35df5d15b7ed29c2e0882f74e6a36a0
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/editor/help.cfg
Log Message:
-----------
Fix editor help incomplete sentence.
Replace the sentence to make it clear the Starting Tool marks both the team leader, and named special, locations.
Closes #2085.
[ci skip]
Commit: 9e44c7655e57c4f4123a63ed783a01dbe7d895f7
https://github.com/wesnoth/wesnoth/commit/9e44c7655e57c4f4123a63ed783a01dbe7d895f7
Author: Celtic Minstrel <CelticMinstrel at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_data.cpp
Log Message:
-----------
fixup 2c7a64143a28827993f6fd1fa858ff7a03f79b56
Commit: 36880cae1fc141742c65e1cd7b60fc81d1539ce4
https://github.com/wesnoth/wesnoth/commit/36880cae1fc141742c65e1cd7b60fc81d1539ce4
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/lobby.hpp
Log Message:
-----------
Add missing autodoc comment
[ci skip]
Commit: 1b3bf0ae1f5fbf0ce52506be8100297514c529e0
https://github.com/wesnoth/wesnoth/commit/1b3bf0ae1f5fbf0ce52506be8100297514c529e0
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/lobby.cpp
M src/gui/dialogs/multiplayer/lobby.hpp
Log Message:
-----------
Remove unused parameter from MP lobby.cpp
Commit: 47ad5cced67ad41851a46efc705662c82482ad15
https://github.com/wesnoth/wesnoth/commit/47ad5cced67ad41851a46efc705662c82482ad15
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg
Log Message:
-----------
T S02: Add a message about the status table
Commit: 48d740ae956856ad7ab0ffa46732b3c661910502
https://github.com/wesnoth/wesnoth/commit/48d740ae956856ad7ab0ffa46732b3c661910502
Author: jostephd <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/14_Plunging_Into_the_Darkness.cfg
M data/core/about.cfg
Log Message:
-----------
HttT S14: Tweak dialog to be more archaic
Also add myself to contributors at @Vultraz's invitation.
Commit: de38b13c7ccd0fd2ae08e8dbcd49860e568c4c01
https://github.com/wesnoth/wesnoth/commit/de38b13c7ccd0fd2ae08e8dbcd49860e568c4c01
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_audio.cpp
M src/sound.cpp
M src/sound.hpp
Log Message:
-----------
Make get_current_track_index safer to use
This prevents problems like issue #1861.
Commit: a3798bb16a78cf9de874a2408123f629266197b8
https://github.com/wesnoth/wesnoth/commit/a3798bb16a78cf9de874a2408123f629266197b8
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/hotkey/hotkey_command.cpp
M src/hotkey/hotkey_command.hpp
Log Message:
-----------
Fix #2135: Honour the show_all_units_in_help preference during scenarios
Adding this overload removes a silent type conversion from 'enum scope'
to 'hk_scopes' (std::bitset<3>) in the src/help/help_impl.cpp callsite.
Commit: 4c0cb68780fe691373eb4e8c6787cdb3d5a754e5
https://github.com/wesnoth/wesnoth/commit/4c0cb68780fe691373eb4e8c6787cdb3d5a754e5
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/hotkey/hotkey_command.cpp
Log Message:
-----------
Restore range check.
Commit: 63003154798520fc265082dafc65c0dac7f88b6a
https://github.com/wesnoth/wesnoth/commit/63003154798520fc265082dafc65c0dac7f88b6a
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
Log Message:
-----------
Changelog entry for commit b43194ba2e8bf69efc20dd4db9739402cebee39a
Commit: ec7124989e8e43ca4e22aa2eaf3fc95afa5d7dbc
https://github.com/wesnoth/wesnoth/commit/ec7124989e8e43ca4e22aa2eaf3fc95afa5d7dbc
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_display.cpp
Log Message:
-----------
Fix highlighting reachable hexes when deselecting a moved unit.
If reach_map_ had been empty to begin with, reach_map_changed_ would
have been reset to false before display::process_reachmap_changes()
acted on it.
Fixes #2132.
Commit: 17b4da33ea9efd16851c68d88e9a24c277ea7eb9
https://github.com/wesnoth/wesnoth/commit/17b4da33ea9efd16851c68d88e9a24c277ea7eb9
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_info.cpp
M src/game_initialization/lobby_info.hpp
Log Message:
-----------
Lobby Info: store game_info objects directly in ID map
I dunno why they were stored using pointers in the first place. Probably to avoid excessive copying
before we had std::move. When I changed the code to use unique_ptrs I didn't consider that the data
could be stored directly.
Commit: c55439199095e61685493d4affd7cdc2f5a8ecea
https://github.com/wesnoth/wesnoth/commit/c55439199095e61685493d4affd7cdc2f5a8ecea
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/multiplayer/scenarios/2p_Hornshark_Island.cfg
A data/multiplayer/scenarios/2p_Hornshark_Island.lua
R data/multiplayer/scenarios/2p_Hornshark_Island_lua
Log Message:
-----------
Made Hornshark Island Lua file an actual Lua file
[ci skip]
Also simplified the Lua contained within. No need to create a local function just to immediately invoke it.
Commit: 2b00d0ccf3aa7b6b690385c26ce4938acfd0dc8f
https://github.com/wesnoth/wesnoth/commit/2b00d0ccf3aa7b6b690385c26ce4938acfd0dc8f
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_audio.cpp
Log Message:
-----------
Fix compatibility with boost 1.50
boost::optional.value was added later, so use the get method instead.
Commit: e66d5a2a280f5410d37aa800b0bab4973431054a
https://github.com/wesnoth/wesnoth/commit/e66d5a2a280f5410d37aa800b0bab4973431054a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Two_Brothers/_main.cfg
Log Message:
-----------
AToTB: tweak positioning of campaign icon
[ci skip]
Centers it more with respect to the others.
Commit: c3d6b3f1953588f6c57ea21a8f3df50fee89cafa
https://github.com/wesnoth/wesnoth/commit/c3d6b3f1953588f6c57ea21a8f3df50fee89cafa
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
Updated changelog
[ci skip]
Commit: 7a239e410e97483c1122b4f904ee6b123f61aabc
https://github.com/wesnoth/wesnoth/commit/7a239e410e97483c1122b4f904ee6b123f61aabc
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/playsingle_controller.cpp
Log Message:
-----------
add debug output
to investigate #2149
Commit: 5d7646bbb7e3bed9ed29538dc9270b425ab10f60
https://github.com/wesnoth/wesnoth/commit/5d7646bbb7e3bed9ed29538dc9270b425ab10f60
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_info.cpp
M src/game_initialization/lobby_info.hpp
Log Message:
-----------
Lobby Info: formatting and doc update
Also deployed some std::endl in place of "\n".
Commit: e537fa9876612d43759ddcbc45a6167cf344ff11
https://github.com/wesnoth/wesnoth/commit/e537fa9876612d43759ddcbc45a6167cf344ff11
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_info.cpp
M src/game_initialization/lobby_info.hpp
M src/gui/dialogs/multiplayer/lobby.cpp
Log Message:
-----------
Lobby Info: cleanup and optimization
* Deployed auto for iterators.
* Reserve container space when appropriate to reduce unnecessary copying. This is especially
useful since the game_info class has a rather lot of stuff in it.
* Don't recreate sorted users vector every time said vector is sorted. The only time the actual
contents would change are when the source (users) change, so just populate it at that point.
* Remove the games_filtered vector. This was essentially just used to get the number of visible
games with a filter active, but boost::dynamic_bitset (games_visibility) already provides
appropriate functionality, rendering it useless.
* Removed an unnecessary inline overload. Default arguments suffice instead.
Commit: d3614d9c087a27109eec09ca22512f8195e394d8
https://github.com/wesnoth/wesnoth/commit/d3614d9c087a27109eec09ca22512f8195e394d8
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/playsingle_controller.cpp
Log Message:
-----------
fix map viewport sometimes beeing reset when reloading.
fixes #2149
Commit: d74e38eb9661726a4d5950403c3daeb44d51d836
https://github.com/wesnoth/wesnoth/commit/d74e38eb9661726a4d5950403c3daeb44d51d836
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/minimap.cpp
Log Message:
-----------
When movement points > vision points, don't reveal in the minimap hexes that can be moved to but aren't yet visible.
Fixes #1645.
Commit: 08efb9968894c2869bd6fa4694dd692cef7ba681
https://github.com/wesnoth/wesnoth/commit/08efb9968894c2869bd6fa4694dd692cef7ba681
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/statistics_dialog.cpp
Log Message:
-----------
Clarify by-hand rounded %0.1f formatting
Coverity is rightly pointing out that it is not clear that `double` math is wanted, where the conversion from `long long` to `double` should occur, and where integer remainders are discarded.
Most compilers will get it right, but humans may find it confusing or unexpected.
* Did some algebra to reduce half-bit errors.
* Added a cast to make the conversion explicit.
* Aligned turn expected damage with running expected damage so both are the same representation.
Closes CID 1380164
Commit: 94b011c1eee23c87762ab9bec0643899cd01546a
https://github.com/wesnoth/wesnoth/commit/94b011c1eee23c87762ab9bec0643899cd01546a
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/pathfind/pathfind.cpp
Log Message:
-----------
Quell CID 1380157
Coverity is complaining that the index(x,y) function might return a negative value, indicating that x and/or y were not on the map.
This is impossible.
To quell the warning, use an assert().
Closes CID 1380157
Commit: e83d3c4cfbf82e76e6149e196a35d8f0cd396b4c
https://github.com/wesnoth/wesnoth/commit/e83d3c4cfbf82e76e6149e196a35d8f0cd396b4c
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
M src/gui/core/event/handler.cpp
Log Message:
-----------
Stop paranoid redraws of entire GUI2 windows
Partial revert of commit 010edbe1b99a96736ebf36cbd696c0aca6cee404.
The commit caused every GUI2 window to be fully invalidated and redrawn 50
times per second, with massive CPU usage cost. No wonder that some players
have been complaining about too high CPU usage while idling in fullscreen
GUI dialogs.
I couldn't find any obvious regressions with this change. It looks like the
underlying issue has disappeared at some point.
In my tests, CPU usage while idling in the addon manager dropped from 17 %
to 2.5 % (across all cores).
Commit: 3157163e353e6fa9fc0220063f58f3ebe2f8802e
https://github.com/wesnoth/wesnoth/commit/3157163e353e6fa9fc0220063f58f3ebe2f8802e
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/event/handler.cpp
Log Message:
-----------
Remove unused parameter
Commit: f074c43d6e532250ec48ae3c4b78e34fd53cc124
https://github.com/wesnoth/wesnoth/commit/f074c43d6e532250ec48ae3c4b78e34fd53cc124
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_data.cpp
Log Message:
-----------
Lobby Data: use proper names for Missing Content prompt
Turns out the data we need is already in the config to begin with, so we don't need to query the
addon server for anything! I kept the fallback to addon id in the case a name wasn't provided for
some reason, though.
Commit: 01ebfafb099b1b9e82dc80f2c53ee1cc92f22b6e
https://github.com/wesnoth/wesnoth/commit/01ebfafb099b1b9e82dc80f2c53ee1cc92f22b6e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/window/lobby_main.cfg
Log Message:
-----------
MP Lobby: right-align status text
[ci skip]
This prevents status text from sometimes floating off to the left if the status label shrinks but
a relayout hasn't occurred. In that case, the label widget's area would be larger than needed for
the text, and since left-align is the default setting, the next text gets stuck weirdly aligned.
Commit: d9b88e21c48e35ac91e34022597c167c3cfb76d1
https://github.com/wesnoth/wesnoth/commit/d9b88e21c48e35ac91e34022597c167c3cfb76d1
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Quell divide-by-zero warning
Coverity has been noting that `avg` might be zero when dividing. This is impossible.
Use assert() to quell the Coverity warning.
Closes CID 13801515
Commit: c4bc799896248e28109a88caa103892b774020e8
https://github.com/wesnoth/wesnoth/commit/c4bc799896248e28109a88caa103892b774020e8
Author: Severin Glöckner <severin.gloeckner at stud.htwk-leipzig.de>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/07a_Into_the_Depths.cfg
M data/core/macros/objective-utils.cfg
Log Message:
-----------
add an "optional objective" caption
In case of tsg7a neither alternative nor bonus objective fits
[ci skip]
Commit: c09a79599dbd19a576ab542bb50972c9ece97a4e
https://github.com/wesnoth/wesnoth/commit/c09a79599dbd19a576ab542bb50972c9ece97a4e
Author: lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_data.cpp
Log Message:
-----------
Quell variable hides variable warning from VC15
Commit: 6b806c31f37f0afe3bc781220fee1341b0b23ade
https://github.com/wesnoth/wesnoth/commit/6b806c31f37f0afe3bc781220fee1341b0b23ade
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M scons/sdl.py
Log Message:
-----------
Fix Scons for SDL2_mixer 2.0.2
With the change from SDL_mixer 2.0.1 to 2.0.2, we cannot simply check if SDL_mixer can open an OGG/Vorbis file, we must first open an audio device. [This is probably a mistake, since the documentation implies simply initializing the codec should be enough.] To avoid future problems, upgrade the feature-test program to perform a full initialization and shut-down; everything except actually playing the sound.
Closes #2137
Commit: 41f1ff1c72800f6055fb9b943d085b9351d8b1e1
https://github.com/wesnoth/wesnoth/commit/41f1ff1c72800f6055fb9b943d085b9351d8b1e1
Author: loonycyborg <loonycyborg at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M scons/sdl.py
Log Message:
-----------
Made ogg vorbis support check use dummy SDL audio driver
Commit: 651aeec75b64cc2369adfa2bfc21b2b204e1ab39
https://github.com/wesnoth/wesnoth/commit/651aeec75b64cc2369adfa2bfc21b2b204e1ab39
Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/wesnoth/wmltools3.py
Log Message:
-----------
wmlscope: fixed a bug that caused UMC map paths to not be found
Due to the new regex used, the tilde before UMC paths was now collected but never removed from the paths.
Commit: 3991fcbed64864d909d2e50c2ad8e47cc98a21c1
https://github.com/wesnoth/wesnoth/commit/3991fcbed64864d909d2e50c2ad8e47cc98a21c1
Author: Elvish_Hunter <elvish.hunter2010 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/tools/wesnoth/wmltools3.py
Log Message:
-----------
moved a have_icon flag that caused wmlscope to not find attack icons any more
Commit: 12d886052da30bd71c9f30dbd97a919b0632cc36
https://github.com/wesnoth/wesnoth/commit/12d886052da30bd71c9f30dbd97a919b0632cc36
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/statistics_dialog.cpp
Log Message:
-----------
One more time Coverity
When you fix the complaint about implicitly converting a long long to a double you get a complaint about implicity discarding the remainder from an integer division.
Mumble. Grumble. Glare at Coverity.
Closes CID 1382228
Commit: e5feacc919589577d385951e86ffe7ecfa9ef99e
https://github.com/wesnoth/wesnoth/commit/e5feacc919589577d385951e86ffe7ecfa9ef99e
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Revert "Quell divide-by-zero warning"
This reverts commit 07b04775ff3995fca279b15750860f5e79ae2f63.
This code is performance-critical: adding a branch for every pixel in
the surface isn't a good idea. @GregoryLundberg was fine with reverting
the commit, as well. The same is true for the next two reverts.
Fixing Coverity Scan warnings is good and all, but we shouldn't
sacrifice performance for it.
Commit: 3cbce3c1d96c7669771207ee0ae00bcc274a2483
https://github.com/wesnoth/wesnoth/commit/3cbce3c1d96c7669771207ee0ae00bcc274a2483
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Revert "add an assert to detect possible division by zero"
This reverts commit 968d8a900dc2af7cf0b2a023b5a49d84a52e470d.
Commit: a84a03bc3d2bfe6f27046e7904f90b19c45ba829
https://github.com/wesnoth/wesnoth/commit/a84a03bc3d2bfe6f27046e7904f90b19c45ba829
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/pathfind/pathfind.cpp
Log Message:
-----------
Revert "Quell CID 1380157"
This reverts commit 37ac4414b9e8ec1458e46b96b6564e15c7eb63ac.
Commit: b6e31bc9e165ececf784325b4f512144eb3cb300
https://github.com/wesnoth/wesnoth/commit/b6e31bc9e165ececf784325b4f512144eb3cb300
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/window.cpp
M src/gui/widgets/window.hpp
Log Message:
-----------
Redraw windows on top when any window changes
This commit restores redraws of entire windows, but only if a window below
has actually changed. It should fix most regressions from commit c6d8692ac6d34c71835bd581fb07b900c4ba0c5b
with a much smaller CPU usage cost.
The commit also includes a check for the situation where the title screen
changes all the time, which would restore the high CPU usage (that the
developer would be unlikely to notice immediately).
Commit: 017b984893a193290f1914d8a1381ec1db27b568
https://github.com/wesnoth/wesnoth/commit/017b984893a193290f1914d8a1381ec1db27b568
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
Log Message:
-----------
Update changelogs
Commit: cf073198b401f0bf0a6bdb43c5be253dfcabc1e9
https://github.com/wesnoth/wesnoth/commit/cf073198b401f0bf0a6bdb43c5be253dfcabc1e9
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/event/handler.cpp
M src/gui/core/event/handler.hpp
M src/gui/widgets/window.cpp
Log Message:
-----------
Fix tooltips still being drawn over
Simply use the list of event dispatchers like the old code did.
Commit: 150cdff115de929e69d0c6f2eb0b81c397f78b77
https://github.com/wesnoth/wesnoth/commit/150cdff115de929e69d0c6f2eb0b81c397f78b77
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/floating_label.cpp
Log Message:
-----------
Fixed floating label context dtors sometimes getting stuck in an infinite loop
This fixes #2154. For some reason, after opening help from the File menu and then quitting to desktop,
the number of labels recorded in the label map and context set weren't equal. I'm not exactly sure
why, since the code seems to indicate they should be, and the loop doesn't seem to be hit when only
invoking help with the hotkey (F1).
This just removes the predication of a label being present in the label map for removal from the context
set. I also removed two useless, unused variables that I'm surprised no one's complained about.
Commit: 08f055c75d9fb14ea5086e40316c8ae037bda3fa
https://github.com/wesnoth/wesnoth/commit/08f055c75d9fb14ea5086e40316c8ae037bda3fa
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sound.cpp
Log Message:
-----------
Check pointer before derefencing (fixes #2161)
current_track may be uninialized when this function is called at load-time
Commit: 00909eafff80cad651d7ee5d0c1989b1a4385315
https://github.com/wesnoth/wesnoth/commit/00909eafff80cad651d7ee5d0c1989b1a4385315
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/savegame.cpp
Log Message:
-----------
Fix useless cast
Commit: 8d2ee3c1fc6abed7938ba2072f9d8ff95d959f95
https://github.com/wesnoth/wesnoth/commit/8d2ee3c1fc6abed7938ba2072f9d8ff95d959f95
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_kernel_base.cpp
Log Message:
-----------
Fix missing 'static'
Actual warning was missing declaration. All other functions being exposed to Lua, here, are static so make this one static also.
Commit: 44df64e3aa3faa0d811667fe00922e11095fc41d
https://github.com/wesnoth/wesnoth/commit/44df64e3aa3faa0d811667fe00922e11095fc41d
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/variable_info_private.hpp
Log Message:
-----------
Quell missing declaration warnings
This so-called header is actually just splitting a large source file into two files. I would mark these functions static but this is a header; so I'm pre-declaring them in case some other compiler complains about static functions in a header.
Hopefully someone in the future will do something about this smelliness.
Commit: f69527c8f26fb1458c3fe426475adfe9a080bca2
https://github.com/wesnoth/wesnoth/commit/f69527c8f26fb1458c3fe426475adfe9a080bca2
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/statistics_dialog.cpp
Log Message:
-----------
Give up on Coverity for this
Coverity wants a cast to double. Add it and it wants a cast to long long. Add THAT and Coverity and GCC both complain.
I suppose there might be a way to rewrite things to make everyone happy. But it's easier to tell Coverity it's a false positive and force the issue closed.
Commit: 601bd4cd3db8590301eaae0f131d7647a4f37bd0
https://github.com/wesnoth/wesnoth/commit/601bd4cd3db8590301eaae0f131d7647a4f37bd0
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/chat_command_handler.cpp
M src/gui/dialogs/preferences_dialog.cpp
M src/preferences/game.cpp
M src/preferences/game.hpp
Log Message:
-----------
Preferences Dialog: fixed friends list row being added even if username was a duplicate
This fixes #2156.
preferences::add_acquaintance replaces the existing friend entry if the given username
has already been added to the acquaintance list, but the prefs dialog always added a
new row unconditionally. I've changed it to only add a new row if the username creates
a new entry, else replace the appropriate exiting row.
Commit: 56a99aadcea4abc5b32a8d0e298c1c14d57aa829
https://github.com/wesnoth/wesnoth/commit/56a99aadcea4abc5b32a8d0e298c1c14d57aa829
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
Log Message:
-----------
Clarified invalid nickname message (fixes #2157)
Apparently nicks require at least 1 alphanumeric character, meaning the previous message
was rather confusing, since the apparently valid nickname of "-_-" did not work.
Commit: bbf6552bc90dc2fb28cea8d8384c49134af55c7c
https://github.com/wesnoth/wesnoth/commit/bbf6552bc90dc2fb28cea8d8384c49134af55c7c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
Updated changelog
[ci skip]
Commit: d10c9e16d072b165fbccef35d5ef791d4583b910
https://github.com/wesnoth/wesnoth/commit/d10c9e16d072b165fbccef35d5ef791d4583b910
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/lobby.cpp
Log Message:
-----------
MP Lobby: disable Current Room user list for now
Room support was lost when porting wesnothd to boost::asio and has yet to be re-added.
Hiding this for now.
Commit: 4a404058df4fb403ed8f9b0f5abe3c0615723bc0
https://github.com/wesnoth/wesnoth/commit/4a404058df4fb403ed8f9b0f5abe3c0615723bc0
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/listbox.cpp
Log Message:
-----------
GUI2/Listbox: fully show any partially-obscured items when selected
Commit: 40d12adf474500c79c316c6464ee77cc0d2e1c94
https://github.com/wesnoth/wesnoth/commit/40d12adf474500c79c316c6464ee77cc0d2e1c94
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/lobby.cpp
Log Message:
-----------
Fixup feccf66231a3 for Travis
lobby var was set but not used after that commit.
Commit: 5b94a550ac95512a02cb96d6ef4556287698027c
https://github.com/wesnoth/wesnoth/commit/5b94a550ac95512a02cb96d6ef4556287698027c
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/action/mouse/mouse_action.cpp
M src/editor/action/mouse/mouse_action.hpp
M src/editor/action/mouse/mouse_action_select.hpp
M src/editor/toolkit/editor_toolkit.cpp
Log Message:
-----------
Remove an unnecessary layer of indirection
Commit: 2ed3b2c5a0aeb81162386653d6cf0a19a9d550b6
https://github.com/wesnoth/wesnoth/commit/2ed3b2c5a0aeb81162386653d6cf0a19a9d550b6
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/toolkit/editor_toolkit.cpp
Log Message:
-----------
Switch to default destructor, removing very old TODO
Commit: 3f07b60054aaf2dff3a885d8dc4c7d778e95c905
https://github.com/wesnoth/wesnoth/commit/3f07b60054aaf2dff3a885d8dc4c7d778e95c905
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_events/action_wml.cpp
Log Message:
-----------
Add warning about additional characters being ignored
Commit: d3320ba054626d2768c9bc5687587f8e49636d75
https://github.com/wesnoth/wesnoth/commit/d3320ba054626d2768c9bc5687587f8e49636d75
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/utils/irdya_datetime.hpp
Log Message:
-----------
Silence -Wunused-private-field warnings on Clang (fixes #2164)
Commit: 45b391ecfbef9cfcea78180ba549245e4436f956
https://github.com/wesnoth/wesnoth/commit/45b391ecfbef9cfcea78180ba549245e4436f956
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/help/help_impl.cpp
M src/help/help_topic_generators.cpp
Log Message:
-----------
help: Handle traits with empty names or descriptions.
Fixes #2108.
Commit: 94ed535b58609764c6ab4ae7babf3d8e284a4300
https://github.com/wesnoth/wesnoth/commit/94ed535b58609764c6ab4ae7babf3d8e284a4300
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/event/handler.cpp
Log Message:
-----------
Invalidate all windows again on DRAW_ALL_EVENT
Fixes #2159.
Commit: dbda7cb07e444fb6eb21c5b674ad18a1215ae81f
https://github.com/wesnoth/wesnoth/commit/dbda7cb07e444fb6eb21c5b674ad18a1215ae81f
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M scons/sdl.py
Log Message:
-----------
Fixup c4d78f8
Commit: e8d1d764f2bc98b903bf9c76ccb0186a692af49c
https://github.com/wesnoth/wesnoth/commit/e8d1d764f2bc98b903bf9c76ccb0186a692af49c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/chatbox.cpp
M src/gui/widgets/chatbox.hpp
Log Message:
-----------
GUI2/Chatbox: code cleanup/minor refactoring
* Some doc/formatting cleanup
* Removed some unnecessary functions
* Added some explanatory comments
* Removed some commented out code
* Simplified a few things.
Commit: dae06ccd61d547484bef776009c9db406ae93f77
https://github.com/wesnoth/wesnoth/commit/dae06ccd61d547484bef776009c9db406ae93f77
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/chatbox.hpp
Log Message:
-----------
Fixup 21545b5 for GCC
Commit: e8f5ef06d85d45d66d12a76bd59658bc1fbb0d18
https://github.com/wesnoth/wesnoth/commit/e8f5ef06d85d45d66d12a76bd59658bc1fbb0d18
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/window/lobby_main.cfg
Log Message:
-----------
MP Lobby: cleaned up WML layout
[ci skip]
This mostly focused on formatting and reducing the number of sub-grids in the player tree area.
Commit: 59cafc048187891cea49b725be06bb6348d95470
https://github.com/wesnoth/wesnoth/commit/59cafc048187891cea49b725be06bb6348d95470
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M src/game_initialization/create_engine.cpp
Log Message:
-----------
Create Engine: exclude campaigns from the has-sides check
This allows campaigns to be started from MP again. Should have remembered to commit this before 1.13.10 :(
Commit: 62d38b2e45ae37ab4ee58c4cd3566f17108612ab
https://github.com/wesnoth/wesnoth/commit/62d38b2e45ae37ab4ee58c4cd3566f17108612ab
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_config_manager.cpp
Log Message:
-----------
Game Config Manager: utilize unique_ptrs over shared_ptrs
Commit: b0a897d7d4d200df0687e91115918f59c6954847
https://github.com/wesnoth/wesnoth/commit/b0a897d7d4d200df0687e91115918f59c6954847
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M src/scripting/lua_unit_type.cpp
Log Message:
-----------
Lua API: Add advances_from and advances_to to unit type getter
Fixes #2169.
Commit: ccce4110bbe054a4d716b9dce15bc13277f5feee
https://github.com/wesnoth/wesnoth/commit/ccce4110bbe054a4d716b9dce15bc13277f5feee
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/statistics_dialog.cpp
Log Message:
-----------
Attempt to silence a coverity issue yet again by splitting up an expression
Commit: 326ef4ac2c1b8b3b38a8bd8f727e705d8d2829e4
https://github.com/wesnoth/wesnoth/commit/326ef4ac2c1b8b3b38a8bd8f727e705d8d2829e4
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Replace hand-written circular buffer with the boost one
Commit: 60f030cdb42970b8a1b4508338bc5b9a0a69d3b0
https://github.com/wesnoth/wesnoth/commit/60f030cdb42970b8a1b4508338bc5b9a0a69d3b0
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/scenario-test.cfg
Log Message:
-----------
Add larger blur testcase
Commit: 5659a52d0db09801f7b02bdb7caad7e60ec10542
https://github.com/wesnoth/wesnoth/commit/5659a52d0db09801f7b02bdb7caad7e60ec10542
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Properly size circular buffer
In most cases, it should now use less memory and be faster to construct.
In the other cases, blurring used to be incorrect because the buffer was too small.
Commit: ef52a404d3c87f0033a5de314423d7a268765655
https://github.com/wesnoth/wesnoth/commit/ef52a404d3c87f0033a5de314423d7a268765655
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Get rid of avg, which is now redundant
Commit: 07242cc6d8878318e2a42335ec8a1b2195260b1f
https://github.com/wesnoth/wesnoth/commit/07242cc6d8878318e2a42335ec8a1b2195260b1f
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Add comments explaining how the blurring works
Commit: 1617820af83874b64d98a06a045fe23a7e384fbd
https://github.com/wesnoth/wesnoth/commit/1617820af83874b64d98a06a045fe23a7e384fbd
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.hpp
Log Message:
-----------
Improve doxygen comments
Commit: 65919e83764d2071bca6b510ce3c6a57ab050fe1
https://github.com/wesnoth/wesnoth/commit/65919e83764d2071bca6b510ce3c6a57ab050fe1
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Further refactoring of blur algorithm
Logic is now repeated less and pixels are only decomposed once.
Commit: 6f4b86c6ff0c867e2ee709918a888048c8d72347
https://github.com/wesnoth/wesnoth/commit/6f4b86c6ff0c867e2ee709918a888048c8d72347
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sdl/utils.cpp
Log Message:
-----------
Weight RGB values by alpha
Commit: c4cbb31eb2789fa38537fd0bbe8310f501c12e0b
https://github.com/wesnoth/wesnoth/commit/c4cbb31eb2789fa38537fd0bbe8310f501c12e0b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
M src/game_launcher.cpp
M src/gui/dialogs/multiplayer/mp_connect.hpp
Log Message:
-----------
MP: prompt for server address before loading game config
This allows players to cancel and return to titlescreen quicker if they so choose.
Commit: 525a0a29504a47a1e05470eb5a547b88dd1801bc
https://github.com/wesnoth/wesnoth/commit/525a0a29504a47a1e05470eb5a547b88dd1801bc
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sound.cpp
Log Message:
-----------
Fix further possible nullptr dereferences (Fixes #2161)
Commit: 7e1c04c989d85f263665e1fc6f565ee8526f52c7
https://github.com/wesnoth/wesnoth/commit/7e1c04c989d85f263665e1fc6f565ee8526f52c7
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .gitignore
M SConstruct
M changelog
A source_lists/boost_unit_tests
R source_lists/test
M src/CMakeLists.txt
M src/SConscript
Log Message:
-----------
Renamed the target and binary for the Boost unit tests from `test` to `boost_unit_tests`
This quells warnings from CMake about reserved target names, and reduces confusion about which `test` is intended: the wesnoth executable or the standard shell command.
Commit: 9cf0916ae9268aba752982f352301eb8e0381eef
https://github.com/wesnoth/wesnoth/commit/9cf0916ae9268aba752982f352301eb8e0381eef
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
Quell CMake Warning CMP005 Deprecated
Commit: fc4f000f39f01a6cfce78177534bc5474aeac87c
https://github.com/wesnoth/wesnoth/commit/fc4f000f39f01a6cfce78177534bc5474aeac87c
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .travis.yml
M utils/travis/test_executor.sh
M utils/travis/test_wrapper.sh
Log Message:
-----------
Tell Travis about Boost unit test name change
Commit: dddd0c949d2e8b72125634b5af2924ae270d8028
https://github.com/wesnoth/wesnoth/commit/dddd0c949d2e8b72125634b5af2924ae270d8028
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/listbox.cpp
Log Message:
-----------
GUI2/Listbox: prevent selection of invalid rows in click callback (fixup 9902b07519c)
This fixes #2178. I'm not entirely sure why, but it's possible for the selected item index
to be invalid here. Added a check to head that off.
Commit: 386336cc5837dd9d8504cf803713272336e41894
https://github.com/wesnoth/wesnoth/commit/386336cc5837dd9d8504cf803713272336e41894
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
M src/gui/dialogs/network_transmission.cpp
M src/gui/dialogs/network_transmission.hpp
Log Message:
-----------
Refactor MP connection code to avoid constantly creating loading screens
Previously, the use of the wesnothd_connect_dialog and wesnothd_receive_dialog wrappers meant
multiple loading screen instances were created when connecting to MP. This change means only
one (or two, if the config is reloaded) loading screen objects are created when connecting to
the server. It also ensures the entire connection process (ie, the extent of open_connection)
is done with a loading screen displayed.
Commit: 0f4cabc544e214789e28621abe21f1d17fe5e963
https://github.com/wesnoth/wesnoth/commit/0f4cabc544e214789e28621abe21f1d17fe5e963
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/play_controller.cpp
M src/play_controller.hpp
Log Message:
-----------
replay: Set 'skip animation' button when pressing its hotkey
Commit: 94571b51721e13639e2e1547c6120054c2761f90
https://github.com/wesnoth/wesnoth/commit/94571b51721e13639e2e1547c6120054c2761f90
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/display.cpp
M src/widgets/button.hpp
Log Message:
-----------
display: Preserve checkbox status when re-creating them
Makes the 'skip animation' checkbox retain its value when redrawing the window.
Fixes #2176.
Commit: 393a5b6c6c6d8bed1500b1cf7deadda2a20ff577
https://github.com/wesnoth/wesnoth/commit/393a5b6c6c6d8bed1500b1cf7deadda2a20ff577
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_config_manager.cpp
M src/game_initialization/multiplayer.cpp
M src/game_launcher.cpp
M src/game_state.cpp
M src/gui/dialogs/loading_screen.cpp
M src/gui/dialogs/loading_screen.hpp
M src/gui/dialogs/multiplayer/mp_join_game.cpp
M src/gui/dialogs/network_transmission.cpp
M src/gui/dialogs/network_transmission.hpp
M src/play_controller.cpp
M src/playmp_controller.cpp
M src/wesnoth.cpp
Log Message:
-----------
Use an enum for loading screen stages instead of string IDs
This allows for compile-time verification of stage ID names, instead of leaving it until runtime.
It also allows the use of std::atomic for the current stage class variable since we're no longer
using a const-qualified type.
Commit: f70b264ac1c59a2a6e2762ba9c89b7b491e98e1a
https://github.com/wesnoth/wesnoth/commit/f70b264ac1c59a2a6e2762ba9c89b7b491e98e1a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
M src/gui/dialogs/multiplayer/mp_join_game.cpp
M src/gui/dialogs/network_transmission.cpp
M src/gui/dialogs/network_transmission.hpp
M src/playmp_controller.cpp
M src/wesnothd_connection.cpp
M src/wesnothd_connection.hpp
Log Message:
-----------
Refactor general-purpose fetch-server-data-with-loading-screen functions
This fully splits the wesnothd loading screen handling from the network_transmission dialog and
into wesnothd_connection. Much cleaner this way. I've also added wait_and_receive_data as a general
spin-and-wait-for-data-to-come-in function instead of having it local in open_connection.
Commit: 9e094b70549bb479df8344ce80dccdb2ae5c601c
https://github.com/wesnoth/wesnoth/commit/9e094b70549bb479df8344ce80dccdb2ae5c601c
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_launcher.cpp
Log Message:
-----------
Fix Wesnoth prompting for MP server even in local games
Regression from commit 9019074182753475b3b6788a35af0322d67ef08f.
Commit: 18d1984c3db27c83bec8b697f82e86bba2ab4ed9
https://github.com/wesnoth/wesnoth/commit/18d1984c3db27c83bec8b697f82e86bba2ab4ed9
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/widgets/button.hpp
Log Message:
-----------
Remove unneeded semicolon
Commit: 1dbdcfff4d63377f20fced4a71453be4d24ff8f3
https://github.com/wesnoth/wesnoth/commit/1dbdcfff4d63377f20fced4a71453be4d24ff8f3
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/server/server_base.hpp
M src/wesnothd_connection.hpp
Log Message:
-----------
Attempt to silence warning about deprecated stuff in Boost
For some reason, after d7302d684d9d a warning about Boost's use of gethostbyaddr and appeared
when compiling wesnothd_connection.cpp on Windows. No idea what change in the above commit caused
it, but it seems moving the _WINSOCK_DEPRECATED_NO_WARNINGS define to wesnothd_connection.hpp silences it.
Commit: 9ee76f94caa1a0dbc51cf4a469da0fd2c9fd4fed
https://github.com/wesnoth/wesnoth/commit/9ee76f94caa1a0dbc51cf4a469da0fd2c9fd4fed
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M SConstruct
Log Message:
-----------
Add ability to not create the .scons-option-cache file.
Commit: 5b819407f0bfc57c10060cd32fe76814c5f32798
https://github.com/wesnoth/wesnoth/commit/5b819407f0bfc57c10060cd32fe76814c5f32798
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sound.cpp
Log Message:
-----------
Guard against more cases of nullptr dereferenceing (fixes #2182)
Commit: 8b477946729479a2c633bbfb7926803de46684fb
https://github.com/wesnoth/wesnoth/commit/8b477946729479a2c633bbfb7926803de46684fb
Author: Celtic Minstrel <CelticMinstrel at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CONTRIBUTING.md
Log Message:
-----------
Please remember to add labels, everyone!
Commit: b9d030663fe1e9d816b18fe0a3bfcd3f20ea25e7
https://github.com/wesnoth/wesnoth/commit/b9d030663fe1e9d816b18fe0a3bfcd3f20ea25e7
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj
Log Message:
-----------
Update Xcode project
Commit: 671f4d056f7f877b58e0cd6eaa59cc50ebcfd80f
https://github.com/wesnoth/wesnoth/commit/671f4d056f7f877b58e0cd6eaa59cc50ebcfd80f
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/ai/lua/ai_helper.lua
Log Message:
-----------
Fast Micro AI ai_helper functions: fix rarely occurring bug
When the AI moves a unit out of the way for another unit’s move, it is
occasionally possible for the former unit to use up all its movement
points (e.g. if it has few MP or on narrow crowded maps). If that unit
is on the list to be moved later during the same sequence, this caused
ai_helper.robust_move_and_attack() to return nil, which then made the
Fast Micro AI produce an error message.
Commit: 8585a4b5ef3deb0d5328823ff0b1d9d418c41c20
https://github.com/wesnoth/wesnoth/commit/8585a4b5ef3deb0d5328823ff0b1d9d418c41c20
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/config.cpp
M src/config.hpp
Log Message:
-----------
Config: added function to move children from one config to another
The regular append_children function makes a copy of the applicable child tags. This moves them
from the source to the destination configs. Do note it leaves the source tags empty.
Commit: 0fe0f0637e93aea11309a598ef4aa9e147a1986b
https://github.com/wesnoth/wesnoth/commit/0fe0f0637e93aea11309a598ef4aa9e147a1986b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
M src/gui/dialogs/loading_screen.cpp
M src/gui/dialogs/loading_screen.hpp
M src/gui/dialogs/multiplayer/lobby.cpp
Log Message:
-----------
MP: wait at the loading screen until initial lobby data is fetched
This does require some more usability improvements in the future, though. First off, this change was introduced
to get rid of that pause when the lobby is first opened before any contents appears. However, this change only
affects the initial connection, not any subsequent returns to the lobby.
Second, this also means the user doesn't have a way to quit to the titlescreen if the data fetching is taking an
especially long time anymore. It was suggested instead of this, we add some indicator to the lobby that data is
being fetched, but I don't know if that's really feasible with our toolkit. Still, we should add some way to exit
the loading screen if this is taking too long.
Lastly (and building on the above, though this is a more general issue), if at any point the server conks out and
doesn't send the lobby data, or a handshake, or anything, there's no way to exit the loading screen at that point.
Need to come up with a solution for that - either a timeout, or an exit button.
Commit: 56a9e2b5c1cd8b98d515a3732a46a3ab6342c015
https://github.com/wesnoth/wesnoth/commit/56a9e2b5c1cd8b98d515a3732a46a3ab6342c015
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sound.cpp
Log Message:
-----------
Guard against even MORE nullptr dereference (should fix #2153 again)
Commit: 492570b2c41d274efa04f06cff24ba204ecc6fdc
https://github.com/wesnoth/wesnoth/commit/492570b2c41d274efa04f06cff24ba204ecc6fdc
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M src/image_modifications.cpp
Log Message:
-----------
Fixed the opacity IPF resetting to 0 if the value given was 100% or greater (fixes #2185)
This also restores the 1.12 behavior of bumping the opacity values of semi-transparent pixels
if the opacity is past 100%.
Commit: 7628899cad07a2ef669bd3b432d1ff875b6c6d86
https://github.com/wesnoth/wesnoth/commit/7628899cad07a2ef669bd3b432d1ff875b6c6d86
Author: Nils Kneuper <crazy-ivanovic at gmx.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
M po/wesnoth-lib/it.po
M po/wesnoth-manpages/it.po
M po/wesnoth-nr/it.po
M po/wesnoth-sota/it.po
M po/wesnoth-tutorial/it.po
M po/wesnoth-units/it.po
M po/wesnoth/it.po
Log Message:
-----------
updated Italian translation
Commit: 53ec5fc3ea92e48a78c860323de12c2873d81025
https://github.com/wesnoth/wesnoth/commit/53ec5fc3ea92e48a78c860323de12c2873d81025
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/sound.cpp
Log Message:
-----------
Fixup a77c40f10517
Since track_ok is used as a loop control, we need to return true if current_track is null
in order to break out, else we get stuck in an infinite loop.
Commit: d10aede1a1bf5b843b22f8b21b005ad061b4dfe7
https://github.com/wesnoth/wesnoth/commit/d10aede1a1bf5b843b22f8b21b005ad061b4dfe7
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/config_cache.cpp
M src/display.cpp
M src/editor/controller/editor_controller.cpp
M src/editor/map/editor_map.cpp
M src/minimap.cpp
M src/serialization/tag.cpp
M src/serialization/tag.hpp
M src/server/ban.cpp
M src/server/server.cpp
Log Message:
-----------
Made use of T::emplace over T::insert where possible
Commit: ee80224060ccfa1f1b32b8ebdd216f7f6f86c572
https://github.com/wesnoth/wesnoth/commit/ee80224060ccfa1f1b32b8ebdd216f7f6f86c572
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
Log Message:
-----------
MP: removed on-connection handing of unused join_game signal
I can't find any code on the server side that would send this signal, so I'm assuming it must
be a relic of some removed feature. In any case, we don't support joining MP games by bypassing
the lobby.
Note the `if(!received_join_lobby)` check was removed since it could only apply to a case where
join_game was received, since there are only two loop-exit conditions.
Commit: b4177a067066fe159be7b8e2e046ca1f4a4f4a87
https://github.com/wesnoth/wesnoth/commit/b4177a067066fe159be7b8e2e046ca1f4a4f4a87
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/multiplayer.cpp
Log Message:
-----------
MP: clean up e41534d1144 to make Soliton happy
Commit: 87adca16ac9ea9cf2fd76d6505d3e5de568db2f7
https://github.com/wesnoth/wesnoth/commit/87adca16ac9ea9cf2fd76d6505d3e5de568db2f7
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/window/lobby_main.cfg
Log Message:
-----------
Lobby Main: tweak player list entry borders
[ci skip]
No wonder this list looked messy. The labels didn't have full borders!
Commit: ec0e69d243222f8995f3573a91e33ab5f76bb890
https://github.com/wesnoth/wesnoth/commit/ec0e69d243222f8995f3573a91e33ab5f76bb890
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/server/server.cpp
Log Message:
-----------
Revert a part of ecb72d5
I guess boost::multi_index doesn't have emplace on the version of Boost Travis uses?
Commit: 0a9c3742744779343a4277d290c0e2b20c829425
https://github.com/wesnoth/wesnoth/commit/0a9c3742744779343a4277d290c0e2b20c829425
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/window/preferences/05_multiplayer.cfg
M src/gui/dialogs/preferences_dialog.cpp
M src/preferences/lobby.cpp
M src/preferences/lobby.hpp
Log Message:
-----------
Removed unused sort_list and iconize_list MP preferences
These have no effect in the GUI2 lobby, nor do I intend to make use of them (plus the lobby has
its own sort controls anyway). I'm assuming they were for the GUI1 lobby.
Commit: 0d4aee11245c147b9c903f7ebe6f995c306c6cf7
https://github.com/wesnoth/wesnoth/commit/0d4aee11245c147b9c903f7ebe6f995c306c6cf7
Author: ln-zookeeper <lari.nieminen at iki.fi>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Under_the_Burning_Suns/scenarios/06a_In_the_Tunnels_of_Trolls.cfg
Log Message:
-----------
UtBS S06a: Remove mention of use of poison not usually being tolerated
Commit: d958369d6928a152b895f8de59c02433b7240843
https://github.com/wesnoth/wesnoth/commit/d958369d6928a152b895f8de59c02433b7240843
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/horizontal_scrollbar.cpp
M src/gui/widgets/pane.cpp
M src/gui/widgets/scrollbar.hpp
M src/gui/widgets/slider.cpp
M src/gui/widgets/vertical_scrollbar.cpp
M src/gui/widgets/widget.cpp
Log Message:
-----------
GUI2: simplified some in-rect checks using sdl::point_in_rect
Commit: 80099bbe0ec37f5de8fb9c43a4101aef0abb0cfb
https://github.com/wesnoth/wesnoth/commit/80099bbe0ec37f5de8fb9c43a4101aef0abb0cfb
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/point.cpp
M src/gui/core/point.hpp
Log Message:
-----------
Made gui2::point implicitly convertible to SDL_Point
I'm planning on moving this out of the GUI2 namespace and this will allow point objects
to be used with SDL functions that take SDL_Point arguments.
Commit: 2517d1f8f53fc5f046115a3c794e41366ae7e1e0
https://github.com/wesnoth/wesnoth/commit/2517d1f8f53fc5f046115a3c794e41366ae7e1e0
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
M source_lists/wesnoth
M src/font/text.cpp
M src/font/text.hpp
M src/gui/core/event/dispatcher.hpp
M src/gui/core/event/distributor.hpp
M src/gui/core/placer.hpp
M src/gui/core/placer/horizontal_list.cpp
M src/gui/core/placer/vertical_list.cpp
R src/gui/core/point.cpp
R src/gui/core/point.hpp
M src/gui/dialogs/story_viewer.cpp
M src/gui/dialogs/tooltip.hpp
M src/gui/widgets/helper.cpp
M src/gui/widgets/helper.hpp
M src/gui/widgets/settings.cpp
M src/gui/widgets/styled_widget.cpp
M src/gui/widgets/styled_widget.hpp
M src/gui/widgets/text_box_base.hpp
M src/gui/widgets/widget.hpp
M src/gui/widgets/window.cpp
M src/gui/widgets/window.hpp
A src/sdl/point.cpp
A src/sdl/point.hpp
M src/sdl/rect.cpp
M src/sdl/rect.hpp
M src/tests/gui/test_gui2.cpp
Log Message:
-----------
Moved point wrapper out of GUI2 namespace
I'm not sure if it should become part of the sdl namespace, but for now I'm leaving it out.
Commit: 2c6779c3f1f9f11a14b1a5d1bc40a97941ac3d72
https://github.com/wesnoth/wesnoth/commit/2c6779c3f1f9f11a14b1a5d1bc40a97941ac3d72
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M data/gui/schema.cfg
M src/gui/core/window_builder.cpp
M src/gui/core/window_builder.hpp
M src/gui/widgets/widget.cpp
M src/gui/widgets/widget.hpp
M src/gui/widgets/window.hpp
Log Message:
-----------
GUI2: implemented fixed_width and fixed_height keys for all widgets
This is meant to be a cleaner replacement to the [size_lock] widget. Both keys are optional,
in which case the layout engine will assume dynamic sizing for that dimension. Dynamic sizing
will also occur if either the fixed with or height evaluates to 0 or less.
Commit: 063c46b40b5054d0cab50aaabe4c09c7fc34d5a8
https://github.com/wesnoth/wesnoth/commit/063c46b40b5054d0cab50aaabe4c09c7fc34d5a8
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/macros/_initial.cfg
M data/gui/window/lobby_main.cfg
M data/gui/window/mp_join_game.cfg
M data/gui/window/mp_staging.cfg
Log Message:
-----------
GUI2: removed GUI_FORCE_WIDGET_SIZE macro in favor of fixed_width/fixed_height keys
[ci skip]
Commit: cb9ae414ae4f53e47613203a88e4d92dcabee56b
https://github.com/wesnoth/wesnoth/commit/cb9ae414ae4f53e47613203a88e4d92dcabee56b
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/hotkey/hotkey_handler_sp.cpp
Log Message:
-----------
fix #2186 unable to save game in replay mode
Commit: 27450840f35ca934528f5e00cdce4f45ba1d840b
https://github.com/wesnoth/wesnoth/commit/27450840f35ca934528f5e00cdce4f45ba1d840b
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/lua/feeding.lua
Log Message:
-----------
fix bug in feeding code
wesnoth.current.event_context might not contain all information if the die event was triggered by wml ([fire_event]), this made wesnoth.get_unit error (invalid argument)
Commit: 9605261d84d4be0d2bb031d4fe9f3305c07c77ba
https://github.com/wesnoth/wesnoth/commit/9605261d84d4be0d2bb031d4fe9f3305c07c77ba
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
A data/core/images/terrain/interior/cave-rug/rug-corner-n-ne-se-s.png
A data/core/images/terrain/interior/cave-rug/rug-corner-nw-n-ne.png
A data/core/images/terrain/interior/cave-rug/rug-corner-s-sw-nw-n.png
A data/core/images/terrain/interior/cave-rug/rug-corner-se-s-sw.png
A data/core/images/terrain/interior/cave-rug/rug-hex-full.png
A data/core/images/terrain/interior/cave-rug/rug-hex-left.png
A data/core/images/terrain/interior/cave-rug/rug-hex-lower.png
A data/core/images/terrain/interior/cave-rug/rug-hex-ne.png
A data/core/images/terrain/interior/cave-rug/rug-hex-nw.png
A data/core/images/terrain/interior/cave-rug/rug-hex-right.png
A data/core/images/terrain/interior/cave-rug/rug-hex-se.png
A data/core/images/terrain/interior/cave-rug/rug-hex-sw.png
A data/core/images/terrain/interior/cave-rug/rug-hex-upper.png
A data/core/images/terrain/interior/cave-rug/rug-hex.png
A data/core/images/terrain/interior/cave-rug/rug-n-ne-se-s-sw-nw.png
A data/core/images/terrain/interior/cave-rug/rug-n-ne-se-s-sw.png
A data/core/images/terrain/interior/cave-rug/rug-n-ne-se-s.png
A data/core/images/terrain/interior/cave-rug/rug-n-ne-se.png
A data/core/images/terrain/interior/cave-rug/rug-n-ne.png
A data/core/images/terrain/interior/cave-rug/rug-ne-se-s-sw-nw.png
A data/core/images/terrain/interior/cave-rug/rug-ne-se-s-sw.png
A data/core/images/terrain/interior/cave-rug/rug-ne-se-s.png
A data/core/images/terrain/interior/cave-rug/rug-ne-se.png
A data/core/images/terrain/interior/cave-rug/rug-ne.png
A data/core/images/terrain/interior/cave-rug/rug-nw-n-ne-se-s.png
A data/core/images/terrain/interior/cave-rug/rug-nw-n-ne-se.png
A data/core/images/terrain/interior/cave-rug/rug-nw-n-ne.png
A data/core/images/terrain/interior/cave-rug/rug-nw-n.png
A data/core/images/terrain/interior/cave-rug/rug-nw.png
A data/core/images/terrain/interior/cave-rug/rug-s-sw-nw-n-ne.png
A data/core/images/terrain/interior/cave-rug/rug-s-sw-nw-n.png
A data/core/images/terrain/interior/cave-rug/rug-s-sw-nw.png
A data/core/images/terrain/interior/cave-rug/rug-s-sw.png
A data/core/images/terrain/interior/cave-rug/rug-se-s-sw-nw-n.png
A data/core/images/terrain/interior/cave-rug/rug-se-s-sw-nw.png
A data/core/images/terrain/interior/cave-rug/rug-se-s-sw.png
A data/core/images/terrain/interior/cave-rug/rug-se-s.png
A data/core/images/terrain/interior/cave-rug/rug-se.png
A data/core/images/terrain/interior/cave-rug/rug-smallcorner-ne.png
A data/core/images/terrain/interior/cave-rug/rug-smallcorner-nw.png
A data/core/images/terrain/interior/cave-rug/rug-smallcorner-se.png
A data/core/images/terrain/interior/cave-rug/rug-smallcorner-sw.png
A data/core/images/terrain/interior/cave-rug/rug-sw-nw-n-ne-se.png
A data/core/images/terrain/interior/cave-rug/rug-sw-nw-n-ne.png
A data/core/images/terrain/interior/cave-rug/rug-sw-nw-n.png
A data/core/images/terrain/interior/cave-rug/rug-sw-nw.png
A data/core/images/terrain/interior/cave-rug/rug-sw.png
A data/core/images/terrain/interior/cave-rug/rug-tile.png
A data/core/images/terrain/interior/regular-rug/rug-corner-n-ne-se-s.png
A data/core/images/terrain/interior/regular-rug/rug-corner-nw-n-ne.png
A data/core/images/terrain/interior/regular-rug/rug-corner-s-sw-nw-n.png
A data/core/images/terrain/interior/regular-rug/rug-corner-se-s-sw.png
A data/core/images/terrain/interior/regular-rug/rug-hex-full.png
A data/core/images/terrain/interior/regular-rug/rug-hex-left.png
A data/core/images/terrain/interior/regular-rug/rug-hex-lower.png
A data/core/images/terrain/interior/regular-rug/rug-hex-ne.png
A data/core/images/terrain/interior/regular-rug/rug-hex-nw.png
A data/core/images/terrain/interior/regular-rug/rug-hex-right.png
A data/core/images/terrain/interior/regular-rug/rug-hex-se.png
A data/core/images/terrain/interior/regular-rug/rug-hex-sw.png
A data/core/images/terrain/interior/regular-rug/rug-hex-upper.png
A data/core/images/terrain/interior/regular-rug/rug-hex.png
A data/core/images/terrain/interior/regular-rug/rug-n-ne-se-s-sw-nw.png
A data/core/images/terrain/interior/regular-rug/rug-n-ne-se-s-sw.png
A data/core/images/terrain/interior/regular-rug/rug-n-ne-se-s.png
A data/core/images/terrain/interior/regular-rug/rug-n-ne-se.png
A data/core/images/terrain/interior/regular-rug/rug-n-ne.png
A data/core/images/terrain/interior/regular-rug/rug-ne-se-s-sw-nw.png
A data/core/images/terrain/interior/regular-rug/rug-ne-se-s-sw.png
A data/core/images/terrain/interior/regular-rug/rug-ne-se-s.png
A data/core/images/terrain/interior/regular-rug/rug-ne-se.png
A data/core/images/terrain/interior/regular-rug/rug-ne.png
A data/core/images/terrain/interior/regular-rug/rug-nw-n-ne-se-s.png
A data/core/images/terrain/interior/regular-rug/rug-nw-n-ne-se.png
A data/core/images/terrain/interior/regular-rug/rug-nw-n-ne.png
A data/core/images/terrain/interior/regular-rug/rug-nw-n.png
A data/core/images/terrain/interior/regular-rug/rug-nw.png
A data/core/images/terrain/interior/regular-rug/rug-s-sw-nw-n-ne.png
A data/core/images/terrain/interior/regular-rug/rug-s-sw-nw-n.png
A data/core/images/terrain/interior/regular-rug/rug-s-sw-nw.png
A data/core/images/terrain/interior/regular-rug/rug-s-sw.png
A data/core/images/terrain/interior/regular-rug/rug-se-s-sw-nw-n.png
A data/core/images/terrain/interior/regular-rug/rug-se-s-sw-nw.png
A data/core/images/terrain/interior/regular-rug/rug-se-s-sw.png
A data/core/images/terrain/interior/regular-rug/rug-se-s.png
A data/core/images/terrain/interior/regular-rug/rug-se.png
A data/core/images/terrain/interior/regular-rug/rug-smallcorner-ne.png
A data/core/images/terrain/interior/regular-rug/rug-smallcorner-nw.png
A data/core/images/terrain/interior/regular-rug/rug-smallcorner-se.png
A data/core/images/terrain/interior/regular-rug/rug-smallcorner-sw.png
A data/core/images/terrain/interior/regular-rug/rug-sw-nw-n-ne-se.png
A data/core/images/terrain/interior/regular-rug/rug-sw-nw-n-ne.png
A data/core/images/terrain/interior/regular-rug/rug-sw-nw-n.png
A data/core/images/terrain/interior/regular-rug/rug-sw-nw.png
A data/core/images/terrain/interior/regular-rug/rug-sw.png
A data/core/images/terrain/interior/regular-rug/rug-tile.png
A data/core/images/terrain/interior/royal-rug/rug-corner-n-ne-se-s.png
A data/core/images/terrain/interior/royal-rug/rug-corner-nw-n-ne.png
A data/core/images/terrain/interior/royal-rug/rug-corner-s-sw-nw-n.png
A data/core/images/terrain/interior/royal-rug/rug-corner-se-s-sw.png
A data/core/images/terrain/interior/royal-rug/rug-hex-full.png
A data/core/images/terrain/interior/royal-rug/rug-hex-left.png
A data/core/images/terrain/interior/royal-rug/rug-hex-lower.png
A data/core/images/terrain/interior/royal-rug/rug-hex-ne.png
A data/core/images/terrain/interior/royal-rug/rug-hex-nw.png
A data/core/images/terrain/interior/royal-rug/rug-hex-right.png
A data/core/images/terrain/interior/royal-rug/rug-hex-se.png
A data/core/images/terrain/interior/royal-rug/rug-hex-sw.png
A data/core/images/terrain/interior/royal-rug/rug-hex-upper.png
A data/core/images/terrain/interior/royal-rug/rug-hex.png
A data/core/images/terrain/interior/royal-rug/rug-n-ne-se-s-sw-nw.png
A data/core/images/terrain/interior/royal-rug/rug-n-ne-se-s-sw.png
A data/core/images/terrain/interior/royal-rug/rug-n-ne-se-s.png
A data/core/images/terrain/interior/royal-rug/rug-n-ne-se.png
A data/core/images/terrain/interior/royal-rug/rug-n-ne.png
A data/core/images/terrain/interior/royal-rug/rug-ne-se-s-sw-nw.png
A data/core/images/terrain/interior/royal-rug/rug-ne-se-s-sw.png
A data/core/images/terrain/interior/royal-rug/rug-ne-se-s.png
A data/core/images/terrain/interior/royal-rug/rug-ne-se.png
A data/core/images/terrain/interior/royal-rug/rug-ne.png
A data/core/images/terrain/interior/royal-rug/rug-nw-n-ne-se-s.png
A data/core/images/terrain/interior/royal-rug/rug-nw-n-ne-se.png
A data/core/images/terrain/interior/royal-rug/rug-nw-n-ne.png
A data/core/images/terrain/interior/royal-rug/rug-nw-n.png
A data/core/images/terrain/interior/royal-rug/rug-nw.png
A data/core/images/terrain/interior/royal-rug/rug-s-sw-nw-n-ne.png
A data/core/images/terrain/interior/royal-rug/rug-s-sw-nw-n.png
A data/core/images/terrain/interior/royal-rug/rug-s-sw-nw.png
A data/core/images/terrain/interior/royal-rug/rug-s-sw.png
A data/core/images/terrain/interior/royal-rug/rug-se-s-sw-nw-n.png
A data/core/images/terrain/interior/royal-rug/rug-se-s-sw-nw.png
A data/core/images/terrain/interior/royal-rug/rug-se-s-sw.png
A data/core/images/terrain/interior/royal-rug/rug-se-s.png
A data/core/images/terrain/interior/royal-rug/rug-se.png
A data/core/images/terrain/interior/royal-rug/rug-smallcorner-ne.png
A data/core/images/terrain/interior/royal-rug/rug-smallcorner-nw.png
A data/core/images/terrain/interior/royal-rug/rug-smallcorner-se.png
A data/core/images/terrain/interior/royal-rug/rug-smallcorner-sw.png
A data/core/images/terrain/interior/royal-rug/rug-sw-nw-n-ne-se.png
A data/core/images/terrain/interior/royal-rug/rug-sw-nw-n-ne.png
A data/core/images/terrain/interior/royal-rug/rug-sw-nw-n.png
A data/core/images/terrain/interior/royal-rug/rug-sw-nw.png
A data/core/images/terrain/interior/royal-rug/rug-sw.png
A data/core/images/terrain/interior/royal-rug/rug-tile.png
M data/core/terrain-graphics.cfg
M data/core/terrain-graphics/new-macros.cfg
M data/core/terrain.cfg
Log Message:
-----------
Three carpet terrains (#2114)
Squash and merge for three carpets terrain PR.
* Initial commit for carpets. WML, alignment, and demo only, images are unshaded place-holders.
* adding basic shading and better corner images
* completed shading for existing images
* refined large corner carpet rules
* got rid of some commented out leftovers
* initial commit for cave rug, Iwd
* regular carpet files, incomplete for now
* completed regular rug
* changed cave-rug underlayer to cave path instead of dark flagstones, and changed all rug terrain codes
* fixing some transition WML filtering for Urc (cave carpet)
Commit: 498bd3647e51f1ca7604dd1ff8f96718eb289387
https://github.com/wesnoth/wesnoth/commit/498bd3647e51f1ca7604dd1ff8f96718eb289387
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg
Log Message:
-----------
HttT S20b: Set time areas for inside and outside of caves
>From Alarantalara in the forums:
https://forums.wesnoth.org/viewtopic.php?f=38&t=32861&hilit=underground+channels&start=15#p475971
Commit: 74099a8eaabec9963a6df313fc8ada8e4cf3e7d5
https://github.com/wesnoth/wesnoth/commit/74099a8eaabec9963a6df313fc8ada8e4cf3e7d5
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg
Log Message:
-----------
HttT S20b: Fix punctuation
Commit: 790b6650bd517a486f26ee2e94801e0c1cb7f108
https://github.com/wesnoth/wesnoth/commit/790b6650bd517a486f26ee2e94801e0c1cb7f108
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg
Log Message:
-----------
HttT S20b: Fix team name
Commit: d94ef98c81a9f72ef26bef6815a640f4e1b6e05b
https://github.com/wesnoth/wesnoth/commit/d94ef98c81a9f72ef26bef6815a640f4e1b6e05b
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg
Log Message:
-----------
HttT S20b: Adjust Saurian gold & income now that there is underground time
Commit: 9d62dfa94a8851354b3a771cd41181e29f32a473
https://github.com/wesnoth/wesnoth/commit/9d62dfa94a8851354b3a771cd41181e29f32a473
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg
Log Message:
-----------
HttT S19c: Give player a head start on leveling the sergeant
Commit: b7fcf0425b9e25854ba7b8dc13b5796afde4d11a
https://github.com/wesnoth/wesnoth/commit/b7fcf0425b9e25854ba7b8dc13b5796afde4d11a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/action/mouse/mouse_action.cpp
M src/editor/action/mouse/mouse_action.hpp
M src/editor/action/mouse/mouse_action_select.hpp
M src/editor/toolkit/editor_toolkit.cpp
Log Message:
-----------
Revert "Remove an unnecessary layer of indirection"
This reverts commit cdec9b2a7a0ea4d46231b92141ef75568411ab58. This commit broke selection of different
brushes in the Editor. Using a single pointer means changes to the brush pointer in editor_toolkit aren't
reflected in the action objects.
The double pointer isn't the cleanest code, but I'm not sure how to improve it.
Commit: 343d3536db3aec9c917b8001de066f9bd6e8e472
https://github.com/wesnoth/wesnoth/commit/343d3536db3aec9c917b8001de066f9bd6e8e472
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/controller/editor_controller.cpp
Log Message:
-----------
Editor: don't refer to 'this map' in quit prompt if current map is not modified
Commit: 08ad0d1e8156141be2be250f086d9aa83606f0a6
https://github.com/wesnoth/wesnoth/commit/08ad0d1e8156141be2be250f086d9aa83606f0a6
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Eastern_Invasion/maps/Throne_Room.map
Log Message:
-----------
EI: further improvements to throne room map
[ci skip]
Carpet, sconces, etc.
Commit: 5d6cc48f34f3b86908f107db8e822bb8940ea534
https://github.com/wesnoth/wesnoth/commit/5d6cc48f34f3b86908f107db8e822bb8940ea534
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
Add extra_flags to cmake.
Commit: 952cd3cb3c2988f117ce107ba40c0fb523d35ef8
https://github.com/wesnoth/wesnoth/commit/952cd3cb3c2988f117ce107ba40c0fb523d35ef8
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/display.cpp
Log Message:
-----------
Stop creating invisible pseudo-haloes for [item]s
It makes halo code significantly easier to debug in the test scenario
when there isn't dozens of these around.
Commit: 67b22cf6a45b4a1f1efe0ca5f8fd2f1dd4641e67
https://github.com/wesnoth/wesnoth/commit/67b22cf6a45b4a1f1efe0ca5f8fd2f1dd4641e67
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/halo.cpp
Log Message:
-----------
Remove new_haloes
New haloes were sometimes added to both new_haloes and invalidated_haloes,
and were therefore rendered twice in the same frame. As a result, the halo
added itself to its unrender buffer, and therefore remained on screen even
after unrendering.
Eliminating the entire new_haloes set fixes the issue. Fixes #2187.
Commit: 0c29cc5912ff2fbd8c0fe5076f54db9bd2872e03
https://github.com/wesnoth/wesnoth/commit/0c29cc5912ff2fbd8c0fe5076f54db9bd2872e03
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj
Log Message:
-----------
Update Xcode project
Commit: 3010a7977b0b50f79946e3826b034f93fecf626c
https://github.com/wesnoth/wesnoth/commit/3010a7977b0b50f79946e3826b034f93fecf626c
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/images/terrain/interior/regular-rug/rug-corner-n-ne-se-s.png
M data/core/images/terrain/interior/regular-rug/rug-n-ne.png
M data/core/images/terrain/interior/regular-rug/rug-ne.png
M data/core/images/terrain/interior/regular-rug/rug-nw-n-ne.png
M data/core/images/terrain/interior/regular-rug/rug-nw.png
M data/core/images/terrain/interior/regular-rug/rug-se.png
M data/core/images/terrain/interior/regular-rug/rug-sw.png
Log Message:
-----------
adjust outer edges to avoid borders overlapping interior
Commit: 40e33680c1b340c0d13359ad007cba632e15de28
https://github.com/wesnoth/wesnoth/commit/40e33680c1b340c0d13359ad007cba632e15de28
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
A data/core/images/terrain/interior/carpet_mask.png
M data/core/terrain-graphics/new-macros.cfg
Log Message:
-----------
hack to keep carpets from spilling into castles
Commit: 00edff3a7a0950680e97185b0a6d0144374c8e9e
https://github.com/wesnoth/wesnoth/commit/00edff3a7a0950680e97185b0a6d0144374c8e9e
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/images/terrain/interior/regular-rug/rug-n-ne-se-s-sw.png
M data/core/images/terrain/interior/regular-rug/rug-n-ne-se-s.png
M data/core/images/terrain/interior/regular-rug/rug-n-ne-se.png
M data/core/images/terrain/interior/regular-rug/rug-n-ne.png
M data/core/images/terrain/interior/regular-rug/rug-nw-n.png
M data/core/images/terrain/interior/regular-rug/rug-s-sw-nw-n.png
M data/core/images/terrain/interior/regular-rug/rug-se-s-sw-nw-n.png
M data/core/images/terrain/interior/regular-rug/rug-sw-nw-n.png
Log Message:
-----------
clipping upper tips of diagonal borders to deal with overlap
Commit: f71354f7d3fc64502d7ea749ea538752a7ddc2ef
https://github.com/wesnoth/wesnoth/commit/f71354f7d3fc64502d7ea749ea538752a7ddc2ef
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/editor/controller/editor_controller.cpp
Log Message:
-----------
Fixed context menus not working in the editor (fixes #2183)
Turns out after moving the menu handling to right-button-up, I didn't add a call to the base
method here, which meant the show-context-menu code was never called.
Commit: d72bb4bc83659fbfb66b189c350ec520089d44d1
https://github.com/wesnoth/wesnoth/commit/d72bb4bc83659fbfb66b189c350ec520089d44d1
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/terrain-graphics/new-macros.cfg
Log Message:
-----------
changing castle-wall layering when next to Xos
to address issue #2190
Commit: 0cb38eab23f92562383ee985cb3c7ed0e8307224
https://github.com/wesnoth/wesnoth/commit/0cb38eab23f92562383ee985cb3c7ed0e8307224
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/listbox.cpp
M src/gui/widgets/listbox.hpp
M src/gui/widgets/scrollbar_container.cpp
Log Message:
-----------
GUI2: moved some listbox-specific code out of scrollbar_container and into listbox
Commit: 5552e3c6d43823b591eedaa764af32dbb82c6b2f
https://github.com/wesnoth/wesnoth/commit/5552e3c6d43823b591eedaa764af32dbb82c6b2f
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/terrain-graphics/new-macros.cfg
Log Message:
-----------
more changes to castle to wall layering
further attempt to fix #2190
Commit: 880ef2ca390615a92aad3cf7e926167c6917e5f3
https://github.com/wesnoth/wesnoth/commit/880ef2ca390615a92aad3cf7e926167c6917e5f3
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_common.cpp
M src/scripting/lua_formula_bridge.cpp
M src/scripting/lua_kernel_base.cpp
Log Message:
-----------
Respect lua_next constraints
The key value returned by lua_next, on the Lua stack, cannot be modified.
Certain tests such as lua_isstring will convert the value.
The solution is, instead of testing if they key can be converted to a string, test if it actually is a string by using lua_type.
Commit: caeff1040a7f79a627c92292031e1ba744b347f0
https://github.com/wesnoth/wesnoth/commit/caeff1040a7f79a627c92292031e1ba744b347f0
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_kernel_base.cpp
Log Message:
-----------
Do not lua_next on userdata.
Ever.
Really.
YOU HAVE BEEN WARNED!
Closes #2171
Commit: 848748a9c6e76fa196161d6881b74c3ef70e9ec7
https://github.com/wesnoth/wesnoth/commit/848748a9c6e76fa196161d6881b74c3ef70e9ec7
Author: josteph <josteph at fastmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Two_Brothers/scenarios/03_Guarded_Castle.cfg
Log Message:
-----------
AToTB S03: Tweak hint to not assume the AI will make mistakes
Commit: 721f98e5411525e920bd9f13111dcb9acb7a1375
https://github.com/wesnoth/wesnoth/commit/721f98e5411525e920bd9f13111dcb9acb7a1375
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg
Log Message:
-----------
Fixup 61c33f9
The sergeant's stats are in two places.
Commit: b6a763f34aa87d02a6aba5f00b4267d8d1e8ad9f
https://github.com/wesnoth/wesnoth/commit/b6a763f34aa87d02a6aba5f00b4267d8d1e8ad9f
Author: ln-zookeeper <lari.nieminen at iki.fi>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M data/multiplayer/scenarios/2p_Dark_Forecast.cfg
Log Message:
-----------
Dark Forecast: Fix broken leader/faction/color selection, fixes #2147
Commit: d6e0a6efd0fd516c4c41b8632069b41d333a91a9
https://github.com/wesnoth/wesnoth/commit/d6e0a6efd0fd516c4c41b8632069b41d333a91a9
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
Log Message:
-----------
fix crash when selecting a random scenario in mp create
previously the game would crash (manditory child missing) in depcheck.cpp if the id of the generated scenario is not the same as the id of the outer scenario.
Commit: 61ff2a3569b0195f14615dedf6844430acd5906b
https://github.com/wesnoth/wesnoth/commit/61ff2a3569b0195f14615dedf6844430acd5906b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/formula/function.cpp
M src/formula/function.hpp
Log Message:
-----------
WFL/Formula: cleaned up formatting and greatly reduced code duplication
I added a helper macro to define the various function classes.
Commit: 5ddaf7e45439c77d2e24fb68567f5b41ce5b41c9
https://github.com/wesnoth/wesnoth/commit/5ddaf7e45439c77d2e24fb68567f5b41ce5b41c9
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/formula/function.hpp
Log Message:
-----------
Don't concatenate int arguments
Commit: 89e7a35838c2500fdf174b32bd5333455f371346
https://github.com/wesnoth/wesnoth/commit/89e7a35838c2500fdf174b32bd5333455f371346
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/formula/function.cpp
Log Message:
-----------
Fix unused variable warning
Commit: 0d41146feecd39f38ca829260d7f31fd6f249e0d
https://github.com/wesnoth/wesnoth/commit/0d41146feecd39f38ca829260d7f31fd6f249e0d
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/formula/ai.cpp
M src/ai/formula/function_table.cpp
M src/formula/formula.cpp
M src/formula/function.cpp
M src/formula/function.hpp
Log Message:
-----------
WFL/Formula: some minor code refactoring and build fix from e50a63927bd1
Commit: e029be8a0d63c6b99405ba4b194c82d3ed21c5e9
https://github.com/wesnoth/wesnoth/commit/e029be8a0d63c6b99405ba4b194c82d3ed21c5e9
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
Log Message:
-----------
give an error if two mods/era with the same id exist.
Commit: 96a45aa29319e90f4f6ccdbbd77f08f21c6381b1
https://github.com/wesnoth/wesnoth/commit/96a45aa29319e90f4f6ccdbbd77f08f21c6381b1
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/SConscript
Log Message:
-----------
Minor code cleanup.
Commit: 5df89d04808d39c36b5bf2beadadbd297f8be1c3
https://github.com/wesnoth/wesnoth/commit/5df89d04808d39c36b5bf2beadadbd297f8be1c3
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/SConscript
Log Message:
-----------
wesnoth_objects -> libwesnoth_objects
Commit: 4ad1f15a59479385e50aa5f5d3f8aecb1bcc4661
https://github.com/wesnoth/wesnoth/commit/4ad1f15a59479385e50aa5f5d3f8aecb1bcc4661
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/SConscript
Log Message:
-----------
Remove a list of 1.
Commit: 9adfc0b9d0c88504e6815985656b832b79979d19
https://github.com/wesnoth/wesnoth/commit/9adfc0b9d0c88504e6815985656b832b79979d19
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/formula/function.cpp
Log Message:
-----------
Use std::move() instead of std::forward()
Std::forward() is intended to be used in reference-collapsing contexts
(i.e. templates). @Vultraz said in Discord that the code doesn't compile
with std::move(), but it compiles just fine for me with Visual Studio 2017.
Commit: c5659f19934b96fbba38a7697ee939cc75c36571
https://github.com/wesnoth/wesnoth/commit/c5659f19934b96fbba38a7697ee939cc75c36571
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_fileops.cpp
Log Message:
-----------
fix 2198 : dead condition found by cppcheck
this doesn't change the behviour since `std::string::npos` is defined as the largest size_t value, so `pos2 < pos` would in particular imply `pos2 != std::string::npos`
Commit: d8cc2ec64516e4fa90028dd9fcc8be6511e0740c
https://github.com/wesnoth/wesnoth/commit/d8cc2ec64516e4fa90028dd9fcc8be6511e0740c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/lobby_data.cpp
Log Message:
-----------
MP Lobby: allow filtering by active mod names (fixes #2195)
Commit: 19d4ffc797370ea43f08760f089eb459cf655512
https://github.com/wesnoth/wesnoth/commit/19d4ffc797370ea43f08760f089eb459cf655512
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M README.md
Log Message:
-----------
Fixed our README license badge linking to its own icon
[ci skip]
*facepalm*
Commit: 533a534582f87d39a3f13662b271b10e5e43e676
https://github.com/wesnoth/wesnoth/commit/533a534582f87d39a3f13662b271b10e5e43e676
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/formula/function_table.cpp
M src/formula/function.hpp
Log Message:
-----------
Remove the useless (and dangerous) semicolons from the WFL macro definitions
Commit: e92cec3a472b4e96feedc4977f45753d4162fe99
https://github.com/wesnoth/wesnoth/commit/e92cec3a472b4e96feedc4977f45753d4162fe99
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg
Log Message:
-----------
TSG S03: Have elves be on their own side when appearing
Commit: 3a9b2616c54476f9b8c298b093fa0e5dc9b15ee8
https://github.com/wesnoth/wesnoth/commit/3a9b2616c54476f9b8c298b093fa0e5dc9b15ee8
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg
M data/campaigns/The_South_Guard/scenarios/08b_The_Tides_of_War.cfg
Log Message:
-----------
TSG: Remove redundant title in unit names
Commit: c4872976e466d9f7aa102628b498a444adf5809d
https://github.com/wesnoth/wesnoth/commit/c4872976e466d9f7aa102628b498a444adf5809d
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg
Log Message:
-----------
TSG S07b: Make it explict when the defenses of Westin are strengthened
Commit: 70bed711257fbafe06355865958babc953a24604
https://github.com/wesnoth/wesnoth/commit/70bed711257fbafe06355865958babc953a24604
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg
Log Message:
-----------
TSG S07b: Fix erroneous dialog
Commit: f472b92bad1cfc1192b34cef175085e38856d3fd
https://github.com/wesnoth/wesnoth/commit/f472b92bad1cfc1192b34cef175085e38856d3fd
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/maps/07b_Pebbles_in_the_Flood.map
Log Message:
-----------
TSG S07b: Have undead use encampments instead of castle
Fits the story better.
Commit: 433c0ed43b95bae0eaae63aa503a297e5cca8a23
https://github.com/wesnoth/wesnoth/commit/433c0ed43b95bae0eaae63aa503a297e5cca8a23
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg
Log Message:
-----------
TSG S07b: Prevent Mal M'Brin from leaving his keep
With this, the player should be unable to reach and attack him.
Commit: f1dcc7339b16d3fa708d28e409ab2cab0b864098
https://github.com/wesnoth/wesnoth/commit/f1dcc7339b16d3fa708d28e409ab2cab0b864098
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/macros/_initial.cfg
M data/gui/window/lobby_main.cfg
M data/gui/window/mp_join_game.cfg
M data/gui/window/mp_staging.cfg
Log Message:
-----------
Revert "GUI2: removed GUI_FORCE_WIDGET_SIZE macro in favor of fixed_width/fixed_height keys"
This reverts commit 9f386ed563e84e355130a940be804d13bf5b3d9c.
fixed_width/fixed_height are broken and completely fail to block the
widget from growing.
Commit: 6f7819fdf6f236842d711974a6405b903c7ac678
https://github.com/wesnoth/wesnoth/commit/6f7819fdf6f236842d711974a6405b903c7ac678
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M data/gui/schema.cfg
M src/gui/core/window_builder.cpp
M src/gui/core/window_builder.hpp
M src/gui/widgets/widget.cpp
M src/gui/widgets/widget.hpp
M src/gui/widgets/window.hpp
Log Message:
-----------
Revert "GUI2: implemented fixed_width and fixed_height keys for all widgets"
This reverts commit 556331ac3f53f2fd58fd4e137cf86af71d5c064b.
Since the keys aren't working, the implementation shouldn't be in the
Git repository. Otherwise some poor soul will attempt to use them and
face additional work afterwards.
Commit: 4d8d5c005b4896d955f3a3ca9ae397087397f991
https://github.com/wesnoth/wesnoth/commit/4d8d5c005b4896d955f3a3ca9ae397087397f991
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/size_lock.cpp
Log Message:
-----------
Fix #2153: crash in MP lobby chat with low horizontal window size
[size_lock] could cause layout_exception_width_modified while shrinking
the widget, and it didn't catch the exception. Now it does.
Commit: 4b28284ad75ae2cbad739e4cfeb178c8290e651d
https://github.com/wesnoth/wesnoth/commit/4b28284ad75ae2cbad739e4cfeb178c8290e651d
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/gui/widget/chatbox.cfg
Log Message:
-----------
Chatbox tabs can no longer shrink vertically
Commit: b935b8c2d876cf4779735ac9f2851b7fa330d8fd
https://github.com/wesnoth/wesnoth/commit/b935b8c2d876cf4779735ac9f2851b7fa330d8fd
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
M src/game_initialization/create_engine.hpp
M src/game_initialization/depcheck.cpp
M src/gui/dialogs/multiplayer/mp_create_game.cpp
M src/gui/dialogs/multiplayer/mp_create_game.hpp
Log Message:
-----------
fix mp depckeck
just like in the gui1 version of mp create we just call a 'sync'
function whenever the user changed the selected era/scenario/mod.
Commit: 56791ee9bce26f933b263dd35c193dfd54b528ff
https://github.com/wesnoth/wesnoth/commit/56791ee9bce26f933b263dd35c193dfd54b528ff
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
M src/game_initialization/create_engine.hpp
M src/gui/dialogs/campaign_selection.cpp
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
small create_engine simplification
Commit: 7d253cfb3cd5d77bc1af159846f848a30aa210ed
https://github.com/wesnoth/wesnoth/commit/7d253cfb3cd5d77bc1af159846f848a30aa210ed
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
M src/gui/dialogs/multiplayer/mp_create_game.hpp
M src/gui/widgets/menu_button.cpp
M src/gui/widgets/menu_button.hpp
M src/gui/widgets/selectable_item.hpp
M src/gui/widgets/toggle_button.cpp
M src/gui/widgets/toggle_button.hpp
M src/gui/widgets/toggle_panel.cpp
M src/gui/widgets/toggle_panel.hpp
Log Message:
-----------
fix recrision in gui2 mp create depckeck
selectable::set_value now takes an optional fire_vent parmeter
also we fix a case where display_games_of_type always invoked a
on_game_select for the first element in the list before the correct
level was selected.
Commit: a64f2125be3553c09df1d5f6d0152fd4b00cd003
https://github.com/wesnoth/wesnoth/commit/a64f2125be3553c09df1d5f6d0152fd4b00cd003
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
M src/gui/dialogs/multiplayer/mp_create_game.hpp
Log Message:
-----------
fix mod_list/eras not found in mp create
Commit: 37c51f9700b7eed4d9fe00a1135f16e5506fd061
https://github.com/wesnoth/wesnoth/commit/37c51f9700b7eed4d9fe00a1135f16e5506fd061
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
fix unisgned comparision warning
Commit: 664a24db47ee92b537c504eb5c2d78f26036487c
https://github.com/wesnoth/wesnoth/commit/664a24db47ee92b537c504eb5c2d78f26036487c
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
mp create: add debug output
Commit: e5386bf3d8b840910fdecdd47737a6363e808a46
https://github.com/wesnoth/wesnoth/commit/e5386bf3d8b840910fdecdd47737a6363e808a46
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
fix ub in mp create
Commit: 98f3b9f9879df7d28018245c7a733bc20c432d76
https://github.com/wesnoth/wesnoth/commit/98f3b9f9879df7d28018245c7a733bc20c432d76
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
MP Create Game: some minor cleanup from recent changes
Commit: 207a7e8ba53ea419bb78795b323f6efc550b419a
https://github.com/wesnoth/wesnoth/commit/207a7e8ba53ea419bb78795b323f6efc550b419a
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/mp_create_game.cpp
Log Message:
-----------
MP Create Game: replaced a hack with a proper solution
Commit: 4d014b81d272d104ec074fdc7f70876223f5622c
https://github.com/wesnoth/wesnoth/commit/4d014b81d272d104ec074fdc7f70876223f5622c
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/utils/abilities.cfg
Log Message:
-----------
Don't break recall/traitless-recruit undo (Fixes #2196)
Commit: 5f432f246cd6cec139157ace1eef6a436b372aa1
https://github.com/wesnoth/wesnoth/commit/5f432f246cd6cec139157ace1eef6a436b372aa1
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider.cpp
Log Message:
-----------
add debug output on slider error.
Commit: 678fb7c690963240069ac83997bbd16212d7704c
https://github.com/wesnoth/wesnoth/commit/678fb7c690963240069ac83997bbd16212d7704c
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider.cpp
Log Message:
-----------
round instead of floor to fitting value in slider::set_value
Commit: e6149c2dcc21fc0ca1fa764aa2bfb16f43a13589
https://github.com/wesnoth/wesnoth/commit/e6149c2dcc21fc0ca1fa764aa2bfb16f43a13589
Author: gfgtdf <daniel.gfgtdf at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/slider.cpp
Log Message:
-----------
fix build
Commit: ff432fb69359f2d110fb1abc6003a8752765383d
https://github.com/wesnoth/wesnoth/commit/ff432fb69359f2d110fb1abc6003a8752765383d
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
M data/campaigns/Delfadors_Memoirs/utils/misc.cfg
Log Message:
-----------
DM S08: Use simpler way to keep leader on his keep
He won't attack, but that's not a big deal here.
Commit: f58e0afb3155e85d60d1ad14f676112761fea102
https://github.com/wesnoth/wesnoth/commit/f58e0afb3155e85d60d1ad14f676112761fea102
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/network_asio.cpp
M src/network_asio.hpp
Log Message:
-----------
Campaignd/Network Asio: formatting cleanup
Commit: 913f01257d8be9bb6fe50a27c2a5c78827a40c69
https://github.com/wesnoth/wesnoth/commit/913f01257d8be9bb6fe50a27c2a5c78827a40c69
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/network_asio.hpp
M src/wesnothd_connection.hpp
Log Message:
-----------
Only define BOOST_ASIO_DISABLE_IOCP on Windows XP
That define allows boost::asio::ip::tcp::socket::cancel to work on Windows XP, but there's no
reason to have it enabled on other Windows versions.
Commit: 3878d79ef29a612ebc00a3cf237358a422e1effd
https://github.com/wesnoth/wesnoth/commit/3878d79ef29a612ebc00a3cf237358a422e1effd
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/network_asio.hpp
M src/wesnothd_connection.hpp
Log Message:
-----------
Fixup f626a2d (more expansive _WIN32_WINNT value check)
Just in case _WIN32_WINNT doesn't exactly match _WIN32_WINNT_WINXP (0x0501) when building.
Commit: 0251729ca25c2ac8a7158bba139fce6783690d60
https://github.com/wesnoth/wesnoth/commit/0251729ca25c2ac8a7158bba139fce6783690d60
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .gitignore
Log Message:
-----------
Git: do NOT ignore any MO translations in the po folder.
PR #1725 moved the compiled translations from the translations directory to the po directory.
I would have noticed sooner if Git had not been told to ignore virtually all MO files.
Commit: 781f93a9c91b3847b0c4cf4edafca7804dd4563a
https://github.com/wesnoth/wesnoth/commit/781f93a9c91b3847b0c4cf4edafca7804dd4563a
Author: David Seifert <soap at gentoo.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
Bring back `LOCALEDIR`
* The current infrastructure relies on `LOCALEDIR`
in places beyond CMake, hence we need to keep
it for the time being.
Fixes #2211
Commit: 8d42848ce4b8477a8f92b00279d6a5e194c0e69b
https://github.com/wesnoth/wesnoth/commit/8d42848ce4b8477a8f92b00279d6a5e194c0e69b
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/contexts.cpp
M src/ai/contexts.hpp
M src/ai/formula/ai.cpp
M src/ai/formula/ai.hpp
M src/ai/formula/function_table.cpp
M src/formula/function.cpp
M src/formula/function_gamestate.cpp
Log Message:
-----------
Finish deploying DEFINE_WFL_FUNCTION macro
Commit: daee4ddc153145332d190aa4c8b74cf53945c9d2
https://github.com/wesnoth/wesnoth/commit/daee4ddc153145332d190aa4c8b74cf53945c9d2
Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/formula/function.cpp
Log Message:
-----------
Add string insert function for WFL
Commit: b5495b52236c242e57f1aa3dc78eb4a1d8c79aa4
https://github.com/wesnoth/wesnoth/commit/b5495b52236c242e57f1aa3dc78eb4a1d8c79aa4
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/formula/function.cpp
Log Message:
-----------
Fix misplaced parenthesis
Commit: 2a95442e792e7767d4bc39dce79d551f350f321a
https://github.com/wesnoth/wesnoth/commit/2a95442e792e7767d4bc39dce79d551f350f321a
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M utils/pofix.py
Log Message:
-----------
Update pofix.py
For HttT S20b change.
Commit: 1e1f8ca4c3f39a8b8228842eeee663ecb99c632a
https://github.com/wesnoth/wesnoth/commit/1e1f8ca4c3f39a8b8228842eeee663ecb99c632a
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
Log Message:
-----------
DM S19: Have either undead or Delfador be able to kill Iliah-Malal
Previously, there was temptation for players to ditch all of their
undead before leaving the land of the dead scenarios so they had
Delfador instead of the undead able to kill Iliah-Malal.
Commit: 13aa52278364f086ad7c375ecec0b91582fbfef1
https://github.com/wesnoth/wesnoth/commit/13aa52278364f086ad7c375ecec0b91582fbfef1
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
Log Message:
-----------
DM S19: Fix dialog
Commit: d335460ac4794d841c2b22c4aa220c88f749804d
https://github.com/wesnoth/wesnoth/commit/d335460ac4794d841c2b22c4aa220c88f749804d
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
Log Message:
-----------
Update changelogs
Commit: a64cc4f88cc76823ee73b351c40860c931ca403f
https://github.com/wesnoth/wesnoth/commit/a64cc4f88cc76823ee73b351c40860c931ca403f
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/commandline_options.cpp
Log Message:
-----------
Update --help text about FPS-related options
Commit: c7b87aba1ac94a440ed2bfb4aaaf1a3f06c85d8e
https://github.com/wesnoth/wesnoth/commit/c7b87aba1ac94a440ed2bfb4aaaf1a3f06c85d8e
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/wesnoth.cpp
Log Message:
-----------
Windows: if a CMD switch immediately exits, wait for an Enter press
Helpful if a developer is testing --help from Visual Studio, for example.
Commit: f47987ef286513d6592849bc189959c031726762
https://github.com/wesnoth/wesnoth/commit/f47987ef286513d6592849bc189959c031726762
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/units/filter.cpp
M src/units/filter.hpp
Log Message:
-----------
Out-of-line some functions to remove an include
Commit: 29df8055e7b1bb98ff749fd76a9bb285b04e88e5
https://github.com/wesnoth/wesnoth/commit/29df8055e7b1bb98ff749fd76a9bb285b04e88e5
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/default/recruitment.cpp
M src/ai/default/recruitment.hpp
Log Message:
-----------
Out-of-line a function to remove an include
Commit: aefdec1f3fb2a6551140f289d56e1cd79165bb75
https://github.com/wesnoth/wesnoth/commit/aefdec1f3fb2a6551140f289d56e1cd79165bb75
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/ai/formula/callable_objects.cpp
M src/ai/formula/candidates.cpp
M src/formula/callable_objects.cpp
M src/formula/callable_objects.hpp
M src/formula/function_gamestate.cpp
M src/scripting/lua_formula_bridge.cpp
M src/units/attack_type.cpp
Log Message:
-----------
Out-of-line and forward-declare to remove some includes
Commit: ec3e805bf38313f5ef65fdca4ffb1db4939c2653
https://github.com/wesnoth/wesnoth/commit/ec3e805bf38313f5ef65fdca4ffb1db4939c2653
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/undo_move_action.cpp
M src/actions/undo_move_action.hpp
Log Message:
-----------
Out-of-line a function to remove an include
Commit: e7a055ef1b6d6e7426c353b80e8463bb740eb54e
https://github.com/wesnoth/wesnoth/commit/e7a055ef1b6d6e7426c353b80e8463bb740eb54e
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/undo_recruit_action.cpp
M src/actions/undo_recruit_action.hpp
Log Message:
-----------
Out-of-line some functions to remove an include
Commit: 9396f93f00070aea5babe2515403a11669dd2038
https://github.com/wesnoth/wesnoth/commit/9396f93f00070aea5babe2515403a11669dd2038
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/undo_recall_action.cpp
M src/actions/undo_recall_action.hpp
Log Message:
-----------
Out-of-line some functions to remove an include
Commit: e40807bd08feb34fbe6a0bb4180226ece8e3f4e5
https://github.com/wesnoth/wesnoth/commit/e40807bd08feb34fbe6a0bb4180226ece8e3f4e5
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/undo_update_shroud_action.hpp
Log Message:
-----------
Remove unneeded include
Commit: 038aff051de563f6955b47a86e86e9062f1ef27c
https://github.com/wesnoth/wesnoth/commit/038aff051de563f6955b47a86e86e9062f1ef27c
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M source_lists/wesnoth
A src/units/make.cpp
A src/units/make.hpp
Log Message:
-----------
Add make_unit_ptr functions in separate header, to avoid inclusion of unit.hpp
Commit: 4eaa0e11b00b47534aedf9897a2f28cd358c7728
https://github.com/wesnoth/wesnoth/commit/4eaa0e11b00b47534aedf9897a2f28cd358c7728
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/undo_dismiss_action.cpp
M src/actions/undo_dismiss_action.hpp
Log Message:
-----------
Use make_unit_ptr to avoid a heavy include
Commit: 41597ba7ed5c061c401b927195f086e412c9a1d9
https://github.com/wesnoth/wesnoth/commit/41597ba7ed5c061c401b927195f086e412c9a1d9
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/units/make.cpp
M src/units/make.hpp
Log Message:
-----------
Fix compile errors from 669ba885ceecad83562dc2084057232f7c7fca0f
Sorry, you can't avoid including unit.hpp in all cases.
But, it's still a lot less than it used to be.
Commit: 67e18037ea11a7bbde75f7f115f0aa128dcc418d
https://github.com/wesnoth/wesnoth/commit/67e18037ea11a7bbde75f7f115f0aa128dcc418d
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/units/make.cpp
M src/units/make.hpp
Log Message:
-----------
Partially revert ca5144227707
Taking an argument, especially by reference, does not require a full type.
Including unit.hpp in make.hpp utterly defeats the point of make.hpp's existence.
Commit: b2ce35f32ab17a66587253d31b13f2451a72a03d
https://github.com/wesnoth/wesnoth/commit/b2ce35f32ab17a66587253d31b13f2451a72a03d
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/undo_dismiss_action.hpp
Log Message:
-----------
Remove unneeded include
Commit: ac08bb14847b390ebce5ca001d20c57474a45ce1
https://github.com/wesnoth/wesnoth/commit/ac08bb14847b390ebce5ca001d20c57474a45ce1
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
Log Message:
-----------
Update Visual Studio project
Commit: eaf441d9d9e6bab45538c9427bca41cf7bc06323
https://github.com/wesnoth/wesnoth/commit/eaf441d9d9e6bab45538c9427bca41cf7bc06323
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
M src/game_initialization/create_engine.hpp
M src/game_initialization/multiplayer.cpp
M src/game_initialization/singleplayer.cpp
M src/gui/dialogs/multiplayer/mp_create_game.cpp
M src/gui/dialogs/multiplayer/mp_create_game.hpp
Log Message:
-----------
MP Create Game: minor improvements
* The dialog now owns its own create_engine object. Previously, it was created immediately
adjacent to the dialog object and passed in by reference, which made no sense.
* The create_engine also no longer takes a CVideo reference and instead initializes its CVideo
member from the singleton.
* The 'Registered Users Only' toggle is now disabled if the host isn't registered themselves
(fixes #2206)
* The above setting, along with Observers, Strict Sync, and Game Password, are disabled in local
mode. These don't really make sense when not playing a networked game.
Commit: b75598c758e9c1b3f9ed83469bad1f47ddc8382c
https://github.com/wesnoth/wesnoth/commit/b75598c758e9c1b3f9ed83469bad1f47ddc8382c
Author: Wedge009 <wedge009 at wedge009.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj.filters
Log Message:
-----------
Tidy recent additions.
[ci skip]
Commit: 56f2efb77d47095bebdb7ef20a68395f4aa11d65
https://github.com/wesnoth/wesnoth/commit/56f2efb77d47095bebdb7ef20a68395f4aa11d65
Author: Wedge009 <wedge009 at wedge009.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
Log Message:
-----------
Add missing configuration for Release compilation.
[ci skip]
Commit: 382a03af043770e8b513fd8d2502e0fd4628f07d
https://github.com/wesnoth/wesnoth/commit/382a03af043770e8b513fd8d2502e0fd4628f07d
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/SConscript
Log Message:
-----------
Fix the scons Wesnoth Windows executable icon.
Commit: 49a81c29f709098468050ae104ca088b02a99a3f
https://github.com/wesnoth/wesnoth/commit/49a81c29f709098468050ae104ca088b02a99a3f
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/SConscript
Log Message:
-----------
Add explanation comment.
Commit: 50ff5a126f7a9157b19817aba146e6e510c4a168
https://github.com/wesnoth/wesnoth/commit/50ff5a126f7a9157b19817aba146e6e510c4a168
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/filesystem_boost.cpp
Log Message:
-----------
Fix build with TDM-GCC
@newfrenchy83 said that the build is failing:
https://github.com/wesnoth/wesnoth/commit/37225d24eaa52183f897e223dc3847bf89c89282#commitcomment-25629052
It looks like TDM-GCC uses Windows XP development headers, unfortunately.
However, the problem is easy to work around by simply #defining the missing
value ourselves. We should consider dropping TDM-GCC support after the 1.14
release, though.
Commit: 74558cc5e49b80a61d2c3cfa148813d48ad40e3d
https://github.com/wesnoth/wesnoth/commit/74558cc5e49b80a61d2c3cfa148813d48ad40e3d
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/integer_selector.hpp
M src/gui/widgets/toggle_panel.hpp
Log Message:
-----------
Fix MSVC compiler warning about overriding a function
Visual Studio 2013 omits a warning if a parameter is const-qualified in the
original function but not the overriding one (or the reverse).
Commit: 2c7b08e45441dbceeb9bf2ec33e70a43b9180e53
https://github.com/wesnoth/wesnoth/commit/2c7b08e45441dbceeb9bf2ec33e70a43b9180e53
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
M src/CMakeLists.txt
M src/SConscript
Log Message:
-----------
Have scons and cmake link against same static libraries.
Commit: 0baa4911f70415fe6296f062fd90620f039830c0
https://github.com/wesnoth/wesnoth/commit/0baa4911f70415fe6296f062fd90620f039830c0
Author: lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/halo.cpp
Log Message:
-----------
Fix MSVC variable hides variable warning
Commit: cd01715b9ac70ce26775c1e125fe0431c98f3b6e
https://github.com/wesnoth/wesnoth/commit/cd01715b9ac70ce26775c1e125fe0431c98f3b6e
Author: David Seifert <soap at gentoo.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M doc/man/CMakeLists.txt
M doc/manual/CMakeLists.txt
M packaging/systemd/wesnothd.service.in
M po/CMakeLists.txt
M src/CMakeLists.txt
Log Message:
-----------
Use GNUInstallDirs to specify directories
* GNUInstallDirs is the only Kitware-supported
way to change the default directories. Most
distributions have hooks for changing these
directories, which makes integrating wesnoth
easier and more consistent with the rest of
the CMake ecosystem.
* Make build system perfectly out-of-source
compatible. The build system should never
touch files in the source tree.
Commit: 1982e196f3c3f71935921926a84e60382bc40347
https://github.com/wesnoth/wesnoth/commit/1982e196f3c3f71935921926a84e60382bc40347
Author: David Seifert <soap at gentoo.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
Update changelog
* Detail the `GNUInstallDirs` changes
* Non-Windows builds now use the absolute path for all
data paths. This is less brittle, as relative path
lookup in Unix always depends on the current value of
the PWD environmental variable.
Commit: 73bb615d08992f5d2f4fad32b05136ff31a622ef
https://github.com/wesnoth/wesnoth/commit/73bb615d08992f5d2f4fad32b05136ff31a622ef
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/advancement.cpp
M src/addon/client.cpp
M src/addon/manager_ui.cpp
M src/editor/action/mouse/mouse_action_map_label.cpp
M src/editor/controller/editor_controller.cpp
M src/editor/map/context_manager.cpp
M src/editor/palette/location_palette.cpp
M src/formula/debugger.cpp
M src/game_config_manager.cpp
M src/game_events/action_wml.cpp
M src/game_initialization/create_engine.cpp
M src/game_initialization/depcheck.cpp
M src/game_initialization/multiplayer.cpp
M src/game_initialization/multiplayer.hpp
M src/game_initialization/playcampaign.cpp
M src/game_initialization/singleplayer.cpp
M src/game_initialization/singleplayer.hpp
M src/game_launcher.cpp
M src/generators/default_map_generator.cpp
M src/gui/core/window_builder.cpp
M src/gui/core/window_builder.hpp
M src/gui/dialogs/addon/manager.cpp
M src/gui/dialogs/advanced_graphics_options.hpp
M src/gui/dialogs/attack_predictions.hpp
M src/gui/dialogs/edit_label.hpp
M src/gui/dialogs/edit_text.hpp
M src/gui/dialogs/editor/custom_tod.cpp
M src/gui/dialogs/editor/custom_tod.hpp
M src/gui/dialogs/editor/edit_label.hpp
M src/gui/dialogs/editor/edit_scenario.hpp
M src/gui/dialogs/editor/edit_side.hpp
M src/gui/dialogs/editor/generator_settings.hpp
M src/gui/dialogs/editor/new_map.hpp
M src/gui/dialogs/editor/resize_map.hpp
M src/gui/dialogs/end_credits.hpp
M src/gui/dialogs/file_dialog.cpp
M src/gui/dialogs/folder_create.hpp
M src/gui/dialogs/game_cache_options.cpp
M src/gui/dialogs/game_cache_options.hpp
M src/gui/dialogs/game_delete.hpp
M src/gui/dialogs/game_load.cpp
M src/gui/dialogs/game_load.hpp
M src/gui/dialogs/game_save.hpp
M src/gui/dialogs/game_stats.hpp
M src/gui/dialogs/game_version.hpp
M src/gui/dialogs/gamestate_inspector.cpp
M src/gui/dialogs/help_browser.hpp
M src/gui/dialogs/label_settings.cpp
M src/gui/dialogs/label_settings.hpp
M src/gui/dialogs/loading_screen.cpp
M src/gui/dialogs/log_settings.hpp
M src/gui/dialogs/lua_interpreter.cpp
M src/gui/dialogs/lua_interpreter.hpp
M src/gui/dialogs/message.cpp
M src/gui/dialogs/message.hpp
M src/gui/dialogs/modal_dialog.cpp
M src/gui/dialogs/modal_dialog.hpp
M src/gui/dialogs/modeless_dialog.cpp
M src/gui/dialogs/modeless_dialog.hpp
M src/gui/dialogs/multiplayer/lobby.cpp
M src/gui/dialogs/multiplayer/mp_alerts_options.hpp
M src/gui/dialogs/multiplayer/mp_connect.cpp
M src/gui/dialogs/multiplayer/mp_connect.hpp
M src/gui/dialogs/multiplayer/mp_create_game.cpp
M src/gui/dialogs/multiplayer/mp_host_game_prompt.hpp
M src/gui/dialogs/multiplayer/mp_join_game.cpp
M src/gui/dialogs/multiplayer/mp_join_game.hpp
M src/gui/dialogs/multiplayer/mp_join_game_password_prompt.hpp
M src/gui/dialogs/multiplayer/mp_staging.cpp
M src/gui/dialogs/multiplayer/mp_staging.hpp
M src/gui/dialogs/outro.hpp
M src/gui/dialogs/preferences_dialog.cpp
M src/gui/dialogs/preferences_dialog.hpp
M src/gui/dialogs/screenshot_notification.hpp
M src/gui/dialogs/select_orb_colors.hpp
M src/gui/dialogs/sp_options_configure.hpp
M src/gui/dialogs/statistics_dialog.hpp
M src/gui/dialogs/story_viewer.hpp
M src/gui/dialogs/terrain_layers.hpp
M src/gui/dialogs/title_screen.cpp
M src/gui/dialogs/title_screen.hpp
M src/gui/dialogs/tooltip.cpp
M src/gui/dialogs/tooltip.hpp
M src/gui/dialogs/transient_message.cpp
M src/gui/dialogs/transient_message.hpp
M src/gui/dialogs/unit_attack.cpp
M src/gui/dialogs/unit_list.cpp
M src/gui/dialogs/unit_list.hpp
M src/gui/dialogs/unit_recall.cpp
M src/gui/dialogs/wml_error.hpp
M src/gui/dialogs/wml_message.cpp
M src/gui/dialogs/wml_message.hpp
M src/gui/widgets/label.cpp
M src/gui/widgets/menu_button.cpp
M src/gui/widgets/multimenu_button.cpp
M src/gui/widgets/window.cpp
M src/gui/widgets/window.hpp
M src/help/help.cpp
M src/help/help_browser.cpp
M src/hotkey/command_executor.cpp
M src/hotkey/hotkey_handler_sp.cpp
M src/menu_events.cpp
M src/mouse_events.cpp
M src/play_controller.cpp
M src/playsingle_controller.cpp
M src/playturn.cpp
M src/preferences/display.cpp
M src/preferences/display.hpp
M src/quit_confirmation.cpp
M src/savegame.cpp
M src/scripting/game_lua_kernel.cpp
M src/scripting/lua_gui2.cpp
M src/scripting/lua_gui2.hpp
M src/scripting/lua_kernel_base.cpp
M src/scripting/lua_kernel_base.hpp
M src/synced_user_choice.cpp
M src/tests/gui/test_gui2.cpp
M src/wesnoth.cpp
M src/whiteboard/manager.cpp
M src/wml_exception.cpp
M src/wml_exception.hpp
Log Message:
-----------
Massive cleanup of GUI2 display/show and execute functions implementations and related CVideo arguments
This a two part commit. First:
----------------------------------------------------------------------------------------------------
Added and deployed two new helper macros for the standard implementations of the static execute
and display functions. I also made use of a variadic template in order greatly simplify code
maintenance. Now, even if the dialog's ctor parameters change, no one has to worry about updating
the associated execute/display functions (though of course, this only applies if the helper macros
are used). \o/
I did not deploy the macro in cases where there were multiple overloads or the functions did more
than just show their dialogs. I might add an additional __VA_ARGS_ parameter to the macros later.
Do note for the end_credits dialog I moved the default empty-string parameter from the display
function to the ctor.
Second:
----------------------------------------------------------------------------------------------------
Another change is that modal_dialog::show and modeless_dialog::show no longer take CVideo arguments.
Since the video argument couldn't be included in the parameter pack (maintaining the argument would
have meant making it the first one, which would be just as much work), and using CVideo::get_singleton
in the macros would require adding video.hpp includes in a whole bunch of files, I simply removed the
argument. I had been intending to do this for a while anyway.
This therefor also removes the CVideo argument from:
* All dialog display/execute functions.
* modal_dialog::show
* modal_dialog::build_window
* modeless_dialog::show
* modeless_dialog::build_window
* wml_exception::show
* gui2::show_message
* gui2::show_error_message
* gui2::show_transient_message
* gui2::show_transient_error_message
* gui2::show_wml_message
* gui2::build
* gui2::window::window
* gui2::dialogs::tip::show
* Various GUI2-related Lua functions. The video_dispatch helper was also removed.
* Any functions that took a CVideo argument for the sole purpose of passing it to one of the above.
Ya know, all these damn CVideo arguments didn't actually do anything, besides an occasional check to
CVideo::faked. At the end of the pipeline, they just got assigned to the video_ member of gui2::window.
Huge code bloat for nothing.
Commit: 677477de3665cfae83e0f3da680057e34fcb1b7c
https://github.com/wesnoth/wesnoth/commit/677477de3665cfae83e0f3da680057e34fcb1b7c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/tests/gui/test_gui2.cpp
Log Message:
-----------
Update tests for 335ffa1b8100
Commit: 3ace71d0afa03d5dfe6105928f6b41dd5c0b381b
https://github.com/wesnoth/wesnoth/commit/3ace71d0afa03d5dfe6105928f6b41dd5c0b381b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/playcampaign.cpp
M src/game_launcher.cpp
M src/gui/dialogs/title_screen.cpp
M src/menu_events.cpp
M src/play_controller.cpp
M src/playmp_controller.cpp
M src/playsingle_controller.cpp
M src/savegame.cpp
M src/savegame.hpp
Log Message:
-----------
Fix Travis GCC warnings for f2b31ba082e1
This also removes a bunch of unnecessary CVideo arguments from various savegame functions that
emerged as I cleaned up the unused parameters. savegame::save_game did take a CVideo pointer
that did look like it was intended to be a sort of do-show-dialog flag, but since that parameter
was never passed as null, I removed it.
Commit: cdfe6897e2b3844e16aa0b13accd26f8e251c24c
https://github.com/wesnoth/wesnoth/commit/cdfe6897e2b3844e16aa0b13accd26f8e251c24c
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/chat_command_handler.cpp
M src/editor/controller/editor_controller.cpp
M src/game_config_manager.cpp
M src/game_initialization/multiplayer.cpp
M src/game_launcher.cpp
M src/gui/dialogs/loading_screen.cpp
M src/gui/dialogs/loading_screen.hpp
M src/gui/dialogs/preferences_dialog.cpp
M src/gui/dialogs/preferences_dialog.hpp
M src/menu_events.cpp
M src/play_controller.cpp
M src/wesnoth.cpp
M src/wesnothd_connection.cpp
Log Message:
-----------
Dropped CVideo parameter from loading screen and prefs display functions (missed in f2b31ba)
I had left the former alone in the above commit since I thought it might be worth keeping for the
faked() call, but that's not really a great reason.
As for the latter, I didn't realize the CVideo argument wasn't really even needed. I didn't even
need to replace it with a get_singleton() call since the resolution list is updated by set_resolution_list
before it's used.
Commit: e3f4a59d793929fef62c636e9160d620a00eeef3
https://github.com/wesnoth/wesnoth/commit/e3f4a59d793929fef62c636e9160d620a00eeef3
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/display.cpp
M src/display.hpp
M src/editor/controller/editor_controller.cpp
M src/editor/controller/editor_controller.hpp
M src/editor/editor_display.cpp
M src/editor/editor_display.hpp
M src/editor/editor_main.cpp
M src/editor/editor_main.hpp
M src/game_display.cpp
M src/game_display.hpp
M src/game_initialization/multiplayer.cpp
M src/game_initialization/multiplayer.hpp
M src/game_initialization/playcampaign.cpp
M src/game_initialization/playcampaign.hpp
M src/game_launcher.cpp
M src/play_controller.cpp
M src/play_controller.hpp
M src/playmp_controller.cpp
M src/playmp_controller.hpp
M src/playsingle_controller.cpp
M src/playsingle_controller.hpp
M src/tooltips.cpp
M src/tooltips.hpp
Log Message:
-----------
Cleaned up the mess of CVideo references passed around the game initialization process
Essentially, we had CVideo arguments being passed down this chain:
- game_launcher
- free-standing MP initialization functions
- campaign_controller
- playsingle_controller/playmp_controller
- play_controller
- game_display
- display
And likewise down through
- game_launcher
- editor_controller
- editor_display
- display
With only a minimal number of actual calls along the way. :| There were maybe... two remaining?
This removes the CVideo arguments and class members from both chains (except of course, game_launcher.
That's where the "real" CVideo object lives).
The display class now initializes its CVideo reference from the singleton, which is also used in the
very few other places it's needed. I also replaced a check for a null video ptr in show_tooltip()
with a faked() check (see src/tooltips.cpp). That seems to make more sense, since CVideo is never
null now.
Commit: 322a6e3a2f84f26c68bc425122fa6b0cbb374898
https://github.com/wesnoth/wesnoth/commit/322a6e3a2f84f26c68bc425122fa6b0cbb374898
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/addon/client.cpp
M src/addon/client.hpp
M src/addon/manager_ui.cpp
M src/addon/manager_ui.hpp
M src/controller_base.hpp
M src/editor/editor_main.hpp
M src/game_config_manager.cpp
M src/game_config_manager.hpp
M src/game_initialization/create_engine.cpp
M src/game_initialization/create_engine.hpp
M src/game_initialization/depcheck.cpp
M src/game_initialization/depcheck.hpp
M src/game_initialization/multiplayer.hpp
M src/game_initialization/playcampaign.hpp
M src/game_launcher.cpp
M src/generators/map_create.hpp
M src/generators/map_generator.hpp
M src/gui/core/window_builder.hpp
M src/gui/dialogs/attack_predictions.hpp
M src/gui/dialogs/help_browser.hpp
M src/gui/dialogs/loading_screen.hpp
M src/gui/dialogs/lua_interpreter.cpp
M src/gui/dialogs/modal_dialog.hpp
M src/gui/dialogs/modeless_dialog.hpp
M src/gui/dialogs/multiplayer/lobby.cpp
M src/gui/dialogs/multiplayer/mp_create_game.cpp
M src/gui/dialogs/outro.hpp
M src/gui/dialogs/statistics_dialog.hpp
M src/gui/dialogs/terrain_layers.hpp
M src/gui/dialogs/title_screen.cpp
M src/gui/dialogs/tooltip.hpp
M src/hotkey/hotkey_item.hpp
M src/play_controller.cpp
M src/preferences/display.hpp
M src/savegame.cpp
M src/savegame.hpp
M src/scripting/application_lua_kernel.cpp
M src/scripting/application_lua_kernel.hpp
M src/scripting/game_lua_kernel.hpp
M src/scripting/lua_gui2.cpp
M src/scripting/lua_gui2.hpp
M src/scripting/lua_kernel_base.hpp
M src/wesnoth.cpp
M src/wml_exception.hpp
Log Message:
-----------
Cleaned up more unnecessary CVideo function arguments and class members
* Dropped unused CVideo class member references.
* Replaced the lone usecase of the CVideo member in loadgame with the singleton and removed said member.
* Removed CVideo references from a bunch of addon management functions.
* Cleaned up a *lot* of now-unnecessary forward CVideo declarations.
Commit: 1b93907fc0f2b464d92bfc91db935638b19981b1
https://github.com/wesnoth/wesnoth/commit/1b93907fc0f2b464d92bfc91db935638b19981b1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/multiplayer/lobby.cpp
Log Message:
-----------
Fixup b46a64b8ad7a (forgot to commit this bit)
Commit: 516a40e48c652efbab6eb725bfff559e56928be2
https://github.com/wesnoth/wesnoth/commit/516a40e48c652efbab6eb725bfff559e56928be2
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/advancement.cpp
M src/game_events/pump.cpp
M src/replay.cpp
Log Message:
-----------
Use CVideo::get_singleton() over resources::screen->video()
They point to the same thing, but it's more consistent to use the former.
Commit: 20616e375eeb71ad340d0cf1c1f7f4eb8cf410ee
https://github.com/wesnoth/wesnoth/commit/20616e375eeb71ad340d0cf1c1f7f4eb8cf410ee
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/tests/gui/test_gui2.cpp
M src/tests/test_mp_connect.cpp
M src/tests/utils/fake_display.cpp
Log Message:
-----------
Still _more_ CVideo fixes
Commit: 9d2fd55d974d2a6d0f14f3ffa3bb4247721a954b
https://github.com/wesnoth/wesnoth/commit/9d2fd55d974d2a6d0f14f3ffa3bb4247721a954b
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M po/CMakeLists.txt
Log Message:
-----------
Partially revert 321c350
Accidental revert of PR 2212 (whose commit is completely gone).
Commit: ae1442421894dce8eabebf638515e234d42746b7
https://github.com/wesnoth/wesnoth/commit/ae1442421894dce8eabebf638515e234d42746b7
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/window_builder.hpp
M src/gui/dialogs/modal_dialog.hpp
M src/gui/dialogs/transient_message.hpp
M src/gui/dialogs/wml_message.hpp
M src/wml_exception.hpp
Log Message:
-----------
Autodoc cleanup for CVideo mess
Commit: f1c64b008d2863474fedbe89c2718c2299c1fda7
https://github.com/wesnoth/wesnoth/commit/f1c64b008d2863474fedbe89c2718c2299c1fda7
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/video.cpp
M src/video.hpp
Log Message:
-----------
CVideo: formatting and doc update
Also renamed a few functions to use snake case or be a little more descriptive.
Commit: bf4e931631cb34d058621a32c549ab3a0310cd47
https://github.com/wesnoth/wesnoth/commit/bf4e931631cb34d058621a32c549ab3a0310cd47
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/controller_base.cpp
M src/desktop/notifications.cpp
M src/desktop/windows_tray_notification.cpp
M src/display.hpp
M src/sdl/rect.cpp
M src/sdl/window.cpp
M src/sdl/window.hpp
M src/video.cpp
M src/video.hpp
Log Message:
-----------
CVideo/Display: cleaned up/slightly refactored a few things
* display::w() and display::h() now simply forward to CVideo::getx() and gety() instead of querying
the underlying window object. This is a slight semantic change, since now these functions return
screen coordinates instead of pixels, but that's probably what we want in the long term anyway.
* sdl::window::get_flags() now returns the proper uint32_t instead of int
* Added a dedicated CVideo::window_has_flags function since testing window flags was the most common
use of the underlying sdl window outside the class.
* Made CVideo::set_window_mode private. This is an implementation detail and shouldn't be public.
* Removed BPP argument from CVideo::make_test_fake. It's never passed anything other than 32, and
we're long past the time when we care about window BPP.
* Removed sdl/window.hpp include from video.hpp. This was mostly only there to allow other area of
the code to call get_window()->get_flags() (and for display.hpp). There's no real reason for it to
be there anymore and was just making any modification to the sdl window header take ages.
Commit: a706d0b96cb8f6c094d794b4a45f2448f1fac77e
https://github.com/wesnoth/wesnoth/commit/a706d0b96cb8f6c094d794b4a45f2448f1fac77e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_display.cpp
M src/game_display.hpp
Log Message:
-----------
Game Display: removed unused create_dummy_display function
This was probably used before we had the fake_display_manager class.
Commit: 95857800d6a9c3dffde3720e027725cd03577e1f
https://github.com/wesnoth/wesnoth/commit/95857800d6a9c3dffde3720e027725cd03577e1f
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/font/pango/hyperlink.hpp
M src/font/text.cpp
M src/font/text.hpp
Log Message:
-----------
Rewrite the link detection code
The previous code sometimes produced invalid Pango markup.
Instead of attempting to parse Pango markup, simply scan for links in the
raw text and replace them in Pango markup. This way there is no way to
accidentally break the markup.
Commit: 3673c50b9a7aa5599d07b47b7cc26f1a4765a791
https://github.com/wesnoth/wesnoth/commit/3673c50b9a7aa5599d07b47b7cc26f1a4765a791
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/serialization/string_view.hpp
Log Message:
-----------
Attempt to fix build with GCC 4.8
Commit: 9b48d8ff3aebe1891224622637aa83d9ba794e81
https://github.com/wesnoth/wesnoth/commit/9b48d8ff3aebe1891224622637aa83d9ba794e81
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/images/terrain/off-map/alpha.png
M data/core/images/terrain/off-map/border.png
Log Message:
-----------
Fixed graphical artifacts appearing in Fake Map Border/Off Map terrains with SDL 2.0.6+ (fixes #2061)
[ci skip]
Something was screwy about these image's alpha. Normally when I remove an alpha channel in GIMP,
it shows up white. With these images, it showed up black. Maybe they had an embedded palette or
something, I don't know, but the problem is fixed.
Something must have changed in SDL 2.0.6 that caused this issue to appear. Not sure if anything
needs to be patched in our source code, though (but not likely)
Commit: 0a7b0850b6e6682c3c78df4211385c257a73d97e
https://github.com/wesnoth/wesnoth/commit/0a7b0850b6e6682c3c78df4211385c257a73d97e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/font/text.cpp
M src/sdl/utils.cpp
M src/video.cpp
Log Message:
-----------
Made use of SDL_CreateRGBSurfaceWithFormat* on SDL 2.0.6+
These functions were introduced in 2.0.5, but a packaging error meant they weren't properly
included in the VS libs for that release. So I set the minimum to 2.0.6. Not sure if we want
to leave the fallbacks for the other versions or bump the minimum to 2.0.6.
Commit: 41d1fe252a04fb297b40143e79843b2645d5392b
https://github.com/wesnoth/wesnoth/commit/41d1fe252a04fb297b40143e79843b2645d5392b
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/chat_command_handler.cpp
M src/game_initialization/create_engine.cpp
M src/game_initialization/multiplayer.cpp
M src/generators/default_map_generator.cpp
M src/gui/dialogs/campaign_selection.cpp
M src/gui/dialogs/game_cache_options.cpp
M src/gui/dialogs/multiplayer/mp_connect.cpp
M src/gui/dialogs/multiplayer/mp_join_game.cpp
M src/gui/dialogs/network_transmission.cpp
M src/scripting/lua_kernel_base.cpp
M src/sdl/utils.cpp
M src/wesnothd_connection.cpp
Log Message:
-----------
Cleaned up unnecessary video.hpp includes
Commit: 41bc43ac2603a7e796770089aa0ca8ce7cd6a646
https://github.com/wesnoth/wesnoth/commit/41bc43ac2603a7e796770089aa0ca8ce7cd6a646
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/pathfind/pathfind.cpp
Log Message:
-----------
Remove negative index use-case
Commit: 53c77231f344144ced02cdff6725da1518cf958d
https://github.com/wesnoth/wesnoth/commit/53c77231f344144ced02cdff6725da1518cf958d
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/pathfind/pathfind.cpp
Log Message:
-----------
Assert that indexes are on board
Commit: 3131ae25c40cf6862cfe4149d9137fa7d2f26698
https://github.com/wesnoth/wesnoth/commit/3131ae25c40cf6862cfe4149d9137fa7d2f26698
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/pathfind/pathfind.cpp
Log Message:
-----------
Make check earlier
Commit: 9d3c8c3b862405d8d40abb46ab61ebb0cd58e5bf
https://github.com/wesnoth/wesnoth/commit/9d3c8c3b862405d8d40abb46ab61ebb0cd58e5bf
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/pathfind/pathfind.cpp
Log Message:
-----------
Convert indexes to unsigned
This should assure coverity that no negative indexes will be used.
Commit: ca9e7c9f1d1ecbba9e6f438e6f1d7e4a37f097d1
https://github.com/wesnoth/wesnoth/commit/ca9e7c9f1d1ecbba9e6f438e6f1d7e4a37f097d1
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/grid.hpp
M src/hotkey/hotkey_command.cpp
M src/hotkey/hotkey_command.hpp
Log Message:
-----------
Hotkeys: cleanup and simplification of hotkey_command list
* Used an std::array instead of C array for hotkey_list_.
* Used an std::vector instead of boost::ptr_array for known_hotkeys.
* Made hotkey_command non-copyable and movable in order to avoid hundreds of copies.
* Added a hotkey_command ctor that takes a hotkey_command_temp reference.
* Hopefully prevent some reallocations by reserving an appropriate amount of memory for known_hotkeys
before filling it up.
* Search from the end of know_hotkeys when calling remove_wml_hotkey(). This avoids traversing the almost
200 vector members that likely will not match.
* Deployed auto/range-for.
* For some reason I needed to add a <cassert> include to gui2/widgets/grid.hpp.
Commit: 603c75a981577ae6f5f49885463347d15a9d53fe
https://github.com/wesnoth/wesnoth/commit/603c75a981577ae6f5f49885463347d15a9d53fe
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
Remove -rdynamic from the linker.
Commit: 732bd7d887bc1167efd931dae6384ca5b31ee8e1
https://github.com/wesnoth/wesnoth/commit/732bd7d887bc1167efd931dae6384ca5b31ee8e1
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/hotkey/hotkey_command.hpp
Log Message:
-----------
Make hotkeys copyable again
There is barely any point in moving hotkeys because the command is the only
member variable that's both 1) movable and 2) faster to move than copy. In
2cc3f99651c9de13eb36ab0c490996a8dd47e50e, @Vultraz talked about "avoiding hundreds of copies", but
moving isn't necessarily any faster than copying. Seriously, making hotkeys
noncopyable was just a premature and obviously unprofiled optimization.
Besides, this also fixes build on Visual Studio 2013.
Commit: f22fc349b9ccab79943bc4ca67313c385933c322
https://github.com/wesnoth/wesnoth/commit/f22fc349b9ccab79943bc4ca67313c385933c322
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/wesnothd_connection.cpp
M src/wesnothd_connection.hpp
Log Message:
-----------
Wesnothd Connection: formatting cleanup
Commit: c9b1d15ebe7aaa05ccb62cc4bbb5b47fd784ef62
https://github.com/wesnoth/wesnoth/commit/c9b1d15ebe7aaa05ccb62cc4bbb5b47fd784ef62
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/serialization/string_view.hpp
Log Message:
-----------
Bump minimum boost version for external string_view
Commit: 37faf73182471eff0f661835f3cad3e104eab339
https://github.com/wesnoth/wesnoth/commit/37faf73182471eff0f661835f3cad3e104eab339
Author: Alexander van Gessel <ai0867 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/serialization/string_view.hpp
Log Message:
-----------
>= 1.64, not > 1.64
Commit: ee2c1a546217c2f421d3c4b88ffdd86bb34a0aa7
https://github.com/wesnoth/wesnoth/commit/ee2c1a546217c2f421d3c4b88ffdd86bb34a0aa7
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Secrets_of_the_Ancients/utils/sota-utils.cfg
Log Message:
-----------
SotA: Fix and improve freeze/thaw unit implementation
Bug was that when a unit was thawed, mouse over in unit sidebar would show
incorrect movement costs (all 1's).
New implementation properly uses {UNREACHABLE} and makes use of the now
available [remove_object] tag.
Commit: 3ebddc3046317f58eb5d994ddbbdb2d1a86a8da2
https://github.com/wesnoth/wesnoth/commit/3ebddc3046317f58eb5d994ddbbdb2d1a86a8da2
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/lua/wml/objectives.lua
Log Message:
-----------
WML: Add [show_if] usage in [objectives] subtag [gold_carryover]
Commit: 3a717566691124433d7dd60ed725cb5c2d552344
https://github.com/wesnoth/wesnoth/commit/3a717566691124433d7dd60ed725cb5c2d552344
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
Log Message:
-----------
update changelog
Commit: de9f234369c8a7f7e6fb6e9f5d915c084183b3af
https://github.com/wesnoth/wesnoth/commit/de9f234369c8a7f7e6fb6e9f5d915c084183b3af
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/shroud_clearing_action.hpp
M src/filesystem_boost.cpp
M src/game_events/menu_item.hpp
M src/game_events/pump.cpp
M src/game_initialization/playcampaign.cpp
M src/gettext_boost.cpp
M src/gui/dialogs/game_load.cpp
M src/gui/dialogs/lua_interpreter.cpp
M src/playmp_controller.cpp
M src/playsingle_controller.cpp
M src/playturn.cpp
M src/replay.cpp
M src/replay.hpp
M src/scripting/game_lua_kernel.cpp
M src/server/game.cpp
M src/synced_checkup.hpp
M src/synced_commands.cpp
M src/synced_context.cpp
M src/synced_context.hpp
M src/synced_user_choice.cpp
M src/synced_user_choice.hpp
M src/syncmp_handler.cpp
M src/utils/make_enum.hpp
Log Message:
-----------
Fixed a bunch of log output and code comment typos
[ci skip]
Commit: 9148d979a67579a9dc39ffc3b45450e933b6b124
https://github.com/wesnoth/wesnoth/commit/9148d979a67579a9dc39ffc3b45450e933b6b124
Author: kallaballa <amir at viel-zu.org>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/play_controller.hpp
M src/playmp_controller.cpp
M src/playmp_controller.hpp
M src/playsingle_controller.cpp
Log Message:
-----------
replaced recieve with receive
Commit: a37177fc545373d28bee1ba85a3a11e97c659ca2
https://github.com/wesnoth/wesnoth/commit/a37177fc545373d28bee1ba85a3a11e97c659ca2
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/scripting/lua_kernel_base.cpp
Log Message:
-----------
Fix wesnoth.print
Pass each parameter through Lua tostring() to convert to strings. This also allows meta-method tostring on userdata.
This aligns the operation of wesnoth print() to be closer to what a Lua programmer would expect from the normal Lua print() which is not available.
Closes Issue #2236
Commit: 983518b8728c3814d4a136af8fe4ddfc273c0487
https://github.com/wesnoth/wesnoth/commit/983518b8728c3814d4a136af8fe4ddfc273c0487
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
Fix typos in ad01dbd404e092e258fece5d1ad473fea1717d12
Commit: 539c0e7cbd4a7f544b57faf4988413f8937a6f26
https://github.com/wesnoth/wesnoth/commit/539c0e7cbd4a7f544b57faf4988413f8937a6f26
Author: Nils Kneuper <crazy-ivanovic at gmx.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M utils/pofix.py
Log Message:
-----------
fixed syntax error in pofix and "problem"
note: please do only enter "Part of the string", not the full strings.
The text in the po files is broken into parts and full strings, with
missing newlines, will not cause matches for the string.
Commit: 59ad1acceca2679287ad01239ce0b99c02408e6a
https://github.com/wesnoth/wesnoth/commit/59ad1acceca2679287ad01239ce0b99c02408e6a
Author: Nils Kneuper <crazy-ivanovic at gmx.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
M po/wesnoth-ai/es.po
M po/wesnoth-aoi/es.po
M po/wesnoth-dm/es.po
M po/wesnoth-dw/es.po
M po/wesnoth-httt/es.po
M po/wesnoth-lib/es.po
M po/wesnoth-manpages/es.po
M po/wesnoth-sof/es.po
M po/wesnoth-sota/es.po
M po/wesnoth-tb/es.po
M po/wesnoth-trow/es.po
M po/wesnoth-tsg/es.po
M po/wesnoth-tutorial/es.po
M po/wesnoth-units/es.po
M po/wesnoth-utbs/es.po
M po/wesnoth/es.po
Log Message:
-----------
updated Spanish translation
Commit: 23fcec54fa79f0fc0fd894f8f20e9006788dd534
https://github.com/wesnoth/wesnoth/commit/23fcec54fa79f0fc0fd894f8f20e9006788dd534
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/mp_game_utils.cpp
Log Message:
-----------
MP Game Utils: formatting and minor code cleanup
Commit: 2cbba7e13327c4d339fcae3f1ab87cbed722ec38
https://github.com/wesnoth/wesnoth/commit/2cbba7e13327c4d339fcae3f1ab87cbed722ec38
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
M src/game_initialization/mp_game_utils.cpp
M src/game_initialization/singleplayer.cpp
M src/game_launcher.cpp
M src/mp_game_settings.cpp
M src/mp_game_settings.hpp
M src/savegame.cpp
Log Message:
-----------
MP Game Settings: removed show_connect member
Early in the 1.13 development cycle there used to be an option to show the mp_connect screen
(now mp_staging) before starting an SP campaign. That was scrapped and the only code that used
it (in the SP initialization process) commented it out. Since we're not going to restore it,
might as well remove this flag.
Also removes the one instance remaining of a "show_configure" flag. Pretty sure this might have
also been a relic from the same time as show_connect, but it looks like it was since removed.
SP now has a dedicated screen for configuring active modifications in SP, which was the only
reason to show the configure dialog anyway (plus the mp create and configure screens were combined
later in 1.13 anyway).
Commit: b53b69e2307aa013eccb627fc095aecb348d8fff
https://github.com/wesnoth/wesnoth/commit/b53b69e2307aa013eccb627fc095aecb348d8fff
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/singleplayer.cpp
M src/game_initialization/singleplayer.hpp
M src/game_launcher.cpp
Log Message:
-----------
Cleaned up SP initialization function parameters
As of f4584b6b722a9 the game_config isn't needed in SP initialization anymore, and
enter_connect_mode can be made to return void.
Commit: 6e401eb9dacba634d3c80edb263f36ba47a76518
https://github.com/wesnoth/wesnoth/commit/6e401eb9dacba634d3c80edb263f36ba47a76518
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_initialization/create_engine.cpp
M src/game_initialization/create_engine.hpp
Log Message:
-----------
Create Engine: keep a member reference to the game config
Shortens the code slightly by avoiding continuously fetching it from the gc manager.
Commit: 033b69f9114bed73180f6aed8b564108eedbf147
https://github.com/wesnoth/wesnoth/commit/033b69f9114bed73180f6aed8b564108eedbf147
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/event/dispatcher.cpp
M src/gui/core/event/dispatcher.hpp
M src/gui/core/event/handler.cpp
M src/gui/dialogs/multiplayer/lobby.cpp
M src/gui/dialogs/title_screen.cpp
M src/gui/widgets/window.cpp
Log Message:
-----------
GUI2: changed hotkey callback return value to void
The bool retval was presumably meant to allow stopping execution of the main hotkey callbacks
if a local one was meant to take precedence. However, that wasn't used anywhere (all callbacks
were returning true) and the return value just meant we had to create lambdas or wrapper functions
everywhere. If necessary, we can re-add halt functionality later.
I did leave sdl_event_handler::hotkey_pressed returning a bool value, though, except now it signals
whether there was a valid dispatcher with which to execute the hotkey callback. This seemed reasonable
since we probably wouldn't want to continue if there were no dispatcher anyway, though this only has
any effect in the key_down handler.
Commit: 6615c2333f5898f6c0bd5e0f00ea7e95fa453a63
https://github.com/wesnoth/wesnoth/commit/6615c2333f5898f6c0bd5e0f00ea7e95fa453a63
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/title_screen.cpp
M src/gui/dialogs/title_screen.hpp
Log Message:
-----------
Title Screen: minor refactoring to button callback registering
* Removed window reference from callback function signature. Instead, bind (or capture)
window reference when register_button is called.
* Moved long callbacks to their own functions.
Commit: bdd0078d9e65875ac6918f5287f14fa4a626f8e4
https://github.com/wesnoth/wesnoth/commit/bdd0078d9e65875ac6918f5287f14fa4a626f8e4
Author: loonycyborg <loonycyborg at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/network_asio.cpp
M src/network_asio.hpp
Log Message:
-----------
Move asio streambufs in network_asio::connection into unique_ptrs
This is needed to properly reinitialize streambuf objects after cancel.
This prevents crash from issue #2203 but download after cancel still doesn't
work properly. More investigation needed.
Commit: 984674254d085684c265c93aaeda3aa42ff1ef68
https://github.com/wesnoth/wesnoth/commit/984674254d085684c265c93aaeda3aa42ff1ef68
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj
Log Message:
-----------
Update Xcode project
Commit: fb0531adbd967a0fecdaf66942292ef76022fdf4
https://github.com/wesnoth/wesnoth/commit/fb0531adbd967a0fecdaf66942292ef76022fdf4
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M .travis.yml
M CMakeLists.txt
M SConstruct
M src/CMakeLists.txt
M src/SConscript
Log Message:
-----------
Make strict builds consistent between scons and cmake
Commit: 5eacc5d548b2c0830f2ba3846692ca535ab02cd4
https://github.com/wesnoth/wesnoth/commit/5eacc5d548b2c0830f2ba3846692ca535ab02cd4
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/title_screen.cpp
Log Message:
-----------
Fix compile errors
Not sure where these came from. I'm assuming the changes to have CMake and SCons be equally strict.
If so, I'm amazed this was all which popped up!
Commit: b9f6eae175c84344b956806728081e585e428039
https://github.com/wesnoth/wesnoth/commit/b9f6eae175c84344b956806728081e585e428039
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M src/CMakeLists.txt
Log Message:
-----------
Remove MSVC support from cmake.
Commit: 1a02f5599209382e93e48ada651cf5d5267883cd
https://github.com/wesnoth/wesnoth/commit/1a02f5599209382e93e48ada651cf5d5267883cd
Author: pentarctagon <pentarctagon at tutamail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
Remove ENABLE_TOOLS and ENABLE_SDL2_TOOLS from cmake.
Commit: 41c476e06f67b18aa82d12c60f890af159d779f2
https://github.com/wesnoth/wesnoth/commit/41c476e06f67b18aa82d12c60f890af159d779f2
Author: doofus-01 <doofus-01 at users.noreply.github.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Under_the_Burning_Suns/images/units/monsters/demon-attack-1.png
M data/campaigns/Under_the_Burning_Suns/images/units/monsters/demon-attack-2.png
M data/campaigns/Under_the_Burning_Suns/images/units/monsters/demon-attack-3.png
M data/campaigns/Under_the_Burning_Suns/images/units/monsters/demon-defend.png
A data/campaigns/Under_the_Burning_Suns/images/units/monsters/demon-defend2.png
M data/campaigns/Under_the_Burning_Suns/images/units/monsters/demon.png
M data/campaigns/Under_the_Burning_Suns/units/monsters/Ixthala_Demon.cfg
Log Message:
-----------
updating Ixthala Demon unit (#2240)
Commit: 31ba17808d947ae6dd9ba369292e31e0dd1b61f9
https://github.com/wesnoth/wesnoth/commit/31ba17808d947ae6dd9ba369292e31e0dd1b61f9
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/playmp_controller.cpp
Log Message:
-----------
Stop explicitly redrawing in playmp_controller::play_human_turn()
Play_controller::play_slice() that the aforementioned function calls
redraws the game anyway. Calling redraw code from two places makes
profiling data harder to investigate.
Commit: e99c4c026d963592562a9a4d9aa2cde92ec6d71b
https://github.com/wesnoth/wesnoth/commit/e99c4c026d963592562a9a4d9aa2cde92ec6d71b
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
M src/display.cpp
M src/display.hpp
M src/sdl/surface.hpp
Log Message:
-----------
Miscellaneous optimizations in display::get_terrain_images()
* The vector of surfaces is now a class member variable instead of a local
variable. This saves a memory allocation every time the function is called
- which is worth it in this case, as the function is a major performance
bottleneck.
* The surfaces are now being moved instead of copied where possible. Turns
out that freeing a SDL surface is fairly expensive in performance-critical
code.
* Pointers to ToDs are now cached, reducing the number of calls to
get_time_of_day() from 37 to 7.
In a stress-test in Aetheryn's Mod at 50 % zoom, the FPS I was getting on
my PC (Intel Core i5-4430) increased from 16 to 23.
Commit: d006377048aacac31ca996d467e04a16f8ea2934
https://github.com/wesnoth/wesnoth/commit/d006377048aacac31ca996d467e04a16f8ea2934
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/event/dispatcher.cpp
M src/gui/core/event/dispatcher.hpp
M src/gui/core/event/handler.cpp
Log Message:
-----------
Fixed regression in 8bf95ce69a9bd59 (fixes #2245)
I thought changing what the return value of sdl_event_handler::hotkey_pressed meant wouldn't
cause any regressions, but apparently I was wrong. This made it so certain key-down events
were never fired at all, meaning the associated keys could never be entered in a textbox.
Pretty serious!
I've restored the bool retval to dispatcher::execute_hotkey. It will return false if there's
no associated hotkey function (like before), and true otherwise. sdl_event_handler::hotkey_pressed
has also been reverted to return the value of that function.
Commit: 41dccbff2e675777e86cadae05793c1a5079965d
https://github.com/wesnoth/wesnoth/commit/41dccbff2e675777e86cadae05793c1a5079965d
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_launcher.cpp
M src/gui/dialogs/multiplayer/lobby.cpp
M src/gui/dialogs/preferences_dialog.cpp
M src/gui/dialogs/preferences_dialog.hpp
M src/gui/dialogs/title_screen.cpp
M src/hotkey/command_executor.cpp
M src/preferences/general.cpp
M src/preferences/general.hpp
M src/sdl/point.hpp
M src/video.cpp
M src/video.hpp
Log Message:
-----------
Cleaned up various areas of code related to setting window resolution
* Added a point ctor that takes an SDL_Point.
* Added a toggle_fullscreen function to CVideo.
* Change all management of resolution data to use point instead of std::pair<int, int>. This
shortens the code considerably.
* Cleaned up preferences_dialog::set_resolution_list
* Made CVideo::set_resolution return a bool indicating whether resolution was changed.
* Swapped which of the two set_resolution overloads contains the main implementation.
* Moved the events::raise_resize_event() call when setting resolution to the CVideo function
where it should have always been (instead of the prefs dialog callback). This is a pretty
essential component and having it localized in one place meant any other area of the code
that might have called set_resolution wouldn't have it.
Commit: 776347748a3051053de3e943eb64372b0e3bda44
https://github.com/wesnoth/wesnoth/commit/776347748a3051053de3e943eb64372b0e3bda44
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/core/event/dispatcher.cpp
Log Message:
-----------
An year has less than 27 months
Commit: 3e0aacc6c848df8be63a3dc64410cff2353c885b
https://github.com/wesnoth/wesnoth/commit/3e0aacc6c848df8be63a3dc64410cff2353c885b
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/dialogs/preferences_dialog.cpp
Log Message:
-----------
Fix a copy-paste mistake
Commit: f969d3e917edb7f97f15585473691fbe9fda0994
https://github.com/wesnoth/wesnoth/commit/f969d3e917edb7f97f15585473691fbe9fda0994
Author: lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnothd.vcxproj
Log Message:
-----------
Update VC12 project for wesnothd
Drop the additional requirements for SDL2 libraries. Wesnothd no longer requires SDL2.
Commit: c032a14cfb3739924db2b7f3bfd403728e6a7a2f
https://github.com/wesnoth/wesnoth/commit/c032a14cfb3739924db2b7f3bfd403728e6a7a2f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M source_lists/boost_unit_tests
M src/tests/gui/test_save_dialog.cpp
M src/tests/test_formula_ai.cpp
R src/tests/utils/fake_event_source.cpp
R src/tests/utils/fake_event_source.hpp
R src/tests/utils/play_scenario.cpp
R src/tests/utils/play_scenario.hpp
Log Message:
-----------
Tests: removed empty files
These were emptied out when SDL 1.2 was removed (358bd1235f07d8d577). I seem to recall
someone saying it might be worth keeping them around in case something needed to be put
back, but it's been a year and a half. Not much worth in keeping empty files.
Commit: 4404739a6eb7d43f030c77c86b60efcad84450b6
https://github.com/wesnoth/wesnoth/commit/4404739a6eb7d43f030c77c86b60efcad84450b6
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M source_lists/boost_unit_tests
R src/tests/gui/test_save_dialog.cpp
Log Message:
-----------
Tests: removed another empty file I missed in c93aebb1debc
Its contents were also removed when SDL 1.2 was dropped.
Commit: 4c5528f5934c2d368f35393a5a0d84fc4b57a0c7
https://github.com/wesnoth/wesnoth/commit/4c5528f5934c2d368f35393a5a0d84fc4b57a0c7
Author: Severin Glöckner <severin.gloeckner at stud.htwk-leipzig.de>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M CMakeLists.txt
M SConstruct
M changelog
R icons/wesnoth-icon.png
R icons/wesnoth.desktop
A packaging/icons/hicolor/128x128/apps/wesnoth-icon.png
A packaging/icons/hicolor/16x16/apps/wesnoth-icon.png
A packaging/icons/hicolor/256x256/apps/wesnoth-icon.png
A packaging/icons/hicolor/32x32/apps/wesnoth-icon.png
A packaging/icons/hicolor/512x512/apps/wesnoth-icon.png
A packaging/icons/hicolor/64x64/apps/wesnoth-icon.png
A packaging/wesnoth.desktop
Log Message:
-----------
desktop_entry: include high resolution icons
wesnoth-optipng has been applied to the new images
Commit: 1467419d443e7ee8489837d19452ffad694d8dcb
https://github.com/wesnoth/wesnoth/commit/1467419d443e7ee8489837d19452ffad694d8dcb
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/hotkey/command_executor.cpp
M src/hotkey/command_executor.hpp
Log Message:
-----------
Hotkey/Command Executor: removed get_video() member in favor of singleton
Also removed CVideo reference passed to make_screenshot() and its argument function, since the
reference is only used in the one specific screenshot() function anyway.
Commit: 35377b2f67fc99fc35ed547f88fffae763b60ae0
https://github.com/wesnoth/wesnoth/commit/35377b2f67fc99fc35ed547f88fffae763b60ae0
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/display.cpp
M src/display.hpp
Log Message:
-----------
Display: one (hopefully) significant optimization and one minor one
Copying the blit_helper objects when adding them to the drawing buffer was expensive since
blit_helper contains a vector of surfaces. We definitely want to copy that as little as
possible.
Also used std::move when fetching fog/shroud images. This function apparently has little
overhead, but still nice to not make copies here.
Also made get_terrain_images return void (this is just minor cleanup, not an optimization).
No need for it to return a reference to a class member.
Commit: f31d3a3ae84f5763e87f198ca414ab40a384f448
https://github.com/wesnoth/wesnoth/commit/f31d3a3ae84f5763e87f198ca414ab40a384f448
Author: Jeffrey 'Sigurd' Westcoat <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/core/macros/items.cfg
Log Message:
-----------
Macros: Tweak sceptre damage for story reasons (#2220)
Sceptre (15x4) is now stronger than the uncut ruby of fire (14x4) for
regular mainline users Thursagan and Konard II. Level 3 Konrad & Li'sar
in HttT are still exceptional users of the sceptre (18x4 & 16x4).
>From discussions with zookeeper in irc.
Commit: c4216ed02c3aa2d1b8edf23f0f3230bd8be5c9d2
https://github.com/wesnoth/wesnoth/commit/c4216ed02c3aa2d1b8edf23f0f3230bd8be5c9d2
Author: mattsc <mattsc000 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/ai/micro_ais/engines/priority_target_engine.lua
Log Message:
-----------
Protect Unit Micro AI: fix typo/bug in AI aspect change
Commit: 68f08b96d4d025497451a3f7a49b5e2a2cc0e66e
https://github.com/wesnoth/wesnoth/commit/68f08b96d4d025497451a3f7a49b5e2a2cc0e66e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/actions/advancement.cpp
M src/actions/attack.cpp
M src/actions/move.cpp
M src/actions/undo.cpp
M src/actions/unit_creator.cpp
M src/editor/controller/editor_controller.cpp
M src/editor/map/context_manager.cpp
M src/game_display.cpp
M src/menu_events.cpp
M src/mouse_events.cpp
M src/mouse_handler_base.cpp
M src/play_controller.cpp
M src/playmp_controller.cpp
M src/playsingle_controller.cpp
M src/replay_controller.cpp
M src/units/udisplay.cpp
Log Message:
-----------
Cleaned up unnecessary drawing calls
After testing, it seems these calls to raise_draw_event and display/game_display::draw()
were unnecessary - or at least, became unnecessary at some point. One or two are definitely
still needed, but removing these doesn't seem to cause anything to to glitch out. Likely
explanation is anything that needs updating just gets updated either immediately or on the
next play_slice loop.
Commit: fb223cf2084c32c8d622b5d6808b417f3f594608
https://github.com/wesnoth/wesnoth/commit/fb223cf2084c32c8d622b5d6808b417f3f594608
Author: lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M packaging/windows/wesnoth.rc
M packaging/windows/wesnothd.rc
Log Message:
-----------
Fix copyright defect and add missing icon
Commit: 4fe3445beb5d897f4fa0c61e8dfc1f0bcc7ba2e9
https://github.com/wesnoth/wesnoth/commit/4fe3445beb5d897f4fa0c61e8dfc1f0bcc7ba2e9
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/gui/widgets/window.cpp
Log Message:
-----------
GUI2/Window: don't constantly send useless DRAW events to the queue
This is a small subset of a change made on accelerated_rendering. Essentially, since drawing
doesn't happen until events::pump is called, and that function also drops all but one DRAW
event from the queue, sending a DRAW event every 20 ms is just useless noise and excessive
CPU use.
There should be no change in the actual rate GUI2 dialogs are redrawn with this change.
Commit: 81a29b641e41b74406b807708de0dad536fd8857
https://github.com/wesnoth/wesnoth/commit/81a29b641e41b74406b807708de0dad536fd8857
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
Log Message:
-----------
DM S19: Rebalance scenario for a more exciting battle
1. Increases difficulty
2. Allows player and enemy to field more units
Commit: 4899fed172430595ed123d735bc10eaecc0fad7c
https://github.com/wesnoth/wesnoth/commit/4899fed172430595ed123d735bc10eaecc0fad7c
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg
Log Message:
-----------
DM S19: Fix carryover report
Commit: 5b4c9b20a01619ea86ae3aa4d1eed941b0207ee2
https://github.com/wesnoth/wesnoth/commit/5b4c9b20a01619ea86ae3aa4d1eed941b0207ee2
Author: sigurdfdragon <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M changelog
M players_changelog
Log Message:
-----------
Update changelogs
Commit: 836d5cf766fcab77df009263854c67c998f199f5
https://github.com/wesnoth/wesnoth/commit/836d5cf766fcab77df009263854c67c998f199f5
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/attack_prediction.cpp
Log Message:
-----------
Fix #2251: possible crash when AI invokes attack prediction
Commit: 394f0f50097560e78b16e51fbb14250f7a01d424
https://github.com/wesnoth/wesnoth/commit/394f0f50097560e78b16e51fbb14250f7a01d424
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_events/handlers.cpp
M src/game_events/handlers.hpp
M src/game_events/manager.cpp
M src/game_events/manager.hpp
M src/game_events/manager_impl.cpp
M src/game_events/manager_impl.hpp
M src/game_events/pump.cpp
R src/utils/smart_list.hpp
Log Message:
-----------
Game Events: refactored event handler storage
This throws out the custom smart_list class in favor of a plain std::list. It also greatly simplifies
a few things. First, event handlers no longer remove themselves from the main list in event_handlers.
Now they just flag themselves as disabled (which means they will never execute once marked) and cleaned
up later in a newly added cleanup stage. This means a handler no longer needs to keep its index in the
active handler vector.
This removal of reliance on indices also means I could add the aforementioned cleanup stage. With the
smart_list code, event handlers were never actually removed from the active vector, nor any weak_ptrs
pointing to them removed either. This wasn't exactly a problem, since the handlers were stored via
shared_ptrs which would then simply be null after one deleted itself. Still, it's cleaner to drop any
invalid ones (and unlockable weak_ptrs) from any relevant containers. I've opted to do this in
manager::execute_on_events. Seems a good enough place as any.
The net result of this is the code is much cleaner. We're able to get rid of a bunch of unnecessary
feelers into various classes. This also makes the manager::iteration dereference code a lot easier
to understand. There certainly could be further refactoring, but I think this is a good start.
Commit: 9f876f1bdd6785465e9968e9240d0edca9c9e9d8
https://github.com/wesnoth/wesnoth/commit/9f876f1bdd6785465e9968e9240d0edca9c9e9d8
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_events/handlers.cpp
Log Message:
-----------
Minor cleanup to 2045b6739e0f4e544
[ci skip]
Commit: 57ed3dae9371e279d1850be21a2414ccfcee8faa
https://github.com/wesnoth/wesnoth/commit/57ed3dae9371e279d1850be21a2414ccfcee8faa
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/font/text.cpp
M src/serialization/string_view.hpp
Log Message:
-----------
Eliminate use of string_view::at
We only use it in once place. At that point we can guarantee we stay in-bounds. So there is no need to use at() to check we remain in-bounds.
This eliminates a warning when building Debug for Windows (quieting Appveyor).
AI0886 had a similar issue building using GCC 6.3 on Boost 1.62
Reverting ca03818fa897a558d9ad5d9c3729404f5959029f and 0cbab6eeedff676a57191440c0b2b89b923bfaad since this changeset should correct both issues.
Commit: 46b8c5967d47632d1def31311bf56f310debd982
https://github.com/wesnoth/wesnoth/commit/46b8c5967d47632d1def31311bf56f310debd982
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M join.lua
Log Message:
-----------
Fix mp_tests
Don't know why it's not working but I can get it working by not performing the chat message.
Commit: 28a562d451c96660d60d7a2ba004e0a63d39236a
https://github.com/wesnoth/wesnoth/commit/28a562d451c96660d60d7a2ba004e0a63d39236a
Author: Jyrki Vesterinen <sandgtx at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M utils/travis/mp_test_executor.sh
Log Message:
-----------
Revert ignoring MP test failures due to video init failure (2e5c5da0036be2e68b42e70f3153b799236b5b69)
This code ended up ignoring *all* MP test failures, in particular the one
fixed in commit 11d7b9f0cfe29ab6d6b5829c8e337b7cb67eeb18.
I'd test the code and fix it if I could, but unfortunately I can no longer
develop on GNU/Linux because of PC issues (which I mentioned in Discord).
Therefore I'm just reverting the entire change.
Commit: 716e469b7b5a6d40e6446574bdeeb03d7c2dbae2
https://github.com/wesnoth/wesnoth/commit/716e469b7b5a6d40e6446574bdeeb03d7c2dbae2
Author: Jeffrey 'Sigurd' Westcoat <jjwcoat at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg
Log Message:
-----------
HttT S17: Fix lava issues (#2249)
1. Undo now works again in the scenario.
2. Lava now works again.
3. Triggering on a moveto event was not good, as several shorter moves
would make rate of lava grow much faster than fewer longer moves.
Commit: 9ddcd58c9915fc5c95f553519f346ee58ad484df
https://github.com/wesnoth/wesnoth/commit/9ddcd58c9915fc5c95f553519f346ee58ad484df
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/scenarios/01_Saving_Parthyn.cfg
Log Message:
-----------
DiD S01 Fix bug: Allow undo
Be consistent and allow undo on both sign posts.
Commit: 0af4f608d3cb3ebf8049acda5aa9361ee6a36d66
https://github.com/wesnoth/wesnoth/commit/0af4f608d3cb3ebf8049acda5aa9361ee6a36d66
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/scenarios/02_Peaceful_Valley.cfg
Log Message:
-----------
DiD S02 Cannot undo
The first moveto to 15,11 also causes a capture, which sets some variables and creates some units. So allow_undo has no effect.
Commit: f38f4392e4211e7b7b79deb6f306ffca1c938cc8
https://github.com/wesnoth/wesnoth/commit/f38f4392e4211e7b7b79deb6f306ffca1c938cc8
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/scenarios/02_Peaceful_Valley.cfg
Log Message:
-----------
DiD Remove variable artifacts
Commit: 4e756185f27db8af2a995a9a4230cf7b09297544
https://github.com/wesnoth/wesnoth/commit/4e756185f27db8af2a995a9a4230cf7b09297544
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/scenarios/02_Peaceful_Valley.cfg
Log Message:
-----------
DiD S02 Fix bug: Swamp only
Use a terrain filter to avoid triggering the Ghouls when ending in forest instead of swamp.
Commit: 442284de2a364d4f485469ca759f0183bf42981b
https://github.com/wesnoth/wesnoth/commit/442284de2a364d4f485469ca759f0183bf42981b
Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M data/campaigns/Descent_Into_Darkness/scenarios/04_Beginning_of_the_Revenge.cfg
Log Message:
-----------
DiD S04 Todo: Add snow
Lifted code from HttT to add snow coverage.
Commit: 64224d5072630e7843cb22ad7dc688620dc4eb3f
https://github.com/wesnoth/wesnoth/commit/64224d5072630e7843cb22ad7dc688620dc4eb3f
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_events/handlers.cpp
M src/game_events/manager_impl.cpp
Log Message:
-----------
Game Events: fixed a few oversights in 056d7ac8f88c
* Fixed assertion failure when removing single-use custom events. Not actually something
broken, I just forgot to add a "not already disabled" check when doing so since I added
that assertion in event_handler::disable.
* Added a message to the aforementioned assertion.
* Ensure handler cleanup actually happens when removing custom events.
* Account for events with multiple names in cleanup.
Commit: e3c7219a66d5e9070ea655ad0323cbeaa13e0c63
https://github.com/wesnoth/wesnoth/commit/e3c7219a66d5e9070ea655ad0323cbeaa13e0c63
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_events/manager_impl.cpp
Log Message:
-----------
Game Events: made use of some emplace_back when constructing handlers
And added a clarifying comment about types.
Commit: 09b8fceb9e20c5e9994c386a4fe8a536e7569076
https://github.com/wesnoth/wesnoth/commit/09b8fceb9e20c5e9994c386a4fe8a536e7569076
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M src/game_events/handlers.cpp
M src/game_events/handlers.hpp
M src/game_events/manager_impl.cpp
Log Message:
-----------
Game Events: ensure event names are properly standardized in the config
This ensures all names are always valid to use in by-name lookup and are stored consistently.
Also fixes a potential issue in 2c12d1328ba6. I should have called standardize_name on each
name entry in the cleanup phase like when done in the registration phase, but this commit
ensures that's not needed anymore.
Commit: 87939501afeeb627b24c2b044082c67fb49daf7b
https://github.com/wesnoth/wesnoth/commit/87939501afeeb627b24c2b044082c67fb49daf7b
Author: Wedge009 <wedge009 at wedge009.net>
Date: 2017-11-30 (Thu, 30 Nov 2017)
Changed paths:
M projectfiles/VC12/wesnoth.vcxproj
M projectfiles/VC12/wesnoth.vcxproj.filters
Log Message:
-----------
Remove header from VC project (deleted in 056d7ac8).
[ci skip]
Compare: https://github.com/wesnoth/wesnoth/compare/cd61443f1cf3^...87939501afee
More information about the Commits
mailing list