[Commits] [wesnoth/wesnoth] 2d836d: campaignd: Use base64-encoded hashes for add-on pa...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2d836ddcd9bb6a657f4b9cc22a4a49d90fd0f276
      https://github.com/wesnoth/wesnoth/commit/2d836ddcd9bb6a657f4b9cc22a4a49d90fd0f276
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-10-08 (Sun, 08 Oct 2017)

  Changed paths:
    M changelog
    M src/campaign_server/campaign_server.cpp

  Log Message:
  -----------
  campaignd: Use base64-encoded hashes for add-on passphrases again

Fixes #2068.

As pointed out in the ticket, commit
98648ddf636bf4725d17334addac57850c478315 changed the implementation of
hex_digest() to use hexadecimal numbers instead of base64, causing new
calculated hashes during [upload] and other authenticated operations to
not match what campaignd already had on record.

This commit fixes that by using utils::md5::base64_digest() as
recommended by celticminstrel (which had already been done for wesnothd
but not campaignd, of course). It also matches the 1.12 version of the
campaignd hashing code this way.

Additionally, new uploads/passphrases since the deployment of that change
will need to be re-set by hand to get their base64 versions into the
server config.