[Commits] [wesnoth/wesnoth] b5bcee: Upgrade to Lua 5.3.4

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b5bcee1b2d942f09fea2b38e8c3ef61e7ca364ae
      https://github.com/wesnoth/wesnoth/commit/b5bcee1b2d942f09fea2b38e8c3ef61e7ca364ae
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M src/lua/COPYRIGHT
    M src/lua/lauxlib.cpp
    M src/lua/lauxlib.h
    M src/lua/lbaselib.cpp
    M src/lua/lcode.cpp
    M src/lua/ldebug.cpp
    M src/lua/ldo.cpp
    M src/lua/lgc.cpp
    M src/lua/liolib.cpp
    M src/lua/lmathlib.cpp
    M src/lua/loadlib.cpp
    M src/lua/lobject.cpp
    M src/lua/lobject.h
    M src/lua/lopcodes.h
    M src/lua/loslib.cpp
    M src/lua/lparser.cpp
    M src/lua/lstate.h
    M src/lua/lstrlib.cpp
    M src/lua/ltable.cpp
    M src/lua/ltable.h
    M src/lua/ltm.cpp
    M src/lua/lua.h
    M src/lua/luaconf.h
    M src/lua/lualib.h
    M src/lua/lutf8lib.cpp
    M src/lua/lvm.h

  Log Message:
  -----------
  Upgrade to Lua 5.3.4


  Commit: 217d2e1a15a777085bf7769f0b85d8a4786580f2
      https://github.com/wesnoth/wesnoth/commit/217d2e1a15a777085bf7769f0b85d8a4786580f2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M src/lua/lparser.cpp

  Log Message:
  -----------
  Apply Lua.org patch

Wrong code generated for a 'goto' followed by a label inside an 'if'.

reported by 云风 on 13 Apr 2017. existed since 5.2.

Example:
    See https://www.lua.org/bugs.html#5.3.4-1.


  Commit: 1c05370e4e86b96d3bbb7ce5ea41c9dfaa61919d
      https://github.com/wesnoth/wesnoth/commit/1c05370e4e86b96d3bbb7ce5ea41c9dfaa61919d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M src/lua/ldebug.cpp

  Log Message:
  -----------
  Apply Lua.org patch

Lua does not check GC when creating error messages.

reported by Viacheslav Usov on 06 Jul 2017. existed since 5.3.2.

Example:
    See https://www.lua.org/bugs.html#5.3.4-4.


  Commit: 0deaecccf9c5f9550db579a704d9adb67aae534c
      https://github.com/wesnoth/wesnoth/commit/0deaecccf9c5f9550db579a704d9adb67aae534c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M src/lua/lgc.cpp

  Log Message:
  -----------
  Apply Lua.org patch

Dead keys with nil values can stay in weak tables.

reported by 云风 Cloud Wu on 15 Aug 2017. existed since 5.2.

Example:
    See https://www.lua.org/bugs.html#5.3.4-5.


  Commit: bca27dc5baf595d6dfef151b73c8ce6ffd72bfff
      https://github.com/wesnoth/wesnoth/commit/bca27dc5baf595d6dfef151b73c8ce6ffd72bfff
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M src/wesnoth_lua_config.md

  Log Message:
  -----------
  Updated Lua update guide

* Fixed a few typos
* Updated the referenced version to 5.3.4.
* Updated build system-related instructions for 5b29805554178e66fcdc97693cfcb110cffc27ac.


  Commit: 8cb78ecf12fcc031c3adbec15d0dde63f5378871
      https://github.com/wesnoth/wesnoth/commit/8cb78ecf12fcc031c3adbec15d0dde63f5378871
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M changelog

  Log Message:
  -----------
  Updated changelog for Lua upgrade


  Commit: d0100758f855ec0d8f30dff41e8a8b6ff2d45fda
      https://github.com/wesnoth/wesnoth/commit/d0100758f855ec0d8f30dff41e8a8b6ff2d45fda
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-10 (Tue, 10 Oct 2017)

  Changed paths:
    M src/lua/luaconf.h

  Log Message:
  -----------
  Force static value for LUAL_BUFFERSIZE

In Lua 5.3.3, LUAL_BUFFERSIZE always equaled the constant since LUA_FLOAT_LONGDOUBLE was always defined.
This check changed in 5.3.4 and the alternate path was being used for LUAL_BUFFERSIZE and triggering
old-style cast warnings in Scons + GCC. Hopefully this gets fixed for 5.3.5.

The following patch constitutes the changes (though they were applied by hand):

*** luaconf.h.old       2017-10-09 23:38:22.641645801 -0500
--- luaconf.h   2017-10-09 23:38:56.548577911 -0500
***************
*** 748,758 ****
  ** smaller buffer would force a memory allocation for each call to
  ** 'string.format'.)
  */
- #if LUA_FLOAT_TYPE == LUA_FLOAT_LONGDOUBLE
  #define LUAL_BUFFERSIZE               8192
- #else
- #define LUAL_BUFFERSIZE   ((int)(0x80 * sizeof(void*) * sizeof(lua_Integer)))
- #endif

  /* }================================================================== */

--- 748,754 ----


Compare: https://github.com/wesnoth/wesnoth/compare/f80ae1ba5e40...d0100758f855