[Commits] [wesnoth/wesnoth] c32ede: campaignd: Blacklist standard reserved DOS Device ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c32eded71e3952e9ec82d21cbbc70a3ed87a7ba7
      https://github.com/wesnoth/wesnoth/commit/c32eded71e3952e9ec82d21cbbc70a3ed87a7ba7
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-10-24 (Tue, 24 Oct 2017)

  Changed paths:
    M src/addon/validation.cpp

  Log Message:
  -----------
  campaignd: Blacklist standard reserved DOS Device Names

Windows XP and later define DOS device names for several system devices
that will be handled as if they had directory entries everywhere. Their
names may not be used on the left side of a file name if a dot is
present, otherwise the read or write operation in progress (if
applicable) is redirected to the device in question, with unexpected
results (e.g. writing to CON writes to a console that may or may not be
attached, writing to COM1 will send data through the first enumerated
serial port, and so on).

Thus, we really don't want add-on authors to either intentionally or
accidentally use them on non-Windows platforms and cause Windows-based
clients to do unexpected things.

Emitting special messages for the UI in this case seems unnecessary and
it'll be a waste of space most of the time since these names should crop
up extremely rarely. Better just tell people what's up on a case-by-case
basis if they decide to post in the forums about it.