[Commits] [wesnoth/wesnoth] e2a697: Game Classification: formatting cleanup

GitHub noreply at github.com
Thu Oct 26 15:17:19 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e2a6979f602a1dd2e64a2460309e21850ff629d3
      https://github.com/wesnoth/wesnoth/commit/e2a6979f602a1dd2e64a2460309e21850ff629d3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/game_classification.cpp

  Log Message:
  -----------
  Game Classification: formatting cleanup


  Commit: 1bfa170856edacb235a35f5b6c3d874ff925f655
      https://github.com/wesnoth/wesnoth/commit/1bfa170856edacb235a35f5b6c3d874ff925f655
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-27 (Fri, 27 Oct 2017)

  Changed paths:
    M src/game_classification.cpp
    M src/game_classification.hpp
    M src/game_initialization/create_engine.cpp
    M src/game_initialization/lobby_data.cpp
    M src/game_initialization/mp_game_utils.cpp
    M src/game_initialization/multiplayer.cpp
    M src/mp_game_settings.cpp
    M src/mp_game_settings.hpp
    M src/server/server.cpp

  Log Message:
  -----------
  Backend changes to allow uses of proper display names for missing content in MP Lobby

For Campaigns, I needed to store the campaign name in the classification info.

For Eras, I repurposed the mp_era_addon_id key I added a year ago in d88f591eb5. It wasn't used anywhere
else, and having a better name for missing eras was the original reason to add it. I'm not sure why I
didn't think to use the name directly at the time; I do seem to have used addon_id for mod names too, but
that was changed in 5a55899b836d2 and again now (see below).

For Modifications, I added the relevant mod name to the server data. Why only this type of content
required a server change I'm not entirely sure. :/ This also finally properly fixes #1794.


Compare: https://github.com/wesnoth/wesnoth/compare/dbf2847a44e6...1bfa170856ed


More information about the Commits mailing list