[Commits] [wesnoth/wesnoth] c57b9a: Revert "Revert "Disallow specifying file paths wit...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c57b9a8f906be3154b47d1cb4e1dc317e4214c30
      https://github.com/wesnoth/wesnoth/commit/c57b9a8f906be3154b47d1cb4e1dc317e4214c30
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-28 (Sat, 28 Oct 2017)

  Changed paths:
    M RELEASE_NOTES
    M changelog
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  Revert "Revert "Disallow specifying file paths with backslashes""

This reverts commit 02de08338c0f31b79f1a6604fe7470ee77471323.

Mainline does *not* contain paths with backslashes. If it did, the game
would be broken on GNU/Linux and macOS (and we'd need to fix it anyway).
Instead, it's more likely that we have code somewhere that generates
paths dynamically using backslashes on Windows, and the correct fix is
to change that code to use forward slashes instead.


  Commit: a6df1750d1463f4f0de8966e5f150a0067ca7361
      https://github.com/wesnoth/wesnoth/commit/a6df1750d1463f4f0de8966e5f150a0067ca7361
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-28 (Sat, 28 Oct 2017)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  Save leader image paths with forward slashes

Backslashes in file paths aren't supported after commit 1b9c07e, and
saving them with backslashes prevents leader images from showing.


  Commit: 32621bddf6d8a6359d34fbc1e8b43d0f91f8776a
      https://github.com/wesnoth/wesnoth/commit/32621bddf6d8a6359d34fbc1e8b43d0f91f8776a
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-28 (Sat, 28 Oct 2017)

  Changed paths:
    M src/save_index.cpp
    M src/save_index.hpp

  Log Message:
  -----------
  Fix up leader image paths for existing saves

As a bonus, this also makes the images show up when a save from Windows
is loaded on GNU/Linux or macOS.
It would be particularly useful if Steam Cloud was supported.


Compare: https://github.com/wesnoth/wesnoth/compare/e4412d2646d1...32621bddf6d8