[Commits] [wesnoth/wesnoth] 073773: MP Lobby: completely redesigned game entry layout

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0737736d3c7441215a5246f6166e2a8e69642e4c
      https://github.com/wesnoth/wesnoth/commit/0737736d3c7441215a5246f6166e2a8e69642e4c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-29 (Sun, 29 Oct 2017)

  Changed paths:
    M changelog
    M data/gui/window/lobby_main.cfg
    A images/icons/icon-info-error.png
    A images/icons/icon-info.png
    M src/game_initialization/lobby_data.cpp
    M src/gui/dialogs/multiplayer/lobby.cpp
    M src/server/game.cpp

  Log Message:
  -----------
  MP Lobby: completely redesigned game entry layout

I did one of these about a year ago, but in the time since I realize it was honestly really crowded
and had some fundamental problems (for example, the listbox would get a horizontal scrollbar if a game
with a lot of mods was started).

This time around, I've focused on simplicity. The main changes:
* The minimap has been made 10 px larger. This was to accommodate the 5 px borders, so now the actual
  map image is 72x72.
* Game name and scenario name have swapped places, and the latter is now larger.
* Game names are no longer colorized based on the number of vacant slots or whether you can observe
  the game or not.
* The Turns/Slots label coloring has been toned down and been made larger. It is now either white
  (game has started), green (vacant slots available), or yellow (vacant slots available for reloaded game).
* The Turns limit  no longer displays "/-" for games with unlimited turns. Now you just get "Turn n".
* Due to 1bfa170856ed, proper names of all missing content is displayed. I also got rid of those
  "Unknown Scenario"/"Unknown Campaign" labels in favor of a simple red-color game type token (S or C),
  respectively.
* All game setting icons have been moved to a tooltip attached to an info icon, except those for
  Password Required and Observes Allowed.
* The info icon will also change color (and its tooltip display a message) if the player need to download
  additional content to join that game.


  Commit: b1ad293ccd0408d1418c23a322a42413ebfc6af3
      https://github.com/wesnoth/wesnoth/commit/b1ad293ccd0408d1418c23a322a42413ebfc6af3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-29 (Sun, 29 Oct 2017)

  Changed paths:
    R data/gui/window/mp_cmd_wrapper.cfg
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/VC12/wesnoth.vcxproj.filters
    M source_lists/wesnoth
    R src/gui/dialogs/multiplayer/mp_cmd_wrapper.cpp
    R src/gui/dialogs/multiplayer/mp_cmd_wrapper.hpp
    M src/tests/gui/test_gui2.cpp

  Log Message:
  -----------
  GUI2: removed unused MP Command Wrapper dialog

This was the equivalent of the Player Info dialog for the old GUI1 MP Lobby, and is now unused.
The new GUI2 lobby uses the aforementioned Player Info dialog. The functionality is basically
the same, though, except the send-private-message interface is more streamlined in the new lobby.


Compare: https://github.com/wesnoth/wesnoth/compare/d78ed1c36d50...b1ad293ccd04