[Commits] [wesnoth/wesnoth] 4ca25f: Lobby Info: store game_info objects directly in ID...

GitHub noreply at github.com
Mon Oct 30 22:36:44 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4ca25f11ca900b566e990d940859a6f630a97269
      https://github.com/wesnoth/wesnoth/commit/4ca25f11ca900b566e990d940859a6f630a97269
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-31 (Tue, 31 Oct 2017)

  Changed paths:
    M src/game_initialization/lobby_info.cpp
    M src/game_initialization/lobby_info.hpp

  Log Message:
  -----------
  Lobby Info: store game_info objects directly in ID map

I dunno why they were stored using pointers in the first place. Probably to avoid excessive copying
before we had std::move. When I changed the code to use unique_ptrs I didn't consider that the data
could be stored directly.


  Commit: 5f0bdb4c281b68c544afc4a014b9840878f3a8e9
      https://github.com/wesnoth/wesnoth/commit/5f0bdb4c281b68c544afc4a014b9840878f3a8e9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-31 (Tue, 31 Oct 2017)

  Changed paths:
    M data/multiplayer/scenarios/2p_Hornshark_Island.cfg
    A data/multiplayer/scenarios/2p_Hornshark_Island.lua
    R data/multiplayer/scenarios/2p_Hornshark_Island_lua

  Log Message:
  -----------
  Made Hornshark Island Lua file an actual Lua file

[ci skip]

Also simplified the Lua contained within. No need to create a local function just to immediately invoke it.


  Commit: 330bbcee789a4b5a61490bf941132e3ff814c10e
      https://github.com/wesnoth/wesnoth/commit/330bbcee789a4b5a61490bf941132e3ff814c10e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-10-31 (Tue, 31 Oct 2017)

  Changed paths:
    M src/scripting/lua_audio.cpp

  Log Message:
  -----------
  Merge branch 'master' of github.com:wesnoth/wesnoth


Compare: https://github.com/wesnoth/wesnoth/compare/cf4788cc3a1a...330bbcee789a


More information about the Commits mailing list