[Commits] [wesnoth/wesnoth] c6d869: Stop paranoid redraws of entire GUI2 windows

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c6d8692ac6d34c71835bd581fb07b900c4ba0c5b
      https://github.com/wesnoth/wesnoth/commit/c6d8692ac6d34c71835bd581fb07b900c4ba0c5b
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-10-31 (Tue, 31 Oct 2017)

  Changed paths:
    M changelog
    M players_changelog
    M src/gui/core/event/handler.cpp

  Log Message:
  -----------
  Stop paranoid redraws of entire GUI2 windows

Partial revert of commit 010edbe1b99a96736ebf36cbd696c0aca6cee404.

The commit caused every GUI2 window to be fully invalidated and redrawn 50
times per second, with massive CPU usage cost. No wonder that some players
have been complaining about too high CPU usage while idling in fullscreen
GUI dialogs.

I couldn't find any obvious regressions with this change. It looks like the
underlying issue has disappeared at some point.

In my tests, CPU usage while idling in the addon manager dropped from 17 %
to 2.5 % (across all cores).