[Commits] [wesnoth/wesnoth] 228b97: strcmp is bad

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 228b97108cc5e0aba91e8909b0c1ab65a8a5e201
      https://github.com/wesnoth/wesnoth/commit/228b97108cc5e0aba91e8909b0c1ab65a8a5e201
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M src/actions/attack.cpp
    M src/units/types.cpp

  Log Message:
  -----------
  strcmp is bad

Left the cases in scripting/lua_* alone since those functions get passes c strings from Lua. Might
be able to use string_view for those in the future. Also left a case in server/server_base.cpp alone
since it uses boost::shared_array.


  Commit: b5934273adef618270d488d8ee5ecb0635560973
      https://github.com/wesnoth/wesnoth/commit/b5934273adef618270d488d8ee5ecb0635560973
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-03 (Sun, 03 Sep 2017)

  Changed paths:
    M src/config.cpp
    M src/config.hpp
    M src/replay_recorder_base.cpp
    M src/replay_recorder_base.hpp
    M src/saved_game.cpp
    M src/saved_game.hpp
    M src/server/simple_wml.cpp
    M src/server/simple_wml.hpp
    M src/tstring.cpp
    M src/tstring.hpp
    M src/units/map.cpp
    M src/units/map.hpp
    M src/units/unit.cpp
    M src/units/unit.hpp

  Log Message:
  -----------
  Added non-member swap() functions for classes with member swap() functions

This is to enable them to work with std::swap.


  Commit: 0588204bdf857f373dc221edb59814272bbf25b7
      https://github.com/wesnoth/wesnoth/commit/0588204bdf857f373dc221edb59814272bbf25b7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-03 (Sun, 03 Sep 2017)

  Changed paths:
    M src/units/unit.cpp

  Log Message:
  -----------
  Fixup 20bf2b67842f


Compare: https://github.com/wesnoth/wesnoth/compare/20bf2b67842f...0588204bdf85