[Commits] [wesnoth/wesnoth] a3d5b9: Minor fixup to e8c7d72

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a3d5b9d603083ab0f3afcfbc9fc4c2432bb1623e
      https://github.com/wesnoth/wesnoth/commit/a3d5b9d603083ab0f3afcfbc9fc4c2432bb1623e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Minor fixup to e8c7d72

* Removed unnecessary reset() call
* Used a ternary operator for an assignment (I forgot unique_ptr accepts `nullptr` as a reset() argument).


  Commit: f47d78ddb2d7126db3e25603ec67ce98cbd767a9
      https://github.com/wesnoth/wesnoth/commit/f47d78ddb2d7126db3e25603ec67ce98cbd767a9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Revert "Actions/Attack: refactored out some reference-to-pointer mumbo-jumbo"

This reverts commit bc4af0d8320703d1a907b4adb310d9aa7ffcb89f. Turns out we need the reference after
all since `a_stats_` and `d_stats_` are modified and therefor this prevets `attacker_stats` and
`defender_stats` from being invalidated.


  Commit: 874ba1be7c51065aa58728054805481a570757ed
      https://github.com/wesnoth/wesnoth/commit/874ba1be7c51065aa58728054805481a570757ed
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M src/actions/attack.cpp

  Log Message:
  -----------
  Actions/Attack: cleaned up a few minor things


Compare: https://github.com/wesnoth/wesnoth/compare/c14f8160e556...874ba1be7c51