[Commits] [wesnoth/wesnoth] 5124b2: wam: Full refactor/reformatting of the HTML writer...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5124b2b6269acf207feed654aa45d766823e02af
      https://github.com/wesnoth/wesnoth/commit/5124b2b6269acf207feed654aa45d766823e02af
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M data/tools/addon_manager/html.py

  Log Message:
  -----------
  wam: Full refactor/reformatting of the HTML writer module

This is primarily a code clean-up and there are no known behavior
changes. Some of the code changes follow:

 * The add-on type labels and explanations are now part of a dictionary
   rather than embedded in the program logic so it's easier to change
   them in the future if more add-on types get added.
 * The full URL to each add-on tarball is HTML-escaped, instead of just
   the add-on id.
 * The list of HTML/CSS resources that need to be copied into the output
   dir is somewhere more visible.
 * Some indentation issues have been fixed.
 * html.escape is used instead of cgi.escaped

[ci skip]


  Commit: 10b175a73feb704d625a6cd108a8d29d23f91e2e
      https://github.com/wesnoth/wesnoth/commit/10b175a73feb704d625a6cd108a8d29d23f91e2e
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-09-04 (Mon, 04 Sep 2017)

  Changed paths:
    M data/tools/addon_manager/html.py

  Log Message:
  -----------
  wam: Percent-encode add-on tarball names

This is *not* really necessary right now because of the limited
character set we allow for add-on names (currently [A-Za-z0-9_-]), but
it doesn't hurt to future-proof this since odds that someone will change
the limitations in the C++ code at some point without remembering to
update this script are staggeringly high these days.

[ci skip]


Compare: https://github.com/wesnoth/wesnoth/compare/7cef972836a8...10b175a73feb