[Commits] [wesnoth/wesnoth] d08f40: fix 'at_end()' assertion faliure when chatting in ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d08f402ef1677a8389c9cdd0040d1c18a085d9f1
      https://github.com/wesnoth/wesnoth/commit/d08f402ef1677a8389c9cdd0040d1c18a085d9f1
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-09-06 (Wed, 06 Sep 2017)

  Changed paths:
    M src/replay.cpp

  Log Message:
  -----------
  fix 'at_end()' assertion faliure when chatting in a mp game

See #1857

This commit does 2 things:
1) Ensure that if the replay pos was at_end before a speak was added it will still be at end after the speak was added, fixes the mentioned assertion failure.
2) Make unsyced map_labels use the same logic as speak, this fixes OOS issues when the 'back to turn' mp feature was used in mp, since previously adding map labels while watching a mp replay (is the really possible? not 100% sure) might cause mismatches of replay_pos of other savegames with the current replay data.