[Commits] [wesnoth/wesnoth] 9a678d: Use saved_game::clear() to reset instead of creati...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9a678da618fe73fb7828ac320a36eca2ae398637
      https://github.com/wesnoth/wesnoth/commit/9a678da618fe73fb7828ac320a36eca2ae398637
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-06 (Wed, 06 Sep 2017)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_join_game.cpp

  Log Message:
  -----------
  Use saved_game::clear() to reset instead of creating a new object

Other such cases were also changed in 670bcf71a3f12.


  Commit: 5a05d7e8490690a2c76d3d9ee1a4a2ab4779147d
      https://github.com/wesnoth/wesnoth/commit/5a05d7e8490690a2c76d3d9ee1a4a2ab4779147d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-06 (Wed, 06 Sep 2017)

  Changed paths:
    M src/gui/widgets/toggle_button.cpp

  Log Message:
  -----------
  GUI2/Toggle Button: fixed modified events being fired twice on click

set_value fires the event, so there's no need for the click handler to do the same.


  Commit: 86f026281bf13b9e03345726cc6d74b627b3d7b2
      https://github.com/wesnoth/wesnoth/commit/86f026281bf13b9e03345726cc6d74b627b3d7b2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-06 (Wed, 06 Sep 2017)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.hpp

  Log Message:
  -----------
  MP Create Game: removed unnecessary mod-selected callback

That function used to handle displaying the mod info in the description field. However, as of e25aa4ac2ce03
the descriptions are shown as tooltips, rendering this function useless. on_mod_toggle calls set_current_mod_index
too, so that part wasn't needed either.


Compare: https://github.com/wesnoth/wesnoth/compare/0882d22b2204...86f026281bf1