[Commits] [wesnoth/wesnoth] acea15: GUI2: cleaned up NOTIFY_MODIFIED event triggers

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: acea15c312f178b2b6fe4556ca6b190b00866557
      https://github.com/wesnoth/wesnoth/commit/acea15c312f178b2b6fe4556ca6b190b00866557
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-10 (Sun, 10 Sep 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/scrollbar.cpp
    M src/gui/widgets/toggle_panel.cpp

  Log Message:
  -----------
  GUI2: cleaned up NOTIFY_MODIFIED event triggers

These should be in value setters instead of callback handlers so the events can be fired even when
changes are made programmatically.

Includes a change to the listbox to prevent infinite event recursion when handling toggle panels.
This expands the change from 0dbf686c4ffd to all selectable items.

Also called menu_button::set_selected in menu_button click handler to allow the event firing to be
done in a central place.


  Commit: 2280f7b1f48ef2b2e522b2868e0c0c55f260e4b0
      https://github.com/wesnoth/wesnoth/commit/2280f7b1f48ef2b2e522b2868e0c0c55f260e4b0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-10 (Sun, 10 Sep 2017)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp

  Log Message:
  -----------
  GUI2/Menu Button: removed unused member

Probably became unused once certain toggle functionality was split off into the multimenu button


Compare: https://github.com/wesnoth/wesnoth/compare/6e9a719390ad...2280f7b1f48e