[Commits] [wesnoth/wesnoth] f59e72: Use bool instead of string in config attribute ass...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f59e721aaae3ed8114d0c6398e4f1d9a8eee2d49
      https://github.com/wesnoth/wesnoth/commit/f59e721aaae3ed8114d0c6398e4f1d9a8eee2d49
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-11 (Mon, 11 Sep 2017)

  Changed paths:
    M src/game_initialization/create_engine.cpp
    M src/units/animation.cpp

  Log Message:
  -----------
  Use bool instead of string in config attribute assignment when possible

There are still a whole bunch of cases in GUI2 that look similar to this but are actually
assignments to a t_string. Should probably not use that for the use_markup attributes and
have those in WML.


  Commit: 903ff3154ebd9ec9ad3b74a6d6613610b617f415
      https://github.com/wesnoth/wesnoth/commit/903ff3154ebd9ec9ad3b74a6d6613610b617f415
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-11 (Mon, 11 Sep 2017)

  Changed paths:
    M src/gui/widgets/generator.hpp
    M src/gui/widgets/pane.hpp

  Log Message:
  -----------
  GUI2: removed some duplicate string_map typedefs

Keeping the one in widgets/widget.hpp, though since that's the same as utils::string_map I might make
it reference the latter at some point.


  Commit: a2ef0098f2ff85c28ef7de6936f31327bf7add48
      https://github.com/wesnoth/wesnoth/commit/a2ef0098f2ff85c28ef7de6936f31327bf7add48
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-11 (Mon, 11 Sep 2017)

  Changed paths:
    M src/game_initialization/create_engine.cpp
    M src/gui/dialogs/campaign_selection.cpp

  Log Message:
  -----------
  Refactor recording of completed difficulties

This stores the data in a completed_at key in the respective [difficulty] subtag instead of as a dedicated key
in the campaign config. This makes the code in Campaign Selection a bit easier to understand and will allow me
to implement the different colored laurels in the Campaign Difficulty dialog more easily.


Compare: https://github.com/wesnoth/wesnoth/compare/f86a4a77647a...a2ef0098f2ff