[Commits] [wesnoth/wesnoth] 3b5880: Fix #1980: [modify_unit] makes the unit disappear ...

GitHub noreply at github.com
Tue Sep 12 18:36:58 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3b5880f5fb07fdc986ea8efabf4918817cb16d6f
      https://github.com/wesnoth/wesnoth/commit/3b5880f5fb07fdc986ea8efabf4918817cb16d6f
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M data/lua/wml/kill.lua

  Log Message:
  -----------
  Fix #1980: [modify_unit] makes the unit disappear for a frame or two

Regression from commit d40a9e930b9fdf1095edf45f25885773654d0a4c.

In that commit I removed a redraw after the death animation of a killed
unit has been played, but just to be safe, I then added a redraw after the
unit has been erased from the map. Turns out it's not a good idea because
[modify_unit] operates by killing and recreating the unit.

This commit simply removes the redraw after erasing. Hopefully we aren't
relying on [kill] triggering a redraw somewhere.

[ci skip]





More information about the Commits mailing list