[Commits] [wesnoth/wesnoth] 3a5f51: Editor/Map Context: formatting cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3a5f515c6eee3190a7003ebaf49dcd3d0bae6c60
      https://github.com/wesnoth/wesnoth/commit/3a5f515c6eee3190a7003ebaf49dcd3d0bae6c60
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/editor/map/map_context.cpp

  Log Message:
  -----------
  Editor/Map Context: formatting cleanup


  Commit: 9c682f4dd05d28e6a17feecf436267ca6f4b5c38
      https://github.com/wesnoth/wesnoth/commit/9c682f4dd05d28e6a17feecf436267ca6f4b5c38
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/editor/map/map_context.cpp
    M src/editor/map/map_context.hpp

  Log Message:
  -----------
  Editor/Map Context: use unique_ptrs for undo/redo stacks


  Commit: d419caf24cdf6bd0a6fc4e68fe5f70d307cdb29d
      https://github.com/wesnoth/wesnoth/commit/d419caf24cdf6bd0a6fc4e68fe5f70d307cdb29d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/mouse_handler_base.hpp

  Log Message:
  -----------
  Mouse Handler Base: fix right-click behavior regression from c5dc04c900 (fixes #1967)

The above commit moved context menu handling from right_click to right_mouse_up. However, that removed
the early-exit if right_click_show_menu returned false. It seems some areas of the code (in this case,
the editor in editor_controller::right_click - don't ask me exactly how this leads to editor_controller::mouse_motion
where the codepath that caused the exception in the above bug is actually called, I didn't bother to trace it)
relied on that early exit to control behavior.

Making right_click return the value of right_click_show_menu by default fixes things.


Compare: https://github.com/wesnoth/wesnoth/compare/49e15e2e6a91...d419caf24cdf