[Commits] [wesnoth/wesnoth] ff2b9d: Editor/Actions: formatting cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ff2b9d17cce7f7e9e0487f88fb1b637d5b8849bb
      https://github.com/wesnoth/wesnoth/commit/ff2b9d17cce7f7e9e0487f88fb1b637d5b8849bb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/editor/action/action.cpp
    M src/editor/action/action.hpp
    M src/editor/action/action_base.hpp
    M src/editor/action/action_item.cpp
    M src/editor/action/action_item.hpp
    M src/editor/action/action_label.cpp
    M src/editor/action/action_label.hpp
    M src/editor/action/action_select.cpp
    M src/editor/action/action_select.hpp
    M src/editor/action/action_unit.cpp
    M src/editor/action/action_unit.hpp
    M src/editor/action/action_village.cpp
    M src/editor/action/action_village.hpp

  Log Message:
  -----------
  Editor/Actions: formatting cleanup


  Commit: 49d0af3445def7858e038c970efdbf5c84e6af50
      https://github.com/wesnoth/wesnoth/commit/49d0af3445def7858e038c970efdbf5c84e6af50
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/editor/action/action_village.cpp

  Log Message:
  -----------
  Editor/Action Village: deployed some range-for


  Commit: a6c17c1b23689ca9aab13e0b28454091cb5c1797
      https://github.com/wesnoth/wesnoth/commit/a6c17c1b23689ca9aab13e0b28454091cb5c1797
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/editor/action/action.cpp
    M src/editor/action/action.hpp
    M src/editor/action/action_base.hpp
    M src/editor/action/action_item.cpp
    M src/editor/action/action_item.hpp
    M src/editor/action/action_label.cpp
    M src/editor/action/action_label.hpp
    M src/editor/action/action_select.cpp
    M src/editor/action/action_select.hpp
    M src/editor/action/action_unit.cpp
    M src/editor/action/action_unit.hpp
    M src/editor/action/action_village.cpp
    M src/editor/action/action_village.hpp

  Log Message:
  -----------
  Editor/Actions: used helper macro to implement clone() and get_name() methods

In two cases, the action names were changed by the use of the macro:
* starting_pos -> starting_position
* resize -> resize_map

However this doesn't seem to have actually affected any editor functionality.


  Commit: 754ee29e59b0e07907b2f5dbbdd6106c0160df55
      https://github.com/wesnoth/wesnoth/commit/754ee29e59b0e07907b2f5dbbdd6106c0160df55
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/editor/action/action.hpp
    M src/editor/action/action_base.hpp
    M src/editor/action/action_item.hpp
    M src/editor/action/action_label.hpp
    M src/editor/action/action_select.hpp
    M src/editor/action/action_unit.hpp
    M src/editor/action/action_village.hpp

  Log Message:
  -----------
  Editor/Actions: made get_name() return a string reference instead of const char*

This also has the added benefit that a temporary string isn't created every time one
of these methods is called.


  Commit: 8d0282a6f95bd72f5d594e11e64432844e4888cc
      https://github.com/wesnoth/wesnoth/commit/8d0282a6f95bd72f5d594e11e64432844e4888cc
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-09-13 (Wed, 13 Sep 2017)

  Changed paths:
    M src/editor/action/action.cpp
    M src/editor/action/action_item.cpp
    M src/editor/action/action_label.cpp
    M src/editor/action/action_unit.cpp
    M src/editor/action/action_village.cpp
    M src/editor/controller/editor_controller.cpp
    M src/editor/editor_common.hpp
    M src/editor/map/map_context.cpp
    M src/editor/map/map_context.hpp

  Log Message:
  -----------
  Editor: added action ptr typedef and exposed action stack typedef

Also moved the action queue typedef to the editor_common header since I'm going to eventually use it
in the editor_action_chain implementation too.


Compare: https://github.com/wesnoth/wesnoth/compare/8de5a2e786b5...8d0282a6f95b