[Commits] [wesnoth/wesnoth] c6f523: Fix Coverity Uninitialized Scalar Warnings

GitHub noreply at github.com
Sun Sep 17 12:52:54 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c6f523f8cd7ba3636f68e08aff6087f8a4b021d6
      https://github.com/wesnoth/wesnoth/commit/c6f523f8cd7ba3636f68e08aff6087f8a4b021d6
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2017-09-17 (Sun, 17 Sep 2017)

  Changed paths:
    M src/events.cpp
    M src/gui/core/event/distributor.cpp
    M src/gui/core/event/handler.cpp
    M src/gui/widgets/window.cpp
    A src/sdl/userevent.hpp
    M src/video.cpp

  Log Message:
  -----------
  Fix Coverity Uninitialized Scalar Warnings

Coverity notes that SDL_UserEvent.windowID is never initialized. SDL documents that memset() should be used to initialize the structure. Subclassing the struct to add various constructors for clarity and future-proofing.

This closes

    CID 1380246
    CID 1380234
    CID 1380159
    CID 1380152
    CID 1356356

Earlier commit for these warnings only fixed the timestamp.





More information about the Commits mailing list