[Commits] [wesnoth/wesnoth] dbd669: Fix crash on startup with SDL 2.0.6

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: dbd6695da9da224f4700ffa4994a712f35efa7b5
      https://github.com/wesnoth/wesnoth/commit/dbd6695da9da224f4700ffa4994a712f35efa7b5
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-09-23 (Sat, 23 Sep 2017)

  Changed paths:
    M src/sdl/surface.hpp

  Log Message:
  -----------
  Fix crash on startup with SDL 2.0.6

Caused by https://github.com/SDL-mirror/SDL/commit/1db763c62fb31c7272d5b8b0bad163a4f76788d7.


  Commit: bc911f8c466f61c6edeab1db52938e0bbc01d3dd
      https://github.com/wesnoth/wesnoth/commit/bc911f8c466f61c6edeab1db52938e0bbc01d3dd
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-09-23 (Sat, 23 Sep 2017)

  Changed paths:
    M src/sdl/surface.hpp
    M src/video.cpp

  Log Message:
  -----------
  Fix another crash on startup with SDL 2.0.6

Caused by the same commit. SDL freed the old framebuffer even though we had
a reference to it, and when we passed it to SDL_FreeSurface(), it attempted
to free it again. It resulted in a crash depending on the C standard
library implementation and optimization level.


Compare: https://github.com/wesnoth/wesnoth/compare/ab5019e31332...bc911f8c466f