[wesnoth-commits] [wesnoth/wesnoth] 16dd9d: DM: Fix issues found by the schema validator

Fri Apr 6 03:34:09 UTC 2018

  Branch: refs/heads/schema_fixes
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 16dd9d553587e0ebd795aa5f2ff572fa083d7378
      https://github.com/wesnoth/wesnoth/commit/16dd9d553587e0ebd795aa5f2ff572fa083d7378
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Delfadors_Memoirs/scenarios/08_Ur_Thorodor.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg
    M data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg

  Log Message:
  -----------
  DM: Fix issues found by the schema validator

With this, DM is now clean of schema errors

  Commit: 4213eaabdd7ea1169513692463148d3dce50960f
      https://github.com/wesnoth/wesnoth/commit/4213eaabdd7ea1169513692463148d3dce50960f
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Dead_Water/scenarios/01_Invasion.cfg
    M data/campaigns/Dead_Water/scenarios/04_Slavers.cfg

  Log Message:
  -----------
  DW: Remove [message]duration key since it does absolutely nothing

  Commit: 3d3fc7e613ec99c349eed9e43f1ab88db1b3e65c
      https://github.com/wesnoth/wesnoth/commit/3d3fc7e613ec99c349eed9e43f1ab88db1b3e65c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg

  Log Message:
  -----------
  DW: Fix a couple more issues found by the schema validator

With this, DW is clean of schema errors

  Commit: d132040d24659733828795c5273148093720ca04
      https://github.com/wesnoth/wesnoth/commit/d132040d24659733828795c5273148093720ca04
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/maps/02_Dark_Business.map
    M data/campaigns/Secrets_of_the_Ancients/maps/03_Bandits.map
    M data/campaigns/Secrets_of_the_Ancients/maps/04_Becalmed.map
    M data/campaigns/Secrets_of_the_Ancients/maps/06_Following_the_Shadow.map
    M data/campaigns/Secrets_of_the_Ancients/maps/07_Meeting_of_the_Minds.map
    M data/campaigns/Secrets_of_the_Ancients/maps/08_Carcyn.map
    M data/campaigns/Secrets_of_the_Ancients/maps/09_Training_Session.map
    M data/campaigns/Secrets_of_the_Ancients/maps/11_Battleground.map
    M data/campaigns/Secrets_of_the_Ancients/maps/12_Walking_Trees.map
    M data/campaigns/Secrets_of_the_Ancients/maps/13_Together_Again.map
    M data/campaigns/Secrets_of_the_Ancients/maps/14_Entering_the_Northlands.map
    M data/campaigns/Secrets_of_the_Ancients/maps/15_Mountain_Pass.map
    M data/campaigns/Secrets_of_the_Ancients/maps/16_The_Mage.map
    M data/campaigns/Secrets_of_the_Ancients/maps/17_Mortality.map
    M data/campaigns/Secrets_of_the_Ancients/maps/18_Abandoned_Outpost.map
    M data/campaigns/Secrets_of_the_Ancients/maps/19_Lava_and_Stone.map

  Log Message:
  -----------
  SotA: Remove obsolete map headers

  Commit: 51c137dc3e16a23a98d70a0457af947860fc2d47
      https://github.com/wesnoth/wesnoth/commit/51c137dc3e16a23a98d70a0457af947860fc2d47
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/02_Dark_Business.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/05_Blackwater.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/20_North_Knalga.cfg
    M data/campaigns/Secrets_of_the_Ancients/utils/sota-utils.cfg

  Log Message:
  -----------
  SotA: Remove weird terrain='' convention

The wiki proscribes terrain=^ for this purpose, which has the bonus
of being detected as a valid terrain code by the schema.

  Commit: 786dd7abc76c0efab1f71a3a59aa8b041fd7cb6c
      https://github.com/wesnoth/wesnoth/commit/786dd7abc76c0efab1f71a3a59aa8b041fd7cb6c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/06_Following_the_Shadow.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/07_Meeting_of_the_Minds.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/15_Mountain_Pass.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/18_Abandoned_Outpost.cfg
    M data/campaigns/Secrets_of_the_Ancients/scenarios/21_Against_the_World.cfg

  Log Message:
  -----------
  SotA: Fix a few more issues found by the schema validator

With this, SotA is now clean of schema errors

  Commit: 56d9c6f2f662040dcaf0c6aa78a26be2705a494e
      https://github.com/wesnoth/wesnoth/commit/56d9c6f2f662040dcaf0c6aa78a26be2705a494e
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Sceptre_of_Fire/scenarios/1_A_Bargain_is_Struck.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/8_The_Dragon.cfg
    M data/campaigns/Sceptre_of_Fire/scenarios/9_Caverns_of_Flame.cfg

  Log Message:
  -----------
  SoF: Fix issues found by the schema validator

  Commit: 82a1e4b7459c3f312c2d673909ae1b6f840ca047
      https://github.com/wesnoth/wesnoth/commit/82a1e4b7459c3f312c2d673909ae1b6f840ca047
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/utils/herodeaths.cfg

  Log Message:
  -----------
  NR: usage= and alignment= not supported in SUF

  Commit: 20a057e8b4bf3e79df173780378c813854e1edd7
      https://github.com/wesnoth/wesnoth/commit/20a057e8b4bf3e79df173780378c813854e1edd7
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/02_01_Infested_Caves.cfg
    M data/campaigns/Northern_Rebirth/scenarios/02_02_Meeting_With_Dwarves.cfg
    M data/campaigns/Northern_Rebirth/scenarios/04_Clearing_the_Mines.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
    M data/campaigns/Northern_Rebirth/scenarios/05a_02_Dealings.cfg
    M data/campaigns/Northern_Rebirth/scenarios/07a_Settling_Disputes.cfg
    M data/campaigns/Northern_Rebirth/scenarios/08a_Elvish_Princess.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09a_Introductions.cfg
    M data/campaigns/Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg

  Log Message:
  -----------
  NR: Explicitly specify redundant side parameter in unit macros

  Commit: a946962ac234e89459334801ae8781c7090686f9
      https://github.com/wesnoth/wesnoth/commit/a946962ac234e89459334801ae8781c7090686f9
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/08b_Ray_of_Hope.cfg
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg

  Log Message:
  -----------
  NR: [ai]villages_per_scout= is an integer

  Commit: 20761e134e6c672894f471a203f5352291a533b9
      https://github.com/wesnoth/wesnoth/commit/20761e134e6c672894f471a203f5352291a533b9
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/12a_Get_the_Gold.cfg
    M data/campaigns/Northern_Rebirth/scenarios/13a_Showdown.cfg

  Log Message:
  -----------
  NR: [store_unit] does not support fire_event

  Commit: f6c769481536d4c33eedd60a10c06fd014600a42
      https://github.com/wesnoth/wesnoth/commit/f6c769481536d4c33eedd60a10c06fd014600a42
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Northern_Rebirth/scenarios/01_Breaking_the_Chains.cfg
    M data/campaigns/Northern_Rebirth/scenarios/06a_Old_Friend.cfg
    M data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg
    M data/campaigns/Northern_Rebirth/scenarios/11a_The_Eastern_Flank.cfg

  Log Message:
  -----------
  NR: Fix a few more issues found by the schema validator

With this, NR is clean of schema issues

  Commit: f7ff0edd995e4d4c3578f91a52fc4e7b404655fd
      https://github.com/wesnoth/wesnoth/commit/f7ff0edd995e4d4c3578f91a52fc4e7b404655fd
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/01_The_Morning_After.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/02_Across_the_Harsh_Sands.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg

  Log Message:
  -----------
  UtBS: [objectives] does not support show=

  Commit: 55eb9efdeb31ac563458854cf9f6cd0821a4a6a8
      https://github.com/wesnoth/wesnoth/commit/55eb9efdeb31ac563458854cf9f6cd0821a4a6a8
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/04_Descending_into_Darkness.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07b_Talking_with_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/10_Speaking_with_the_Fishes.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/11_Battle_for_Zocthanol_Isle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/13_Epilogue.cfg

  Log Message:
  -----------
  UtBS: [scenario]snapshot= doesn't seem like it would have any useful effect

(It's probably technically valid, as this key is part of the savegame WML.)

  Commit: 480445c9d9b196a8235bf137dcf97d9a84130627
      https://github.com/wesnoth/wesnoth/commit/480445c9d9b196a8235bf137dcf97d9a84130627
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/06a_In_the_Tunnels_of_Trolls.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg

  Log Message:
  -----------
  UtBS: silent= is meaningless in [object][modifications]

  Commit: 1bd9a46f6016e7e27bd7e0de3a36e58296e29589
      https://github.com/wesnoth/wesnoth/commit/1bd9a46f6016e7e27bd7e0de3a36e58296e29589
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/07a_Dealing_with_Dwarves.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg
    M data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg

  Log Message:
  -----------
  UtBS: Fix a few more issues found by the schema validator

With this, UtBS is as clean of schema errors as it'll get
(There are still two spurious errors remaining)

Compare: https://github.com/wesnoth/wesnoth/compare/c72b0d12d7ab...1bd9a46f6016