[wesnoth-commits] [wesnoth/wesnoth] 2edcbd: Convert uses of boost::thread to std::thread

GitHub noreply at github.com
Thu Apr 12 14:09:13 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2edcbdced8608936c50a9ec1e54ca07644d713d7
      https://github.com/wesnoth/wesnoth/commit/2edcbdced8608936c50a9ec1e54ca07644d713d7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-13 (Fri, 13 Apr 2018)

  Changed paths:
    M src/events.cpp
    M src/gui/dialogs/loading_screen.cpp
    M src/gui/dialogs/loading_screen.hpp
    M src/wesnothd_connection.cpp
    M src/wesnothd_connection.hpp

  Log Message:
  -----------
  Convert uses of boost::thread to std::thread

Also covers uses of boost::this_thread.

Turns out std::thread calls std::terminate if it's destroyed while still joinable.
thread::detach needs to be called or else the program will crash.

There's also no standard library equivalent of boost::thread::timed_join so I just
replaced it with the is_worker_running_ variable.




More information about the Commits mailing list