[wesnoth-commits] [wesnoth/wesnoth] 07b69b: Updated VS projectfile

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 07b69bdd32e02743de365ccbec6f731329cab600
      https://github.com/wesnoth/wesnoth/commit/07b69bdd32e02743de365ccbec6f731329cab600
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-14 (Sat, 14 Apr 2018)

  Changed paths:
    M projectfiles/VC14/wesnoth.vcxproj
    M projectfiles/VC14/wesnoth.vcxproj.filters

  Log Message:
  -----------
  Updated VS projectfile

[ci skip]


  Commit: 17fc9d71dbd933fa2e37c8fd9aed52a4e2fb5735
      https://github.com/wesnoth/wesnoth/commit/17fc9d71dbd933fa2e37c8fd9aed52a4e2fb5735
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-14 (Sat, 14 Apr 2018)

  Changed paths:
    M src/gui/auxiliary/iterator/walker_grid.cpp
    M src/gui/auxiliary/iterator/walker_tree_node.cpp
    M src/gui/auxiliary/iterator/walker_widget.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/screenshot_notification.cpp
    M src/utils/functional.hpp

  Log Message:
  -----------
  Removed bind_void

This is no longer needed with the compilers we support. It is needed on VS 2013, but
we dropped that. Don't know when GCC or Clang stopped needed it (if they ever did).

I'm guessing the "function that returns a value cannot be bound in a function type
that returns void" behavior wasn't an intentional design. Additionally, I don't believe
point 1 raised in the accompanying comment has ever been true... if so, pretty sure
we wouldn't have been able to build at all.

Also removed unnecessary global.hpp include from functional.hpp.


  Commit: 00d87f8fe4078ffd84fcdc0d73fcc2104efef1e7
      https://github.com/wesnoth/wesnoth/commit/00d87f8fe4078ffd84fcdc0d73fcc2104efef1e7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-14 (Sat, 14 Apr 2018)

  Changed paths:
    M src/serialization/string_view.hpp

  Log Message:
  -----------
  String View: use std::string_view on C++17 (untested)


  Commit: 96681151f083bb25a3ddb3301083241e36fd6789
      https://github.com/wesnoth/wesnoth/commit/96681151f083bb25a3ddb3301083241e36fd6789
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-04-14 (Sat, 14 Apr 2018)

  Changed paths:
    M src/gettext_boost.cpp
    M src/global.hpp
    M src/wml_exception.hpp

  Log Message:
  -----------
  Expand NORETURN, enable C99 unconditionally on MSVC

[[noreturn]] is supported on all the compilers we support. Still need to decide
the exact minimum versions and figure out what to do with DEPRECATED and FALLTHROUGH,
so leaving those for now.

And since we require VS 2015 and up we can enable C99 unconditionally.


Compare: https://github.com/wesnoth/wesnoth/compare/164b6af76688...96681151f083