[wesnoth-commits] [wesnoth/wesnoth] ac1e3e: MP load game: do not overwrite saved AI

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ac1e3e6120dcec3eab5216a0dce1811d4c5c4b85
      https://github.com/wesnoth/wesnoth/commit/ac1e3e6120dcec3eab5216a0dce1811d4c5c4b85
  Author: mattsc <mattsc000 at gmail.com>
  Date:   2018-12-23 (Sun, 23 Dec 2018)

  Changed paths:
    M changelog.md
    M src/game_initialization/connect_engine.cpp
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/multiplayer/mp_staging.hpp

  Log Message:
  -----------
  MP load game: do not overwrite saved AI

When an MP game is saved and then reloaded from the MP Create Game screen, one goes through the Game Lobby screen which gives the option of changing controllers and AIs for the different sides. Previously, this added an AI stage in front of the already existing AI for all computer player sides. This effectively replaced the existing AI.

This commit adds an option "Keep saved AI" to the Computer Player selection menu (when loading games only) and makes it the default. It does nothing to the AI config if this is chosen, otherwise it uses the new AI and also removes the old AI stages from the config.

This fixes #3791.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.