[wesnoth-commits] [wesnoth/wesnoth] 7b4f98: Config: optimized merge_children and merge_childre...

GitHub noreply at github.com
Wed Feb 21 05:43:08 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7b4f98075c2590e2fa1c3a0fb24d163088111ed1
      https://github.com/wesnoth/wesnoth/commit/7b4f98075c2590e2fa1c3a0fb24d163088111ed1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/config.cpp

  Log Message:
  -----------
  Config: optimized merge_children and merge_children_by_attribute

This should mean a performance boost when the game config manager processes [units] tags.
Since they're all merged into one, it's very likely whole addon's worth of unit type configs
were being copied (twice)! Worth noting that a lot of addons use the tag amendment syntax
([+units]), but it's unlikely that meant no copying was done at all.


  Commit: a2eb75db6c79dd37846c92d5ec7a647d4a9ca69c
      https://github.com/wesnoth/wesnoth/commit/a2eb75db6c79dd37846c92d5ec7a647d4a9ca69c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-21 (Wed, 21 Feb 2018)

  Changed paths:
    M src/config.cpp

  Log Message:
  -----------
  Config: fixed possibly unspecified behavior when using append_children_by_move


Compare: https://github.com/wesnoth/wesnoth/compare/35d9b3046361...a2eb75db6c79


More information about the Commits mailing list