[wesnoth-commits] [wesnoth/wesnoth] 05d52c: Fixed custom game title being lost when reloading ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 05d52c5db5aa05286479f547c941682b6c5deca0
      https://github.com/wesnoth/wesnoth/commit/05d52c5db5aa05286479f547c941682b6c5deca0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-22 (Thu, 22 Feb 2018)

  Changed paths:
    M src/game_initialization/create_engine.cpp

  Log Message:
  -----------
  Fixed custom game title being lost when reloading game (fixes #2534)

This stems from 0337835d97c8e490f6c63ddb7af0314007612a72. I imagine at the time reloaded games
got no titles at all, so they were just given the default one ("[Player]'s game)". Testing now
shows that the reloaded game correctly carries over its original title. Since the default tile
is fallen back on when the game is originally created if if no custom title is given, there will
always be a title when you reload.

I'm guessing this might have been a side effect of 728b29dc61de885105c82350574fc3c411c18c70,
but I'm not sure. Still, it's nice that it Just Works.