[wesnoth-commits] [wesnoth/wesnoth] 855473: Connect Engine: fixed leaving observers not being ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 855473f36ccbe5251fc020a411d38a5cde5c416f
      https://github.com/wesnoth/wesnoth/commit/855473f36ccbe5251fc020a411d38a5cde5c416f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-23 (Fri, 23 Feb 2018)

  Changed paths:
    M src/game_initialization/connect_engine.cpp

  Log Message:
  -----------
  Connect Engine: fixed leaving observers not being removed from controller option list

Fixes #2519. update_side_controller_options updates the actually values MP Staging uses in
its controller dropdown, so it should be updated regardless if the observer was assigned a
side or not.

Also stopped using a t_string reference for the name key... player names aren't translatable.