[wesnoth-commits] [wesnoth/wesnoth] 599267: disable Depcheck in SP

GitHub noreply at github.com
Sun Feb 25 00:39:12 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5992672dafde1af2ef34d5f32c8e2da2f5cf5f99
      https://github.com/wesnoth/wesnoth/commit/5992672dafde1af2ef34d5f32c8e2da2f5cf5f99
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-02-25 (Sun, 25 Feb 2018)

  Changed paths:
    M src/game_initialization/create_engine.cpp

  Log Message:
  -----------
  disable Depcheck in SP

this is not the best fix for #2229 (Depcheck prompts for era selection when selecting mods in SP). Is basicially partly reverts https://github.com/wesnoth/wesnoth/commit/2f1c1e38362ff8336b15dc622d5a8ea5ea04e0d9#diff-0c76da729be4efff30ec9e40d29677b8 which also removed these checks.

Of course it would be much better if we actually manage to get the depcheck working in sp, this would require a somw work in gui/dialogs/campaign_selection.cpp to change ui the buttons/listsbox state accoridingly whenever the depcheck reverted a humanmade decision. Similar to what i impelemented in 2f1c1e38362 for mp_create_game.cpp




More information about the Commits mailing list