[Commits] [wesnoth/wesnoth] 9de278: Fixed SP option variables never being set (fixes #...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9de27832004d3bb1bdc6cdd1462011794e19ac2f
      https://github.com/wesnoth/wesnoth/commit/9de27832004d3bb1bdc6cdd1462011794e19ac2f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-02 (Fri, 02 Feb 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp

  Log Message:
  -----------
  Fixed SP option variables never being set (fixes #2401)

Was just missing a check for the SP_CAMPAIGN type.


  Commit: 30172c8ebe9961bd0cf387b073114752f2c87bfc
      https://github.com/wesnoth/wesnoth/commit/30172c8ebe9961bd0cf387b073114752f2c87bfc
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-02 (Fri, 02 Feb 2018)

  Changed paths:
    M src/game_initialization/configure_engine.cpp
    M src/game_initialization/configure_engine.hpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp

  Log Message:
  -----------
  Fixed SP option selections not being saved

Had forgotten to call prefrences::set_options. Instead of adding an extra call in the
SP Options Manager, I just moved the call to configure_engine::set_options, which is
called by both SP and MP codepaths.


Compare: https://github.com/wesnoth/wesnoth/compare/eee4b4e14738...30172c8ebe99