[Commits] [wesnoth/wesnoth] edd6b8: Fixed most SUF keys matching all units if given ""...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: edd6b8d31cb730a892308c745605c30dcaa804ce
      https://github.com/wesnoth/wesnoth/commit/edd6b8d31cb730a892308c745605c30dcaa804ce
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-11 (Sun, 11 Feb 2018)

  Changed paths:
    M changelog
    M src/units/filter.cpp

  Log Message:
  -----------
  Fixed most SUF keys matching all units if given "" as a value

This was a regression from a6decea0fcfd3b0af3520d2637cf085da7277eb5. We only want to ignore
keys if they're not provided. An empty key ("") should match nothing.

Fixes #1405 (a specific bug about id="" matching all units).


  Commit: c5e95d3b245411dfa5a8d722e0bd61f9d9635db5
      https://github.com/wesnoth/wesnoth/commit/c5e95d3b245411dfa5a8d722e0bd61f9d9635db5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-11 (Sun, 11 Feb 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/lobby.cpp

  Log Message:
  -----------
  MP Lobby: avoid unnecessary cache rebuild if no required addons were installed

I was unconditionally reloading the cache even if there were a reason ad_hoc_addon_fetch_session
failed. The cache will no longer be reloaded if said function didn't actually install anything.

Fixes #2477.


Compare: https://github.com/wesnoth/wesnoth/compare/298b4486cd55...c5e95d3b2454