[Commits] [wesnoth/wesnoth] 908b93: Fix my fix to my fix (fixup 0990613)

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 908b936c8c2db94a93a9499b3a30ab7abfd2afd7
      https://github.com/wesnoth/wesnoth/commit/908b936c8c2db94a93a9499b3a30ab7abfd2afd7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-02-15 (Thu, 15 Feb 2018)

  Changed paths:
    M src/scripting/game_lua_kernel.cpp

  Log Message:
  -----------
  Fix my fix to my fix (fixup 0990613)

@gfgtdf

Turns out I forgot to consider the old village being unassigned, which would
make the exception on getting the old team a common occurrence. I've changed
the code to continue on if it can't unassign the village.

I also noticed a slight semantic change: unassignment of the old side used to
be skipped if the new was defeated, but now it's not. Dunno if that's a big deal.