[Commits] [wesnoth/wesnoth] 9556d2: Don't assume unit is on the map when testing abili...

[GitHub]

  Branch: refs/heads/fix_2247
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9556d2b1e4e3732ac8a023d4a93d55a3dec153fa
      https://github.com/wesnoth/wesnoth/commit/9556d2b1e4e3732ac8a023d4a93d55a3dec153fa
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2018-02-19 (Mon, 19 Feb 2018)

  Changed paths:
    M src/actions/attack.cpp
    M src/gui/dialogs/attack_predictions.cpp
    M src/reports.cpp
    M src/units/abilities.cpp
    M src/units/attack_type.hpp

  Log Message:
  -----------
  Don't assume unit is on the map when testing ability active

This refactors ability tests to use a passed-in unit instead of
searching for the unit on the map based on its location.

While it does fix #2247, I am not confident that this won't also
have some undesirable side-effects.