[Commits] [wesnoth/wesnoth] c9ec11: Addon client: close connection if the player cance...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c9ec111cf1150d80af844c8d9d33146f9e4556e0
      https://github.com/wesnoth/wesnoth/commit/c9ec111cf1150d80af844c8d9d33146f9e4556e0
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-13 (Sat, 13 Jan 2018)

  Changed paths:
    M changelog
    M players_changelog
    M src/addon/client.cpp
    M src/addon/client.hpp
    M src/gui/dialogs/network_transmission.cpp
    M src/gui/dialogs/network_transmission.hpp

  Log Message:
  -----------
  Addon client: close connection if the player cancels the download

This ensures that the game won't interpret the rest of the addon as a
response for the client's next request.

Fixes #2203.


  Commit: 735c054bd305ad323d3f61523811a43d77f31fd5
      https://github.com/wesnoth/wesnoth/commit/735c054bd305ad323d3f61523811a43d77f31fd5
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-13 (Sat, 13 Jan 2018)

  Changed paths:
    M src/addon/client.cpp
    M src/addon/client.hpp
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  Don't reconnect to server when the player cancels connecting to server

Requested by @loonycyborg.


  Commit: 873193040230a78ec3ab4314e266de390f649fbe
      https://github.com/wesnoth/wesnoth/commit/873193040230a78ec3ab4314e266de390f649fbe
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-13 (Sat, 13 Jan 2018)

  Changed paths:
    M src/addon/client.cpp
    M src/addon/client.hpp
    M src/addon/manager_ui.cpp
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  Fix: canceling attempt to reconnect didn't close addon manager

Only happened if the player used the buttons in the addon list: the buttons
in the right panel worked fine. The problem was that the addon list caught
the addons_client::user_exit exception separately and didn't rethrow it
when necessary, unlike the addon manager itself.

I decided to simply throw a different exception instead.


Compare: https://github.com/wesnoth/wesnoth/compare/03b6ad568c6e...873193040230