[Commits] [wesnoth/wesnoth] 3bc36e: Refuse to save if game state can't be represented ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3bc36efa5898a95ce793195e24b4dee1b546c222
      https://github.com/wesnoth/wesnoth/commit/3bc36efa5898a95ce793195e24b4dee1b546c222
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-17 (Wed, 17 Jan 2018)

  Changed paths:
    M src/config.cpp
    M src/config.hpp
    M src/savegame.cpp

  Log Message:
  -----------
  Refuse to save if game state can't be represented as valid WML (#2375)

Such a save file can't be loaded anyway.
This way, at least the player can't overwrite an existing, working save
with one that cannot be loaded.


  Commit: 1386e3945c4c8ddc4c74e87e586f93f642b9b2a6
      https://github.com/wesnoth/wesnoth/commit/1386e3945c4c8ddc4c74e87e586f93f642b9b2a6
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-17 (Wed, 17 Jan 2018)

  Changed paths:
    A data/test/scenarios/test_lua_wml_tagnames.cfg
    M wml_test_schedule

  Log Message:
  -----------
  Added unit tests about which WML tag names Lua API accepts


  Commit: 52e3772c862e37bc411ef18c19d289f43bea506b
      https://github.com/wesnoth/wesnoth/commit/52e3772c862e37bc411ef18c19d289f43bea506b
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-17 (Wed, 17 Jan 2018)

  Changed paths:
    M src/scripting/lua_common.cpp

  Log Message:
  -----------
  Lua API: reject invalid WML tag names (#2375)

Tags that the WML parser rejects shouldn't be possible to create with Lua,
either. This ensures that a UMC author can't accidentally, or deliberately,
inject such tags into the game state and make saving the game impossible.

Fixes #2375.


Compare: https://github.com/wesnoth/wesnoth/compare/5df406869a1f...52e3772c862e