[Commits] [wesnoth/wesnoth] fbb0e0: Improve consistency of WML name validation functio...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: fbb0e0229cf4c870fef69e0b6729e9a1ea69b6fe
      https://github.com/wesnoth/wesnoth/commit/fbb0e0229cf4c870fef69e0b6729e9a1ea69b6fe
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-01-19 (Fri, 19 Jan 2018)

  Changed paths:
    M src/config.cpp
    M src/config.hpp
    M src/scripting/lua_common.cpp
    M src/serialization/parser.cpp
    M src/variable_info_private.hpp

  Log Message:
  -----------
  Improve consistency of WML name validation functions

* moved the new function next to valid_id()
* renamed to valid_tag(), and renamed valid_id() to valid_attribute()
* removed unnecessary parentheses I forgot in
* changed the name of valid_id()'s parameter from "id" to "name"
* changed WML parser to use valid_tag() when it validates tag names

Thanks to @CelticMinstrel who told me about config::valid_id().