[Commits] [wesnoth/wesnoth] 786233: Replace resources::screen with game_display single...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 786233d5c95913889d6f061f3749f80a5efd61c1
      https://github.com/wesnoth/wesnoth/commit/786233d5c95913889d6f061f3749f80a5efd61c1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-26 (Fri, 26 Jan 2018)

  Changed paths:
    M src/actions/advancement.cpp
    M src/actions/attack.cpp
    M src/actions/create.cpp
    M src/actions/heal.cpp
    M src/actions/move.cpp
    M src/actions/undo.cpp
    M src/actions/undo_move_action.cpp
    M src/actions/undo_recall_action.cpp
    M src/actions/undo_recruit_action.cpp
    M src/actions/unit_creator.cpp
    M src/actions/vision.cpp
    M src/ai/contexts.cpp
    M src/ai/default/recruitment.cpp
    M src/ai/formula/ai.cpp
    M src/arrow.cpp
    M src/editor/action/action_item.cpp
    M src/editor/action/action_unit.cpp
    M src/floating_textbox.cpp
    M src/formula/debugger.cpp
    M src/game_events/action_wml.cpp
    M src/game_events/pump.cpp
    M src/gui/dialogs/label_settings.cpp
    M src/gui/dialogs/multiplayer/mp_change_control.cpp
    M src/minimap.cpp
    M src/pathfind/pathfind.cpp
    M src/play_controller.cpp
    M src/playturn.cpp
    M src/preferences/display.cpp
    M src/replay.cpp
    M src/resources.cpp
    M src/resources.hpp
    M src/scripting/lua_common.cpp
    M src/synced_commands.cpp
    M src/synced_user_choice.cpp
    M src/whiteboard/attack.cpp
    M src/whiteboard/highlighter.cpp
    M src/whiteboard/manager.cpp
    M src/whiteboard/move.cpp
    M src/whiteboard/recall.cpp
    M src/whiteboard/recruit.cpp
    M src/whiteboard/side_actions.cpp
    M src/whiteboard/suppose_dead.cpp
    M src/whiteboard/utility.cpp

  Log Message:
  -----------
  Replace resources::screen with game_display singleton

This is consistent with the use of display::get_singleton() (in fact, it's the same
pointer). It also makes the code more readable, and means we get to further clean up
the resources set.


  Commit: c616d8274fccafa12a9bc33b3c61bd9632566e37
      https://github.com/wesnoth/wesnoth/commit/c616d8274fccafa12a9bc33b3c61bd9632566e37
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-26 (Fri, 26 Jan 2018)

  Changed paths:
    M src/arrow.cpp

  Log Message:
  -----------
  Avoid unnecessary double dynamic_cast

Could have been using the display singleton all this time, but it became a double cast
with the change from resources::screen to the game_display singleton.


Compare: https://github.com/wesnoth/wesnoth/compare/d11b62590f85...c616d8274fcc