[Commits] [wesnoth/wesnoth] ab4580: Revert "Display Context: added write-access units(...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ab4580c6ea01fd4a7364ee4bf53fdc293767669a
      https://github.com/wesnoth/wesnoth/commit/ab4580c6ea01fd4a7364ee4bf53fdc293767669a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-27 (Sat, 27 Jan 2018)

  Changed paths:
    M src/display_context.hpp
    M src/editor/map/map_context.hpp
    M src/pathfind/teleport.cpp
    M src/tests/gui/test_gui2.cpp

  Log Message:
  -----------
  Revert "Display Context: added write-access units() overload (pure virtual)"

This reverts commit 0f8e25f970ee9b8fba010c5ffa528aa6238d8900. For some damn reason
this was causing invalid access crashes for me on VS 2017 release builds, but no one
else could repro. Since I can implement a non-const accessor in the map_context class
anyway, I'm reverting.


  Commit: 24e40cc0b18a9167f1a910b946cc64586450a77b
      https://github.com/wesnoth/wesnoth/commit/24e40cc0b18a9167f1a910b946cc64586450a77b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-01-27 (Sat, 27 Jan 2018)

  Changed paths:
    M src/editor/map/map_context.hpp

  Log Message:
  -----------
  Editor/Map Context: made non-const units accessor local to this class

Since having a non-const pure virtual member of display_context was causing crashes, and
it was only needed here, I've made it a local class member.


Compare: https://github.com/wesnoth/wesnoth/compare/88b31f260952...24e40cc0b18a