[wesnoth-commits] [wesnoth/wesnoth] ca90ca: Fix #2813: wrong chat color after a side is unassi...

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ca90ca35f002a2bc0e7a9f57b445369fd6390a09
      https://github.com/wesnoth/wesnoth/commit/ca90ca35f002a2bc0e7a9f57b445369fd6390a09
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M src/server/game.cpp

  Log Message:
  -----------
  Fix #2813: wrong chat color after a side is unassigned from a player

Regression from commit 36e9290.

As @gfgtdf pointed out in the bug report, because old_player was a
reference to the shared_ptr, resetting the shared_ptr in sides_ also
changed old_player, and thus 'the player lost his last side' check never
passed.

Thanks to @gfgtdf for figuring out the cause.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.