[wesnoth-commits] [wesnoth/wesnoth] fa7c96: GUI2/Tree View: added interface for moving nodes b...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: fa7c967c0a3645734d93d56c1ade8ca394d20846
      https://github.com/wesnoth/wesnoth/commit/fa7c967c0a3645734d93d56c1ade8ca394d20846
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/tree_view_node.cpp
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  GUI2/Tree View: added interface for moving nodes between parent nodes


  Commit: ae7d05e8fc8618aa247aae04b3a03431f7b0f0a7
      https://github.com/wesnoth/wesnoth/commit/ae7d05e8fc8618aa247aae04b3a03431f7b0f0a7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_staging.cpp
    M src/gui/dialogs/multiplayer/mp_staging.hpp

  Log Message:
  -----------
  MP Staging: move side nodes when changing teams instead of recreating them

Mp Join Game will require further refactoring; it recreates the entire tree when receiving data...


  Commit: 8da9f0cc04e8cdca1c98aa42bbfbc7d8ba02ab9f
      https://github.com/wesnoth/wesnoth/commit/8da9f0cc04e8cdca1c98aa42bbfbc7d8ba02ab9f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  GUI2/Tree View Node: used std::make_shared when possible

Child nodes were still managed with unique_ptrs in 1.14, so we couldn't use make_unique
there. Child nodes are now managed with shared_ptrs here on master.


Compare: https://github.com/wesnoth/wesnoth/compare/d5972c6f43e7...8da9f0cc04e8
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.