[wesnoth-commits] [wesnoth/wesnoth] e62ec5: GUI2/Tree View: use NOTIFY_MODIFIED events instead...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e62ec5f8060cb18de166b990fdca5b4653d26049
      https://github.com/wesnoth/wesnoth/commit/e62ec5f8060cb18de166b990fdca5b4653d26049
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2018-07-14 (Sat, 14 Jul 2018)

  Changed paths:
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/gamestate_inspector.cpp
    M src/gui/dialogs/help_browser.cpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/tree_view_node.cpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  GUI2/Tree View: use NOTIFY_MODIFIED events instead of manual callbacks

Unlike other widgets where `this` is the event target, the tree nodes fire the event
with the tree widget itself as the target.

I had added a fire-event call in f97dc8ae12be1b8982ab87b748266f915a84e15d, but with
the target as the node. I don't think there was any way that would have worked...
changed.



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.