[wesnoth-commits] [wesnoth/wesnoth] 0917a7: fix require_scenario & require_era

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0917a78c0257e317114828d23c0e7818bc6183d2
      https://github.com/wesnoth/wesnoth/commit/0917a78c0257e317114828d23c0e7818bc6183d2
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-07-28 (Sat, 28 Jul 2018)

  Changed paths:
    M src/game_initialization/lobby_data.cpp
    M src/server/server.cpp

  Log Message:
  -----------
  fix require_scenario & require_era

previously both were broken:
1) 'require_scenario' was only checked if the scenario was installed
which obviously doesn't make any sense at all.
2) 'require_scenario' was read from the local scenario data instead from
the remote scenario.
3) 'require_era' was only checked when the scenario was not installed,
so people who do have an outated version of the era installed could not
join bacause it assumed require_era=yes in that case.
4) the server tried to read 'require_scenario' from the wrong wml node,
'require_scenario' is an attribute of [scenario] and not of savefile
toplevel.


  Commit: b107a26dd11a1d1e70dfa07783a977b3c4f4588a
      https://github.com/wesnoth/wesnoth/commit/b107a26dd11a1d1e70dfa07783a977b3c4f4588a
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-07-28 (Sat, 28 Jul 2018)

  Changed paths:
    M src/game_initialization/playcampaign.cpp

  Log Message:
  -----------
  fix skip replay being active in later scenarios

in mp campaigns.


  Commit: 02804c1482f6ea7cd4e8f081d57e8fe7b18296ff
      https://github.com/wesnoth/wesnoth/commit/02804c1482f6ea7cd4e8f081d57e8fe7b18296ff
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-07-28 (Sat, 28 Jul 2018)

  Changed paths:
    M src/server/server.cpp
    M src/server/server.hpp

  Log Message:
  -----------
  add server notifications about outdated wesnoth versions.


Compare: https://github.com/wesnoth/wesnoth/compare/a793bce96942...02804c1482f6
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.