[wesnoth-commits] [wesnoth/wesnoth] af90ec: fix game crashing when showing a too large tooltip

[GitHub]

  Branch: refs/heads/1.14
  Home:   https://github.com/wesnoth/wesnoth
  Commit: af90ecac6e13aeda45587761f11190ed0673023f
      https://github.com/wesnoth/wesnoth/commit/af90ecac6e13aeda45587761f11190ed0673023f
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2018-07-31 (Tue, 31 Jul 2018)

  Changed paths:
    M data/gui/window/tooltip_floating.cfg

  Log Message:
  -----------
  fix game crashing when showing a too large tooltip

previously the game would go into an infinite loop at
https://github.com/wesnoth/wesnoth/blob/1.14.4/src/gui/widgets/window.cpp#L1046
when a tooltip doesn't fit on screen, this could in particular happen in
the mp lobby when hovering over the 'i' of a game that uses a ridiculous
amount of modifications.

I currently don't see any case where the game is actually able to 'fix'
a bad height that was reported from reevaluate_best_size. so i just
disable reevaluate_best_size for floating tooltips.

If there exists such a case, an alternative fix could be to change the
reevaluate loop in window::layout to also stop when a new iteration
returned the same size as the previous iteration.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.